highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-12 06:58:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Add LIFETIMEBOUND to all (w)txid getters

Browse Source 
Then, use the compiler warnings to create copies only where needed.

Also, fix iwyu includes while touching the includes.
This commit is contained in:
MarcoFalke
2023-10-27 12:38:21 +02:00
parent e789b30b25
commit faec889f93
6 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/wallet/test/wallet_tests.cpp
View File

@@ -963,7 +963,7 @@ BOOST_FIXTURE_TEST_CASE(wallet_sync_tx_invalid_state_test, TestingSetup)
mtx.vin.clear();
mtx.vin.emplace_back(tx_id_to_spend, 0);
wallet.transactionAddedToMempool(MakeTransactionRef(mtx));
const uint256& good_tx_id = mtx.GetHash();
const auto good_tx_id{mtx.GetHash().ToUint256()};
{
// Verify balance update for the new tx and the old one