util: Document why ArgsManager (con/de)structor is not inline

This commit is contained in:
MarcoFalke
2020-04-16 12:26:01 -04:00
parent fae00a77e2
commit faf989f936
3 changed files with 7 additions and 5 deletions

View File

@ -9,7 +9,7 @@
#include <string> #include <string>
#include <vector> #include <vector>
#include <univalue.h> // For util::SettingsValue = UniValue class UniValue;
namespace util { namespace util {

View File

@ -226,10 +226,11 @@ static bool CheckValid(const std::string& key, const util::SettingsValue& val, u
return true; return true;
} }
ArgsManager::ArgsManager() // Define default constructor and destructor that are not inline, so code instantiating this class doesn't need to
{ // #include class definitions for all members.
// nothing to do // For example, m_settings has an internal dependency on univalue.
} ArgsManager::ArgsManager() {}
ArgsManager::~ArgsManager() {}
const std::set<std::string> ArgsManager::GetUnsuitableSectionOnlyArgs() const const std::set<std::string> ArgsManager::GetUnsuitableSectionOnlyArgs() const
{ {

View File

@ -192,6 +192,7 @@ protected:
public: public:
ArgsManager(); ArgsManager();
~ArgsManager();
/** /**
* Select the network in use * Select the network in use