mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-05-31 16:24:48 +02:00
ci: Update Clang in "tidy" job
This change switches to the latest IWYU 0.23, which is compatible with Clang 19. Fixed new "modernize-use-starts-ends-with" warnings. The new "bugprone-use-after-move" warning in `result_tests.cpp` is a false positive caused by a bug in Boost.Test versions < 1.87. This has been addressed by introducing a local variable. See upstream references: - Issue: https://github.com/boostorg/test/issues/343 - Fix: https://github.com/boostorg/test/pull/348 Co-authored-by: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
This commit is contained in:
@@ -1013,7 +1013,7 @@ static DBErrors LoadAddressBookRecords(CWallet* pwallet, DatabaseBatch& batch) E
|
||||
// "1" or "p" for present (which was written prior to
|
||||
// f5ba424cd44619d9b9be88b8593d69a7ba96db26).
|
||||
pwallet->LoadAddressPreviouslySpent(dest);
|
||||
} else if (strKey.compare(0, 2, "rr") == 0) {
|
||||
} else if (strKey.starts_with("rr")) {
|
||||
// Load "rr##" keys where ## is a decimal number, and strValue
|
||||
// is a serialized RecentRequestEntry object.
|
||||
pwallet->LoadAddressReceiveRequest(dest, strKey.substr(2), strValue);
|
||||
|
||||
Reference in New Issue
Block a user