mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-11-12 15:09:59 +01:00
init: Initialize globals with kernel::Context's life
...instead of explicitly calling init::{Set,Unset}Globals.
Cool thing about this is that in both the testing and bitcoin-chainstate
codepaths, we no longer need to explicitly unset globals. The
kernel::Context goes out of scope and the globals are unset
"automatically".
Also construct kernel::Context outside of AppInitSanityChecks()
This commit is contained in:
@@ -188,11 +188,14 @@ static bool AppInit(NodeContext& node, int argc, char* argv[])
|
||||
// InitError will have been called with detailed error, which ends up on console
|
||||
return false;
|
||||
}
|
||||
|
||||
node.kernel = std::make_unique<kernel::Context>();
|
||||
if (!AppInitSanityChecks())
|
||||
{
|
||||
// InitError will have been called with detailed error, which ends up on console
|
||||
return false;
|
||||
}
|
||||
|
||||
if (args.GetBoolArg("-daemon", DEFAULT_DAEMON) || args.GetBoolArg("-daemonwait", DEFAULT_DAEMONWAIT)) {
|
||||
#if HAVE_DECL_FORK
|
||||
tfm::format(std::cout, PACKAGE_NAME " starting\n");
|
||||
|
||||
Reference in New Issue
Block a user