highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-11-10 14:08:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

guix: Skip attesting to dist-archive

Browse Source 
We already attest to the relevant dist-archive in inputs.SHA256SUMS,
which is recorded at build-time.

We use a SKIPATTEST.TAG file to indicate output directories which do not
require attestation (much like the CACHEDIR.TAG specification).
Generally, it's better to have build scripts declare properties of
directories instead of introducing name-based special cases in attest
scripts since build scripts have a more detailed context of what is
going on.
This commit is contained in:
Carl Dong
2021-05-03 13:12:15 -04:00
parent d522d8006b
commit feda2c8e31
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/guix/guix-attest
View File

@@ -146,6 +146,10 @@ echo ""
# MAIN LOGIC: Loop through each output for VERSION and attest to output in # MAIN LOGIC: Loop through each output for VERSION and attest to output in
# GUIX_SIGS_REPO as SIGNER, if attestation does not exist # GUIX_SIGS_REPO as SIGNER, if attestation does not exist
for outdir in "${OUTDIRS[@]}"; do for outdir in "${OUTDIRS[@]}"; do
if [ -e "${outdir}/SKIPATTEST.TAG" ]; then
echo "${outname}: SKIPPING: Output directory marked with SKIPATTEST.TAG file"
continue
fi
outname="$(out_name "$outdir")" outname="$(out_name "$outdir")"
outsigdir="$(out_sig_dir "$outdir")" outsigdir="$(out_sig_dir "$outdir")"
if [ -e "$outsigdir" ]; then if [ -e "$outsigdir" ]; then

1
contrib/guix/libexec/build.sh
View File

@@ -228,6 +228,7 @@ GIT_ARCHIVE="${DIST_ARCHIVE_BASE}/${DISTNAME}.tar.gz"
# Create the source tarball if not already there # Create the source tarball if not already there
if [ ! -e "$GIT_ARCHIVE" ]; then if [ ! -e "$GIT_ARCHIVE" ]; then
mkdir -p "$(dirname "$GIT_ARCHIVE")" mkdir -p "$(dirname "$GIT_ARCHIVE")"
touch "${DIST_ARCHIVE_BASE}"/SKIPATTEST.TAG
git archive --prefix="${DISTNAME}/" --output="$GIT_ARCHIVE" HEAD git archive --prefix="${DISTNAME}/" --output="$GIT_ARCHIVE" HEAD
fi fi