082779d606
test: Add explicit onion bind to p2p_permissions
...
When the bind option is replaced in the bitcoin.conf, bitcoind will
attempd to bind to the default tor listening port. If another bitcoind
is running that is already bound to that port, the bind will fail which,
since #22729 , causes the test to fail.
This failure can be avoided by explicitly binding the tor port when the
bind is removed.
2024-09-10 16:32:08 -04:00
902dd14382
Merge bitcoin/bitcoin#30493 : policy: enable full-rbf by default
...
590456e3f1
policy: enable full-rbf by default (Peter Todd)
195e98ea8e
doc: add release notes for full-rbf (Peter Todd)
Pull request description:
This pull request enables full rbf (mempool policy) by default. #28132 was closed recently with this [comment](https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-2225369634 ).
---
Rationale:
- Full RBF config option was added in July 2022: https://github.com/bitcoin/bitcoin/pull/25353
- It is used regularly: https://mempool.space/rbf#fullrbf
- Most mining pools are using it: https://github.com/bitcoin/bitcoin/pull/28132#issuecomment-2059120917
ACKs for top commit:
petertodd:
ACK 590456e3f1
instagibbs:
reACK 590456e3f1
glozow:
reACK 590456e3f1
achow101:
ACK 590456e3f1
ariard:
tested ACK 590456e3
murchandamus:
reACK 590456e3f1
Tree-SHA512: 83fceef9961021687e6ff979041f89be0c616f7a49cc28a5d7edf7d8ad064fcb9c0e2af0c31f4f89867a9f6dff4e40ef8ad4dbd624e7d6a4e00ac1f1c1f66c7a
2024-08-05 16:10:46 -04:00
590456e3f1
policy: enable full-rbf by default
...
Enable full rbf (mempool policy) by default and update tests accordingly.
2024-08-02 20:22:20 +00:00
a90ab4aec9
scripted-diff: Rename lazily initialized bloom filters
...
-BEGIN VERIFY SCRIPT-
sed -i 's/m_recent_confirmed_transactions/m_lazy_recent_confirmed_transactions/g' $(git grep -l 'm_recent_confirmed_transactions')
sed -i 's/m_recent_rejects_reconsiderable/m_lazy_recent_rejects_reconsiderable/g' $(git grep -l 'm_recent_rejects_reconsiderable')
sed -i 's/m_recent_rejects/m_lazy_recent_rejects/g' $(git grep -l 'm_recent_rejects')
-END VERIFY SCRIPT-
2024-07-31 13:23:46 +01:00
a0473442d1
scripted-diff: Add __file__
argument to BitcoinTestFramework.init()
...
-BEGIN VERIFY SCRIPT-
sed -i -e 's/\s*().main\s*()/(__file__).main()/' $(git ls-files test/functional/*.py)
sed -i -e 's/def __init__(self)/def __init__(self, test_file)/' test/functional/test_framework/test_framework.py
-END VERIFY SCRIPT-
2024-07-16 22:06:47 +01:00
e6b8f19de9
test: add coverage for whitelisting manual connections
2024-02-28 10:05:56 -03:00
a33dde1e41
[log] include wtxid in tx {relay,validation,orphanage} logging
2023-08-29 16:41:22 +01:00
b530d9605d
test: refactor: introduce replace_in_config
helper
2023-01-28 23:49:55 +01:00
0377d6bb42
test: add rescan_utxos
in MiniWallet's initialization
...
this simplifies usage when MiniWallet is used with a pre-mined chain.
2023-01-16 19:01:09 +02:00
8cbd926a2c
test: refactor: simplify p2p_permissions.py by using MiniWallet
...
Also, use the pre-mined chain of the test framework rather than mining
100 blocks manually on each run.
2023-01-15 01:11:15 +01:00
306ccd4927
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
Commits of previous years:
- 2021: f47dda2c58
- 2020: fa0074e2d8
- 2019: aaaaad6ac9
2022-12-24 23:49:50 +00:00
61d9149e78
rpc: Default rbf enabled
2022-07-15 11:46:34 -04:00
ceec6808d3
test: -whitebind
and -bind
with -listen=0
should throw an error
2022-06-22 15:22:25 -03:00
fac23c2114
scripted-diff: Bump copyright headers
...
The previous diff touched most files in ./test/, so bump the headers to
avoid having to touch them again for a bump later.
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./test/
-END VERIFY SCRIPT-
2021-11-10 11:10:24 +01:00
fa974f1f14
scripted-diff: Remove redundant sync_all and sync_blocks
...
The sync calls are redundant after a call to generate, because generate
already syncs itself.
-BEGIN VERIFY SCRIPT-
perl -0777 -pi -e 's/(generate[^\n]*\)[^\n]*)(\n|\s)+self.sync_(all|blocks)\([^\)]*\)\n/\1\n/g' $(git grep -l generate ./test)
-END VERIFY SCRIPT-
2021-11-10 11:10:15 +01:00
fa0b916971
scripted-diff: Use generate* from TestFramework
...
-BEGIN VERIFY SCRIPT-
sed --regexp-extended -i \
's/((self\.)?(nodes\[[^]]+\]|[a-z_]*(wallet|node)[0-9a-z_]*))\.(generate(|toaddress|block|todescriptor)(\(|, ))/self.\5\1, /g' \
$(git grep -l generate ./test | grep -v 'test_framework/' | grep -v 'feature_rbf')
-END VERIFY SCRIPT-
2021-09-02 10:34:35 +02:00
37dcd12d53
scripted-diff: Rename recentRejects
...
-BEGIN VERIFY SCRIPT-
ren() { sed -i "s:\<$1\>:$2:g" $(git grep -l "\<$1\>" ./src ./test); }
ren recentRejects m_recent_rejects
-END VERIFY SCRIPT-
2021-07-20 13:14:32 +01:00
2ce7b47958
test: introduce tx_from_hex
helper for tx deserialization
...
`FromHex` is mostly used for transactions, so we introduce a
shortcut `tx_from_hex` for `FromHex(CTransaction, hex_str)`.
2021-06-21 14:28:05 +02:00
b1a936d4ae
[rpc] Remove deprecated "whitelisted" field from getpeerinfo
2020-12-26 13:30:54 -08:00
d419fdedbe
[net processing] Don't add AlreadyHave txs to recentRejects
...
Now, we only add a transaction to our recentRejects filter if we didn't
already have it, meaning that it is added at most once, as intended.
2020-10-27 06:07:41 -04:00
4b16c61461
scripted-diff: test: Replace uses of (dis)?connect_nodes global
...
-BEGIN VERIFY SCRIPT-
# max-depth=0 excludes test/functional/test_framework/...
FILES=$(git grep -l --max-depth 0 "connect_nodes" test/functional)
# Replace (dis)?connect_nodes(self.nodes[a], b) with self.(dis)?connect_nodes(a, b)
sed -i 's/\b\(dis\)\?connect_nodes(self\.nodes\[\(.*\)\]/self.\1connect_nodes(\2/g' $FILES
# Remove imports in the middle of a line
sed -i 's/\(dis\)\?connect_nodes, //g' $FILES
sed -i 's/, \(dis\)\?connect_nodes//g' $FILES
# Remove imports on a line by themselves
sed -i '/^\s*\(dis\)\?connect_nodes,\?$/d' $FILES
sed -i '/^from test_framework\.util import connect_nodes$/d' $FILES
-END VERIFY SCRIPT-
Co-authored-by: Elliott Jin <elliott.jin@gmail.com >
2020-10-20 00:42:00 -07:00
d681a28219
RPC: getpeerinfo: Deprecate "whitelisted" field (replaced by "permissions")
2020-10-14 14:16:42 +00:00
1343c86c7c
test: Update wait_until usage in tests not to use the one from utils
...
Replace "wait_until()" usage from utils, with the ones from BitcoinTestFramework and P2PInterface.
closes #19080
2020-08-26 18:01:59 +02:00
d5800da519
[test] Remove final references to mininode
2020-08-25 10:04:25 +01:00
85165d4332
scripted-diff: Rename mininode to p2p
...
-BEGIN VERIFY SCRIPT-
sed -i 's/\.mininode/\.p2p/g' $(git grep -l "mininode")
git mv test/functional/test_framework/mininode.py test/functional/test_framework/p2p.py
-END VERIFY SCRIPT-
2020-08-21 15:52:20 +01:00
cf1569e074
Add addr permission flag enabling non-cached addr sharing
2020-07-30 14:38:50 +03:00
fab5586122
doc: Use precise permission flags where possible
2020-07-10 15:37:42 +02:00
fa0540cd46
net: Extract download permission from noban
2020-07-09 12:48:05 +02:00
fac6ef4fb2
test: Add test for no net permission
2020-06-21 11:35:46 -04:00
fa488f131f
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2020-04-16 13:33:09 -04:00
facb71576c
net: Remove forcerelay of rejected txs
2020-02-11 07:44:12 -08:00
aaaae4d0eb
test: Add p2p test for forcerelay permission
2020-01-23 09:01:37 -05:00
fa6b57bcaa
test: Fix whitespace in p2p_permissions.py
2020-01-23 09:00:20 -05:00
aaaaad6ac9
scripted-diff: Bump copyright of files changed in 2019
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2019-12-30 10:42:20 +13:00
3b05f0f70f
Reformat p2p_permissions.py
2019-08-17 00:43:37 +09:00
ce7eac3cb0
[Fix] The default whitelistrelay should be true
2019-08-17 00:43:22 +09:00
c5b404e8f1
Add functional tests for flexible whitebind/list
2019-08-11 11:33:29 +09:00