11 Commits

Author	SHA1	Message	Date
Pieter Wuille	3ddafceb9a	txgraph: initialize Ref in AddTransaction (preparation) ... Instead of returning a TxGraph::Ref from TxGraph::AddTransaction(), pass in a TxGraph::Ref& which is updated to refer to the new transaction in that graph. This cleans up the usage somewhat, avoiding the need for dummy Refs in CTxMemPoolEntry constructor calls, but the motivation is that a future commit will allow a callback to passed to MakeTxGraph to define a fallback order on the transaction objects. This does not work when a Ref is created separately from the CTxMemPoolEntry it ends up living in, as passing the newly-created Ref to the callback would be UB before it's emplaced in its final CTxMemPoolEntry.	2026-02-09 15:55:55 -05:00
MarcoFalke	fa51a28a94	scripted-diff: Remove priority_level from BENCHMARK macro ... -BEGIN VERIFY SCRIPT- sed --in-place --regexp-extended 's/BENCHMARK\(([^,]+), benchmark::PriorityLevel::(HIGH|LOW)\)/BENCHMARK(\1)/g' $( git grep -l PriorityLevel ) sed --in-place 's/#define BENCHMARK(n, priority_level)/#define BENCHMARK(n)/g' ./src/bench/bench.h -END VERIFY SCRIPT-	2026-01-13 08:33:37 +01:00
MarcoFalke	fa5f297748	scripted-diff: [doc] Unify stale copyright headers ... -BEGIN VERIFY SCRIPT- sed --in-place --regexp-extended \ 's;( 20[0-2][0-9])(-20[0-2][0-9])? The Bitcoin Core developers;\1-present The Bitcoin Core developers;g' \ $( git grep -l 'The Bitcoin Core developers' -- ':(exclude)COPYING' ':(exclude)src/ipc/libmultiprocess' ':(exclude)src/minisketch' ) -END VERIFY SCRIPT-	2025-12-16 22:21:15 +01:00
Suhas Daftuar	a3c31dfd71	scripted-diff: rename AddToMempool -> TryAddToMempool ... -BEGIN VERIFY SCRIPT- find src/test -type f -exec sed -i 's/AddToMempool/TryAddToMempool/g' {} + find src/bench -type f -exec sed -i 's/AddToMempool/TryAddToMempool/g' {} + -END VERIFY SCRIPT-	2025-11-30 10:57:48 -05:00
Suhas Daftuar	29a94d5b2f	Make CTxMemPoolEntry derive from TxGraph::Ref	2025-11-10 15:46:11 -05:00
marcofleon	a3baead7cb	validation: use wtxid instead of txid in CheckEphemeralSpends	2025-03-11 16:00:46 +00:00
glozow	f7144b24be	Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups ... 466e4df3fb assert_mempool_contents: assert not duplicates expected (Greg Sanders) ea5db2f269 functional: only generate required blocks for test (Greg Sanders) d033acb608 fuzz: package_eval: let fuzzer run out input in main tx creation loop (Greg Sanders) ba35a570c5 CheckEphemeralSpends: return boolean, and set child state and txid outparams (Greg Sanders) cf0cee1617 func: add note about lack of 1P1C propagation in tree submitpackage (Greg Sanders) 8424290304 unit test: ephemeral_tests is using a dust relay rate, not minrelay (Greg Sanders) d9cfa5fc4e CheckEphemeralSpends: no need to iterate inputs if no parent dust (Greg Sanders) 87b26e3dc0 func: rename test_free_relay to test_no_minrelay_fee (Greg Sanders) e5709a4a41 func: slight elaboration on submitpackage restriction (Greg Sanders) 08e969bd10 RPC: only enforce dust rules on priority when standardness active (Greg Sanders) ca050d12e7 unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX (Greg Sanders) 7c3490169c fuzz: package_eval: move last_tx inside txn ctor (Greg Sanders) 445eaed182 fuzz: use optional status instead of should_rbf_eph_spend (Greg Sanders) 4dfdf615b9 fuzz: remove unused TransactionsDelta validation interface (Greg Sanders) 09ce926e4a func: cleanup reorg test comment (Greg Sanders) 768a0c1889 func: cleanup test_dustrelay comments (Greg Sanders) bedca1cb66 fuzz: Directly place transactions in vector (Greg Sanders) c041ad6ecc fuzz: explain package eval coin tracking better (Greg Sanders) bc0d98ea61 fuzz: remove dangling reference to GetEntry (Greg Sanders) 15b6cbf07f unit test: make dust index less magical (Greg Sanders) 5fbcfd12b8 unit test: assert txid returned on CheckEphemeralSpends failures (Greg Sanders) ef94d84b4e bench: remove unnecessary CMTxn constructors (Greg Sanders) c5c10fd317 ephemeral policy doxygen cleanup (Greg Sanders) dd9044b8d4 ephemeral policy: IWYU (Greg Sanders) c6859ce2de Move+rename GetDustIndexes -> GetDust (Greg Sanders) 62016b3230 Use std::ranges for ephemeral policy checks (Greg Sanders) 3ed930a1f4 Have HasDust and PreCheckValidEphemeralTx take CTransaction (Greg Sanders) 04a614bf9a Rename CheckValidEphemeralTx to PreCheckEphemeralTx (Greg Sanders) cbf1a47d60 CheckEphemeralSpends: only compute txid of tx when needed (Greg Sanders) Pull request description: Follow-up to https://github.com/bitcoin/bitcoin/pull/30239 Here are the parent PR's comments that should be addressed by this PR: https://github.com/bitcoin/bitcoin/pull/30239/files#r1834529646 https://github.com/bitcoin/bitcoin/pull/30239/files#r1831247308 https://github.com/bitcoin/bitcoin/pull/30239/files#r1832622481 https://github.com/bitcoin/bitcoin/pull/30239/files#r1831195216 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834639096 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834624976 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834619709 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834610434 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834504436 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834500036 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832985488 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830929809 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832376920 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832755799 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832492686 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832980576 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832784278 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1837989979 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830996993 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830997947 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830012890 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830037288 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830977092 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832622481 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834726168 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832453654 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848488226 ACKs for top commit: naumenkogs: ACK 466e4df3fb hodlinator: ACK 466e4df3fb theStack: lgtm ACK 466e4df3fb glozow: utACK 466e4df3fb Tree-SHA512: 89106f695755c238b84e0996b89446c0733e10a94c867f656d516d26697d2efe38dfc332188b8589a0a26a3d2bd2c88c6ab70c108e187ce5bfcb91bbf3fb0391	2024-11-25 13:47:44 -05:00
Greg Sanders	ba35a570c5	CheckEphemeralSpends: return boolean, and set child state and txid outparams	2024-11-20 13:49:41 -05:00
Greg Sanders	ef94d84b4e	bench: remove unnecessary CMTxn constructors	2024-11-20 12:49:03 -05:00
Suhas Daftuar	7fb62f7db6	Apply mempool changeset transactions directly into the mempool ... Rather than individually calling addUnchecked for each transaction added in a changeset (after removing all the to-be-removed transactions), instead we can take advantage of boost::multi_index's splicing features to extract and insert entries directly from the staging multi_index into mapTx. This has the immediate advantage of saving allocation overhead for mempool entries which have already been allocated once. This also means that the memory locations of mempool entries will not change when transactions go from staging to the main mempool. Additionally, eliminate addUnchecked and require all new transactions to enter the mempool via a CTxMemPoolChangeSet.	2024-11-13 13:26:56 -05:00
Greg Sanders	5c2e291060	bench: Add basic CheckEphemeralSpends benchmark	2024-11-12 09:41:24 -05:00