Aurèle Oulès
081b0e53e3
refactor: Make const refs vars where applicable
...
This avoids initializing variables with the copy-constructor of a
non-trivially copyable type.
2022-07-27 13:27:57 +02:00
fanquake
4ddd746bf9
refactor: remove unnecessary string initializations
2022-07-26 10:16:42 +01:00
avirgovi
2a22f034ca
parsing external signer master fingerprint string as bytes instead of caring for lower/upper case in ExternalSigner::SignTransaction
2022-05-07 11:09:52 +02:00
Sebastian Falbesoner
d047ed729f
external_signer: improve fingerprint matching logic (stop on first match)
2021-08-24 11:30:09 +02:00
Sjors Provoost
d672404466
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
Sjors Provoost
4455145e26
refactor: reduce #ifdef ENABLE_EXTERNAL_SIGNER usage
...
In particular this make the node interface independent on whether external signer support is compiled.
2021-06-16 10:48:58 +02:00
fanquake
c8f469c6d5
external_signer: remove ExternalSignerException
...
It's not clear why this need it's own exception class, as opposed to just
throwing std::runtime_error().
2021-04-13 20:09:34 +08:00
fanquake
9e0b199b97
external_signer: use const where appropriate
2021-04-13 20:09:34 +08:00
fanquake
06a0673351
external_signer: remove ignore_errors from Enumerate()
...
This is undocumented and unused.
2021-04-13 20:09:33 +08:00
fanquake
f4652bf125
refactor: add missing includes to external signer code
2021-04-13 20:09:33 +08:00
fanquake
54569cc6d6
refactor: move all signer code inside ENABLE_EXTERNAL_SIGNER #ifdefs
2021-04-13 20:09:33 +08:00
Sjors Provoost
b54b2e7b1a
Move external signer out of wallet module
...
This commit moves the ExternalSigner class and RPC methods out of the wallet module.
The enumeratesigners RPC can be used without a wallet since #21417 .
With additional modifications external signers could be used without a wallet in general, e.g. via signrawtransaction.
The signerdisplayaddress RPC is ranamed to walletdisplayaddress because it requires wallet context.
A future displayaddress RPC call without wallet context could take a descriptor argument.
This commit fixes a rpc_help.py failure when configured with --disable-wallet.
2021-04-08 17:56:00 +02:00
