16 Commits

Author	SHA1	Message	Date
Sebastian Falbesoner	32d665c265	test: fix "tx-size-small" errors after default address change ... Addresses #17043, affects RBF and BIP68 functional tests. The "tx-size-small" policy rule rejects transactions with a non-witness size of smaller than 82 bytes (see src/validation.cpp:MemPoolAccept::PreChecks(...)), which corresponds to a transaction with 1 segwit input and 1 P2WPKH output. Through the default address change, the created test transactions have segwit inputs now and sending to short scriptPubKeys might violate this rule. By bumping the dummy scriptPubKey size to 22 bytes (= the size of a P2WPKH scriptPubKey), on all occurences the problem is solved. The dummy scriptPubKey has the format: 21 <21-byte-long string of 'a' or 1s> former commit messages, now squashed: test: rbf, bip68: use constant DUMMY_P2WPKH_SCRIPT for bumped scriptPubKey test: rbf, bip68: use constant DUMMY_P2WPKH_SCRIPT for dummy scriptPubKeys (b'a' * 35) test: rbf, bip68: comment DUMMY_P2WPKH_SCRIPT constant, put into common (new) module	2019-10-14 15:03:11 +02:00
Gregory Sanders	f50785ab56	Change default address type to bech32	2019-09-26 16:23:32 -04:00
MarcoFalke	fa89badf88	test: Require standard txs in regtest	2019-06-21 16:45:16 -04:00
Matt Corallo	8053e5cdad	Remove -mempoolreplacement to prevent needless block prop slowness. ... At this point there is no reasonable excuse to disable opt-in RBF, and, unlike when this option was added, there are now significant issues created when disabling it (in the form of compact block reconstruction failures). Further, it breaks a lot of modern wallet behavior.	2019-06-08 09:32:33 -04:00
Karl-Johan Alm	6c0a6f73e3	wallet/rpc: add maxfeerate parameter to sendrawtransaction	2019-03-14 08:48:46 +09:00
MarcoFalke	faa7cdf764	scripted-diff: Update copyright in ./test ... -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./test/ -END VERIFY SCRIPT-	2019-03-02 10:58:35 -05:00
MarcoFalke	fa0e65b772	scripted-diff: test: Remove brackets after assert ... -BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/assert ?\((.+)\)(( )*)?(#.*)?$/assert \1\3\3\4/g' $(git grep -l --extended-regexp 'assert ?\(' test) -END VERIFY SCRIPT-	2019-03-02 10:51:35 -05:00
MarcoFalke	fa6bf21f5e	scripted-diff: test: Use py3.5 bytes::hex() method ... -BEGIN VERIFY SCRIPT- sed -i -e "s/def bytes_to_hex_str/def b_2_x/g" $(git grep -l bytes_to_hex_str) export RE_B_0="[^()]*" # match no bracket export RE_B_1="${RE_B_0}\(${RE_B_0}\)${RE_B_0}" # match exactly one () export RE_B_2="${RE_B_0}\(${RE_B_1}\)${RE_B_0}" # match wrapped (()) export RE_M="(b2x|bytes_to_hex_str)\(((${RE_B_0}|${RE_B_1}|${RE_B_2})*)\)" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l -E '(b2x|bytes_to_hex_str)') sed -i --regexp-extended -e "/ +bytes_to_hex_str( as b2x)?,/d" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/ +bytes_to_hex_str( as b2x)?,//g" $(git grep -l bytes_to_hex_str) sed -i --regexp-extended -e "s/, bytes_to_hex_str( as b2x)?//g" $(git grep -l bytes_to_hex_str) export RE_M="(binascii\.)?hexlify\(((${RE_B_0}|${RE_B_1}|${RE_B_2})*)\).decode\(${RE_B_0}\)" sed -i --regexp-extended -e "s/${RE_M}/\2.hex()/g" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "/from binascii import hexlify$/d" $(git grep -l hexlify -- ':(exclude)share') sed -i --regexp-extended -e "s/(from binascii import) .*hexlify/\1 unhexlify/g" $(git grep -l hexlify -- ':(exclude)share') sed -i -e 's/ignore-names "/ignore-names "b_2_x,/g' ./test/lint/lint-python-dead-code.sh -END VERIFY SCRIPT-	2019-03-02 10:40:12 -05:00
MarcoFalke	fac9539836	qa: Run all tests even if wallet is not compiled	2018-09-10 17:53:21 -04:00
Wladimir J. van der Laan	6516b36731	Merge #12676: Show "bip125-replaceable" flag, when retrieving mempool entries ... 870bd4c73d Update functional RBF test to check replaceable flag (dexX7) 820d31f95f Add "bip125-replaceable" flag to mempool RPCs (dexX7) Pull request description: This pull request adds a flag "bip125-replaceable" to the mempool RPCs getrawmempool, getmempoolentry, getmempoolancestors and getmempooldescendants, which indicates whether an unconfirmed transaction might be replaced. Initially the flag was added to the raw transaction RPCs, but thanks to @conscott, it was moved to the mempool RPCs, which actually have access to the mempool. ~~This pull request adds a flag "bip125-replaceable" to the RPCs "getrawtransaction" and "decoderawtransaction", which indicates, whether a transaction signals BIP 125 replaceability.~~ There was some discussion in #7817, whether showing replaceability in the UI could lead to the false assumption that transactions that don't signal BIP 125 are truely non-replaceable, but given that this PR tackles the raw transaction interface, which is a rather low level tool, I believe having this extra piece of information isn't bad. Tree-SHA512: 1f5511957af2c20a9a6c79d80a335c3be37a2402dbf829c40cceaa01a24868eab81a9c1cdb0b3d77198fa3bb82799e3540a5c0ce7f35bbac80d73f7133ff7cbc	2018-08-26 00:04:05 +02:00
practicalswift	68400d8b96	tests: Use explicit imports	2018-08-13 14:13:39 +02:00
DrahtBot	eb7daf4d60	Update copyright headers to 2018	2018-07-27 07:15:02 -04:00
dexX7	870bd4c73d	Update functional RBF test to check replaceable flag	2018-05-22 08:23:02 +02:00
MarcoFalke	364bae5f7a	qa: Pad scriptPubKeys to get minimum sized txs	2018-05-05 04:59:55 +08:00
Andrew Chow	eefff65a4b	scripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests ... -BEGIN VERIFY SCRIPT- sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/*.py sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/test_framework/*.py -END VERIFY SCRIPT-	2018-02-17 11:42:01 -05:00
Anthony Towns	ca6523d0c8	[tests] Rename feature_* functional tests.	2018-01-25 09:44:29 +10:00