f26dab7 Adapt ZMQ/rest serialization to take rpcserialversion arg (instagibbs)
21ccb9f Add option to return non-segwit serialization via rpc (Gregory Sanders)
a710a43 Improvement of documentation of command line parameter 'whitelist' (wodry)
58eab24 [qa] rpc-tests: Apply random offset to portseed (MarcoFalke)
ecd7db5 [qa] test_framework: Exit when tmpdir exists (MarcoFalke)
387ec9d Add script tests for FindAndDelete in pre-segwit and segwit scripts (Johnson Lau)
87fbced Change all instance of 'GMT epoch' to 'Unix epoch' (matthias)
b1e978c instance of 'mem pool' to 'mempool' (S. Matthew English)
ff55a2d Update gitian signing key of jl2012 (Johnson Lau)
28d0f22 Fix calculation of number of bound sockets to use (Matt Corallo)
396c405 Include select.h when WIN32 is not defined (Ivo van der Sangen)
eebc699 bench: Fix subtle counting issue when rescaling iteration count (Wladimir J. van der Laan)
0c09d9f Send tip change notification from invalidateblock (Russell Yanofsky)
6f7841c qt: Avoid OpenSSL certstore-related memory leak (Wladimir J. van der Laan)
e5ad693 qt: Avoid shutdownwindow-related memory leak (Wladimir J. van der Laan)
e4bea4f qt: Avoid splash-screen related memory leak (Wladimir J. van der Laan)
c12f4e9 qt: Prevent thread/memory leak on exiting RPCConsole (Wladimir J. van der Laan)
dc46b10 qt: Plug many memory leaks (Wladimir J. van der Laan)
ff423cc [Qt] Clean up and fix coincontrol tree widget handling (Wladimir J. van der Laan)
6d70a73 [Qt] fix coincontrol sort issue (Jonas Schnelli)
3fffbf7 Doxygen: Set PROJECT_NAME = "Bitcoin Core" (MarcoFalke)
f82c81b fix getnettotals RPC description about timemillis. (Masahiko Hyuga)
6fe3981 net: don't send feefilter messages before the version handshake is complete (Cory Fields)
5f3a12c qt: Use correct conversion function for boost::path datadir (Wladimir J. van der Laan)
08d1c90 Missed one "return false" in recent refactoring in #9067 (UdjinM6)
f27596a Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers (UdjinM6)
f85ee01 Fix exit codes: - `--help`, `--version` etc should exit with `0` i.e. no error ("not enough args" case should still trigger an error) - error reading config file should exit with `1` (UdjinM6)
5bcb05d [rpc] ParseHash: Fail when length is not 64 (MarcoFalke)
973ca1e Fix doxygen comment: the transaction is returned in txOut (Pavel Janík)
6f86b53 [Qt] make warnings label selectable (Jonas Schnelli)
106da69 Sync bitcoin-tx with tx version policy (BtcDrak)
12428b4 add software-properties-common (Steven)
40169dc Set minimum required Boost to 1.47.0 (fanquake)
c134d92 [build-aux] Boost_Base serial 27 (fanquake)
4a974b2 Simple Update to File 'bitcoin-qt.desktop' (matthias)
975ab12 Update INSTALL landing redirection notice for build instructions. (randy-waterhouse)
3a3bcbf Use RelevantServices instead of node_network in AttemptToEvict. (Gregory Maxwell)
ca1fd75 Make orphan parent fetching ask for witnesses. (Gregory Maxwell)
b96a8f7 [qa] Test getblocktemplate default_witness_commitment (Suhas Daftuar)
99477c7 Always add default_witness_commitment with GBT client support (Pieter Wuille)
da5a16b Always drop the least preferred HB peer when adding a new one. (Gregory Maxwell)
094848b log block size and weight correctly. (jnewbery)
d1b4da9 build: fix qt5.7 build under macOS (Cory Fields)
This avoids a corner case (mostly visible on testnet) where bogus
headers can keep nodes in IsInitialBlockDownload.
Github-Pull: #9053
Rebased-From: e141beb6a9
GetTotalBlocksEstimate is no longer used and it was the only thing
the checkpoint tests were testing.
Since checkpoints are on their way out it makes more sense to remove
the test file than to cook up a new pointless test.
Github-Pull: #9053
Rebased-From: 2082b5574c
This introduces a 'minimum chain work' chainparam which is intended
to be the known amount of work in the chain for the network at the
time of software release. If you don't have this much work, you're
not yet caught up.
This is used instead of the count of blocks test from checkpoints.
This criteria is trivial to keep updated as there is no element of
subjectivity, trust, or position dependence to it. It is also a more
reliable metric of sync status than a block count.
Github-Pull: #9053
Rebased-From: fd46136dfa
Make sure that the count is a zero modulo the new mask before
scaling, otherwise the next time until a measure triggers
will take only 1/2 as long as accounted for. This caused
the 'min time' to be potentially off by as much as 100%.
Github-Pull: #9200
Rebased-From: e0a9cb25b0
This change is needed to prevent sync_blocks timeouts in the mempool_reorg
test after the sync_blocks update in the upcoming commit
"[qa] Change sync_blocks to pick smarter maxheight".
This change was initially suggested by Suhas Daftuar <sdaftuar@chaincode.com>
in https://github.com/bitcoin/bitcoin/pull/8680#r78209060
Github-Pull: #9196
Rebased-From: 67c6326abd
Store a reference to the shutdown window on BitcoinApplication,
so that it will be deleted when exiting the main loop.
Github-Pull: #9190
Rebased-From: 5204598f8d
Make splash screen queue its own deletion when it receives the finished
command, instead of relying on WA_DeleteOnClose which doesn't work under
these circumstances.
Github-Pull: #9190
Rebased-From: e4f126a7ba
Make ownership of the QThread object clear, so that the RPCConsole
can wait for the executor thread to quit before shutdown is called. This
increases overall thread safety, and prevents some objects from leaking
on exit.
Github-Pull: #9190
Rebased-From: 693384eedb
None of these are very serious, and are leaks in objects that are
created at most one time.
In most cases this means properly using the QObject parent hierarchy,
except for BanTablePriv/PeerTablePriv which are not QObject,
so use a std::unique_ptr instead.
Github-Pull: #9190
Rebased-From: 47db075377
- Do sorting for date, amount and confirmations column as longlong, not
unsigned longlong.
- Use `UserRole` to store our own data. This makes it treated as
ancillary data prevents it from being displayed.
- Get rid of `getMappedColumn` `strPad` - these are no longer necessary.
- Get rid of hidden `_INT64` columns.
- Start enumeration from 0 (otherwise values are undefined).
Github-Pull: #9185
Rebased-From: 4231032bfc
- `--help`, `--version` etc should exit with `0` i.e. no error ("not enough args" case should still trigger an error)
- error reading config file should exit with `1`
Slightly refactor AppInitRPC/AppInitRawTx to return standard exit codes (EXIT_FAILURE/EXIT_SUCCESS) or CONTINUE_EXECUTION (-1)
Github-Pull: #9067
Rebased-From: bd0de1386e
Use of node_network here is really meant to be a proxy of "likely to
send us blocks in the future". RelevantServices is the right criteria
now.
Github-Pull: #9052
Rebased-From: d32036a47d
In 0.13 orphan transactions began being treated as implicit
INVs for their parents. But the resulting getdata were
not getting the witness flag.
This fixes issue #9182 reported by chjj and roasbeef on IRC.
Github-Pull: #9188
Rebased-From: 5b0150a060
When a BIP152 HB-mode peer is in the least preferred position and
disconnects, they will not be by ForNode on the next loop. They
will continue to sit in that position and prevent deactivating
HB mode for peers that are still connected.
There is no reason for them to stay in the list if already gone,
so drop the first element unconditionally if there are too many.
Fixes issue #9163.
Github-Pull: #9199
Rebased-From: ca8549d2bd
e846166 Modify getblocktxn handler not to drop requests for old blocks (Russell Yanofsky)
2cad5db Align constant names for maximum compact block / blocktxn depth (Pieter Wuille)
3d23a0e Add cmpctblock to debug help list (instagibbs)
76ba1c9 More agressively filter compact block requests (Matt Corallo)
36e3b95 Dont remove a "preferred" cmpctblock peer if they provide a block (Matt Corallo)
286e548 [qa] Fix stale data bug in test_compactblocks_not_at_tip (Russell Yanofsky)
2ba5d78 [qa] Fix bug in compactblocks v2 merge (Russell Yanofsky)
eca9b46 [qa] Wait for specific block announcement in p2p-compactblocks (Russell Yanofsky)
dccdc3a test: Fix use-after-free in scheduler tests (Wladimir J. van der Laan)
da4926b [qa] Add more helpful RPC timeout message (Russell Yanofsky)
1d4c884 [qa] Increase wallet-dump RPC timeout (Russell Yanofsky)
3107280 [qa] add assert_raises_message to check specific error message (mrbandrews)
When generating a new service key, explicitly request a RSA1024 one.
The bitcoin P2P protocol has no support for the longer hidden service names
that will come with ed25519 keys, until it does, we depend on the old
hidden service type so make this explicit.
See #9214.
Rebased-From: 7d3b627395
Github-Pull: #9234
The current getblocktxn implementation drops and ignores requests for old
blocks, which causes occasional sync_block timeouts during the
p2p-compactblocks.py test as reported in
https://github.com/bitcoin/bitcoin/issues/8842.
The p2p-compactblocks.py test setup creates many new blocks in a short
period of time, which can lead to getblocktxn requests for blocks below the
hardcoded depth limit of 10 blocks. This commit changes the getblocktxn
handler not to ignore these requests, so the peer nodes in the test setup
will reliably be able to sync.
The protocol change is documented in BIP-152 update "Allow block responses
to getblocktxn requests" at https://github.com/bitcoin/bips/pull/469.
The protocol change is not expected to affect nodes running outside the test
environment, because there shouldn't normally be lots of new blocks being
rapidly added that need to be synced.
Github-Pull: #9058
Rebased-From: dac53b58b5
Github-Pull: #9160
Rebased-From: ec34648766
Make a copy of the boost time-point to wait for, otherwise the head of
the queue may be deleted by another thread while this one is waiting,
while the boost function still has a reference to it.
Although this problem is in non-test code, this is not an actual problem
outside of the tests because we use the thread scheduler with only one
service thread, so there will never be threads fighting at the head of
the queue.
The old boost fallback escapes this problem because it passes a scalar
value to wait_until instead of a const object reference.
Found by running the tests in LLVM-4.0-master asan.
Github-Pull: #9186
Rebased-From: 12519bf62b
e8ef50b Bump the protocol version to distinguish new banning behavior. (Suhas Daftuar)
015865e Fix compact block handling to not ban if block is invalid (Suhas Daftuar)
8290506 [qa] Test that invalid compactblocks don't result in ban (Suhas Daftuar)
This allows future software that would relay compact blocks before
full validation to announce only to peers that will not ban if the
block turns out to be invalid.
