5 Commits

Author	SHA1	Message	Date
Jeffrey Czyz	6edebacb21	Refactor FormatStateMessage for clarity ... All cases of CValidationState were condensed into one strprintf call. This is no longer suitable as more cases are added (e.g., IsValid).	2020-01-03 11:38:44 -08:00
Jeffrey Czyz	72f3227c83	Format CValidationState properly in all cases ... FormatStateMessage does not properly handle the case where CValidationState::IsValid() returns true. Use "Valid" for the state in this case.	2020-01-03 11:37:26 -08:00
John Newbery	a27a2957ed	[validation] Add CValidationState subclasses ... Split CValidationState into TxValidationState and BlockValidationState to store validation results for transactions and blocks respectively.	2019-10-29 15:46:45 -04:00
John Newbery	0053e16714	[logging] Don't log REJECT code when transaction is rejected ... Remove the BIP61 REJECT code from error messages and logs when a transaction is rejected. BIP61 support was removed from Bitcoin Core in fa25f43ac5. The REJECT codes will be removed from the codebase entirely in the following commit.	2019-10-10 11:19:42 -04:00
John Newbery	91a25d1e71	[build] Add several util units ... Adds the following util units and adds them to libbitcoin_util: - `util/url.cpp` takes `urlDecode` from `httpserver.cpp` - `util/error.cpp` takes `TransactionErrorString` from `node/transaction.cpp` and `AmountHighWarn` and `AmountErrMsg` from `ui_interface.cpp` - `util/fees.cpp` takes `StringForFeeReason` and `FeeModeFromString` from `policy/fees.cpp` - `util/rbf.cpp` takes `SignalsOptInRBF` from `policy/rbf.cpp` - 'util/validation.cpp` takes `FormatStateMessage` and `strMessageMagic` from 'validation.cpp`	2019-04-09 17:53:08 -04:00