Commit Graph

27 Commits

Author SHA1 Message Date
864772c4f7 lint: mypy 0.942 2022-04-07 12:50:54 +01:00
38031adee8 lint: flake8 4.0.1 2022-04-07 12:50:10 +01:00
eaf712c801 lint: codespell 2.1.0 2022-04-07 12:49:51 +01:00
f47dda2c58 scripted-diff: Bump copyright headers
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-

Commits of previous years:
* 2020: fa0074e2d8
* 2019: aaaaad6ac9
2021-12-30 19:36:57 +02:00
5202bd1dc0 test: Bump shellcheck version to 0.8.0 2021-11-30 21:15:40 +02:00
fe0ff569ea test: Enable SC2046 shellcheck rule 2021-11-13 18:05:26 +02:00
22e652662b lint mypy 0.910 2021-10-16 09:14:36 +08:00
6ae9c2ef23 lint: install pyzmq (22.3.0) into linter environment
mypy stubs were introduced in 21.0.1
2021-10-16 09:14:36 +08:00
fa050bbc0a test: Update test README and lint script 2021-09-02 10:26:35 +02:00
08f3dbb1b0 test: Bump shellcheck version 2021-04-22 12:14:05 +03:00
3f8776a139 Re-add dead code detection 2021-02-13 09:57:50 +01:00
a0022f1cfb test: bump codespell linter version to 2.0.0 2021-01-02 12:21:03 +01:00
fa0074e2d8 scripted-diff: Bump copyright headers
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2020-12-31 09:45:41 +01:00
faeb40bee3 ci: Install missing lint packages
Also merge script into ci/lint_run_all.sh because env vars weren't
exported properly
2020-12-18 07:40:57 +01:00
739d39022d ci: Move linter task to cirrus 2020-12-15 10:13:55 -08:00
faca73000f ci: Install fixed version of clang-format for linters 2020-06-27 11:49:44 -04:00
39d526bde4 test: Bump linter versions
Updates Python linters, spellchecking, and ShellCheck versions. The PR links are updated for
the dependency versions in test/README.md. ShellCheck SC2230 removed to align with with new
behaviour in v0.7.1.

Fixes #19346.
2020-06-22 20:15:53 +02:00
bd7e530f01 This PR adds initial support for type hints checking in python scripts.
Support for type hints was introduced in Python 3.5. Type hints make it easier to read and review code in my opinion. Also an IDE may discover a potential bug sooner. Yet, as PEP 484 says: "It should also be emphasized that Python will remain a dynamically typed language, and the authors have no desire to ever make type hints mandatory, even by convention."

Mypy is used in lint-python.sh to do the type checking. The package is standard so there is little chance that it will be abandoned. Mypy checks that type hints in source code are correct when they are not, it fails with an error.

Useful resources:

* https://docs.python.org/3.5/library/typing.html
* https://www.python.org/dev/peps/pep-0484/
2020-06-02 08:03:02 +02:00
14aded46df script: Lint Gitian descriptors with ShellCheck 2019-11-06 15:10:11 +02:00
4444704ca9 ci: Cleanup macOS runs 2019-10-17 10:47:02 -04:00
cd82f75a43 lint: Install grep and git via brew on mac for --perl-regexp
Particularly `--with-pcre2` is needed to run `git grep --perl-regexp` in
`test/link/check-doc.py`
2019-10-09 15:50:42 +01:00
eafa747ca5 lint: Fix shellcheck SC2155
Declare and assign separately to avoid masking return values.

https://github.com/koalaman/shellcheck/wiki/SC2155
2019-10-09 15:50:42 +01:00
615ff4e7db lint: Run the linters against Mac OS on Travis
This helps ensure ongoing compatibility with macOS-distributed version
of GNU bash.
2019-10-09 15:49:51 +01:00
f4beb4996d test: Remove python dead code linter
Primarily I'd like to remove this because it is very imprecise, due to
Python's dynamic nature, giving it a large list of false positives that
need to be listed as exceptions. See for example #16906.

It's also a frequent source of complaints. I'm doubtful of the
usefulness of checking for dead code in a linter in the first place.
Having some dead code in the test framework for a while is not a
disaster.
2019-09-25 11:16:09 +02:00
fac35b21e2 test: lint: Add DisabledOpcodeTemplates to whitelist
Also, bump vulture version to include the whitelist for threading module
2019-09-18 11:38:37 -04:00
0ef0e51fe4 lint: Bump flake8 to 3.7.8 2019-09-03 14:41:43 -04:00
fafe78f6ae ci: Rename .travis/ to ./ci/ 2019-08-15 11:11:45 -04:00