Commit Graph

7619 Commits

Author SHA1 Message Date
MarcoFalke
58d4fa7da3 [net] Remove assert(nMaxInbound > 0)
nMaxInbound might very well be 0 or -1, if the user prefers to keep
a small number of maxconnections.

Note: nMaxInbound of -1 means that the user set maxconnections
to 8 or less, but we still want to keep an additional slot for
the feeler connection.

Github-Pull: #9008
Rebased-From: fa1c3c2eb0
2016-10-25 19:29:23 +02:00
Wladimir J. van der Laan
0dbc48a5bd nMaxOutbound is MAX_OUTBOUND_CONNECTIONS on 0.13
Github-Pull: #8949
2016-10-19 11:50:15 +02:00
Wladimir J. van der Laan
53e6196a90 qt: pre-rc2 translations update 2016-10-19 11:48:12 +02:00
Luke Dashjr
7c2bf4b175 RPC/Mining: getblocktemplate: Update and fix formatting of help
Github-Pull: #8951
Rebased-From: 59daa58d6a
2016-10-19 11:24:22 +02:00
Gregory Maxwell
91ae0b06b9 Make dnsseed's definition of acute need include relevant services.
We normally prefer to connect to peers offering the relevant services.

If we're not connected to enough peers with relevant services, we
 probably don't know about them and could use dnsseed's help.

Github-Pull: #8949
Rebased-From: 4630479135
2016-10-19 11:24:12 +02:00
Gregory Maxwell
33cd5539b2 Be more aggressive in connecting to peers with relevant services.
Only allow skipping relevant services until there are four outbound
 connections up.

This avoids quickly filling up with peers lacking the relevant
 services when addrman has few or none of them.

Github-Pull: #8949
Rebased-From: 9583477288
2016-10-19 11:23:53 +02:00
Matt Corallo
685e4c78f8 Remove bogus assert on number of oubound connections.
This value can be significantly higher if the users uses addnode

Github-Pull: #8944
Rebased-From: 1ab21cf344
2016-10-18 14:41:42 +02:00
Wladimir J. van der Laan
3f508edcfb rpc: Generate auth cookie in hex instead of base64
Base64 contains '/', and the '/' character in credentials is problematic
for AuthServiceProxy which represents the RPC endpoint as an URI with
user and password embedded.

Closes #8399.

Github-Pull: #8858
Rebased-From: 1c80386bce
2016-10-18 14:41:17 +02:00
Wladimir J. van der Laan
a5cef7b077 Bump version to 0.13.1 2016-10-18 00:15:59 +02:00
Christian Decker
5b4192bc4c My DNS seed supports filtering
Currently supports filtering by any combination of the 4 least
significant bits.

Github-Pull: #8940
Rebased-From: 2449e12681
2016-10-17 19:43:40 +02:00
Matt Corallo
3d770a88d3 Add x9 service bit support to dnsseed.bluematt.me
Github-Pull: #8940
Rebased-From: ffb4713920
2016-10-17 19:43:11 +02:00
Matt Corallo
9aa0c15972 Comment that most dnsseeds only support some service bits combos
Github-Pull: #8940
Rebased-From: 504c72ad34
2016-10-17 19:42:58 +02:00
Pieter Wuille
8b66659921 Define start and end time for segwit deployment
Github-Pull: #8937
Rebased-From: f9c23dea97
2016-10-17 16:52:31 +02:00
Wladimir J. van der Laan
cb8887e87d qt: periodic translation update 2016-10-17 16:16:20 +02:00
Johnson Lau
fef7b46841 test segwit uncompressed key fixes
Github-Pull: #8499
Rebased-From: 9260085377
2016-10-17 14:16:08 +02:00
Pieter Wuille
4ec21e8a64 Fix ismine and addwitnessaddress: no uncompressed keys in segwit
Github-Pull: #8499
Rebased-From: 248f3a76a8
2016-10-17 14:10:59 +02:00
Johnson Lau
821f3e6751 Require compressed keys in segwit as policy and disable signing with uncompressed keys for segwit scripts
Github-Pull: #8499
Rebased-From: 4c0c25a604
2016-10-17 14:10:58 +02:00
Johnson Lau
540413d995 Add standard limits for P2WSH with tests
Github-Pull: #8499
Rebased-From: 3ade2f64cf
2016-10-17 14:10:58 +02:00
jonnynewbs
bcf3806f4c Update bitcoin-tx to output witness data.
Github-Pull: #8817
Rebased-From: 4408558843
2016-10-13 20:35:33 +02:00
Matt Corallo
4bb9ce8a95 Use cmpctblock type 2 for segwit-enabled transfer
Contains version negotiation logic by Matt Corallo and bugfixes by
Suhas Daftuar.

Github-Pull: #8393
Rebased-From: 6aa28abf53
2016-10-13 20:35:33 +02:00
Pieter Wuille
fe1975a974 Use cmpctblock type 2 for segwit-enabled transfer
Contains version negotiation logic by Matt Corallo and bugfixes by
Suhas Daftuar.

Github-Pull: #8393
Rebased-From: 6aa28abf53
2016-10-13 20:15:17 +02:00
Johnson Lau
7a34a4614c Add NULLDUMMY verify flag in bitcoinconsensus.h
Github-Pull: #8848
Rebased-From: 2fa0063c26
2016-10-13 20:09:31 +02:00
Cory Fields
7ae6242960 net: fix a few cases where messages were sent rather than dropped upon disconnection
75ead758 turned these into crashes in the event of a handshake failure, most
notably when a peer does not offer the expected services.

There are likely other cases that these assertions will find as well.

Github-Pull: #8862
Rebased-From: 905bc68d05
2016-10-13 20:09:31 +02:00
Johnson Lau
3e80ab7f2a Add policy: null signature for failed CHECK(MULTI)SIG
Github-Pull: #8634
Rebased-From: e41bd449ab
2016-10-13 20:01:46 +02:00
Johnson Lau
0027672c80 Make non-minimal OP_IF/NOTIF argument non-standard for P2WSH
Github-Pull: #8526
Rebased-From: c72c5b1e3b
2016-10-13 20:01:45 +02:00
Wladimir J. van der Laan
633c4a1f36 qt: Periodic translations update
Added languages:

- `ne` - Niger
2016-10-13 12:34:15 +02:00
Wladimir J. van der Laan
7634d8eac4 qt: Translate all files, even if wallet disabled
This passes all QT cpp files to the lupdate executable which extracts
translations, no matter what conditional functionality is enabled.

Rebased-From: 8aed5f6c23
Github-Pull: #8911
2016-10-13 11:36:33 +02:00
Luke Dashjr
b987348435 Bugfix: Trivial: RPC: getblockchaininfo help: pruneheight is the lowest, not highest, block
Github-Pull: #8884
Rebased-From: a78e5428ac
2016-10-05 11:18:49 +02:00
jnewbery
eb18cc1272 bitcoin-util-test.py should fail if the output file is empty
Github-Pull: #8836
Rebased-From: da94697708
2016-10-03 10:56:41 +02:00
MarcoFalke
83ad563ade [rpc] throw JSONRPCError when utxo set can not be read
Github-Pull: #8832
Rebased-From: fa05cfdf25
2016-10-03 10:55:51 +02:00
Jonas Schnelli
62886598db [Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds
Github-Pull: #8765
Rebased-From: c6f5ca822f
2016-10-03 10:55:31 +02:00
jnewbery
2a8bca465d Add bitcoin-tx JSON tests
Github-Pull: #8829
Rebased-From: 54e5d7c1b8
2016-10-03 10:55:07 +02:00
Johnson Lau
9dfa0c8d90 Implement NULLDUMMY softfork
Github-Pull: #8636
Rebased-From: 482f852da6
2016-09-26 16:50:39 +02:00
Pieter Wuille
ff893aa557 Implement SipHash in Python
Github-Pull: #8418
Rebased-From: 9c8593d2b4
2016-09-26 16:46:56 +02:00
Suhas Daftuar
198494ce53 Allow changing BIP9 parameters on regtest
Github-Pull: #8418
Rebased-From: 56c87e9211
2016-09-26 16:46:19 +02:00
Jonas Schnelli
23feab1f38 Remove maxuploadtargets recommended minimum
Github-Pull: #8712
Rebased-From: 1b6bcdd3aa
2016-09-26 16:43:28 +02:00
Johnson Lau
a5ec248323 Remove createwitnessaddress
This RPC command is unsafe as it will return an address even if the script is invalid.

Github-Pull: #8699
Rebased-From: 86c3f8db0b
2016-09-26 16:43:10 +02:00
Pieter Wuille
1672225670 Do not store witness txn in rejection cache
Github-Pull: #8525
Rebased-From: 34521e4d7d
2016-09-26 16:42:12 +02:00
isle2983
702fd2ee21 [copyright] add MIT license headers to .sh scripts where missing
Years are set according to 'git log' history

Github-Pull: #8700
Rebased-From: 0766d1cac3
2016-09-21 02:43:47 +00:00
Pavel Janík
084cae9ca5 UndoReadFromDisk works on undo files (rev), not on block files.
Github-Pull: #8737
Rebased-From: b4fb512719
2016-09-21 02:43:47 +00:00
fanquake
d31ac725cf Specify Protobuf version 2 in paymentrequest.proto
Github-Pull: #8742
Rebased-From: c4084c2085
2016-09-21 02:43:47 +00:00
Wladimir J. van der Laan
42ea51a65f net: No longer send local address in addrMe
After #8594 the addrFrom sent by a node is not used anymore at all,
so don't bother sending it.

Also mitigates the privacy issue in (#8616). It doesn't completely solve
the issue as GetLocalAddress is also called in AdvertiseLocal, but at
least when advertising addresses it stands out less as *our* address.

Github-Pull: #8740
Rebased-From: d9c99c3058
2016-09-21 02:43:47 +00:00
Alexey Vesnin
ea51b0f5dd Berkeley DB v6 compatibility fix
Fixes building error looking like this:
CXX wallet/libbitcoin_wallet_a-db.o
wallet/db.cpp: In member function ‘void CDBEnv::EnvShutdown()’:
wallet/db.cpp:46:16: error: call of overloaded ‘DbEnv(int)’ is ambiguous
DbEnv(0).remove(strPath.c_str(), 0);
^
wallet/db.cpp:46:16: note: candidates are:
In file included from wallet/db.h:21:0,
from wallet/db.cpp:6:
/usr/include/db_cxx.h:916:2: note: DbEnv::DbEnv(const DbEnv&)
DbEnv(const DbEnv &);
^
/usr/include/db_cxx.h:518:2: note: DbEnv::DbEnv(DB_ENV)
DbEnv(DB_ENV *dbenv);
^
/usr/include/db_cxx.h:516:2: note: DbEnv::DbEnv(u_int32_t)
DbEnv(u_int32_t flags);
^
Makefile:5780: recipe for target 'wallet/libbitcoin_wallet_a-db.o' failed
make[2]: ** [wallet/libbitcoin_wallet_a-db.o] Error 1

Github-Pull: #8626
Rebased-From: 323a5fe06a
2016-09-21 02:43:47 +00:00
MarcoFalke
486650ae6a [doc] Fix typos in comments, doxygen: Fix comment syntax
Github-Pull: #8607
Rebased-From: fa27c0a2c4
2016-09-21 02:43:47 +00:00
Wladimir J. van der Laan
9556745dc2 init: Fix typo in help message for -whitelistforcerelay
Reported by pryds on Transifex in the Danish translation.

Github-Pull: #8607
Rebased-From: 67a55025a1
2016-09-21 02:43:47 +00:00
Jonas Schnelli
4f84082a74 Set jonasschnellis dns-seeder filter flag
Github-Pull: #8573
Rebased-From: 40a95cfd8f
2016-09-21 02:43:47 +00:00
Christian Barcenas
c493f43621 Trivial: Fix two VarInt examples in serialize.h
Github-Pull: #8560
Rebased-From: 7bd5ff4623
2016-09-21 02:43:47 +00:00
crowning-
cb07f19e90 CDB: fix debug output
It doesn't really help to clear a variable before printing it to the debug log.

Github-Pull: #8539
Rebased-From: fab2e26d20
2016-09-21 02:43:47 +00:00
Wladimir J. van der Laan
75d548475d Add copyright header to wallet_text_fixture.cpp
I created the file but forgot to add this header.

Github-Pull: #8558
Rebased-From: 653bb3d640
2016-09-21 02:43:47 +00:00
MarcoFalke
305d8ac90b Use __func__ to get function name for output printing
Github-Pull: #8548
Rebased-From: fa785d1211
2016-09-21 02:43:47 +00:00