Pieter Wuille
c21cbe61c6
Introduce FastRandomContext::randbool()
2017-03-29 00:40:17 -07:00
Pieter Wuille
4bd0e9b90a
Merge #10088 : Trivial: move several relay options into the relay help group
...
0fb2887
2017-03-29 00:31:34 -07:00
Pieter Wuille
7438ceac71
Merge #10086 : Trivial: move rpcserialversion into RPC option group
...
1403b1a
2017-03-29 00:28:51 -07:00
Thomas Snider
6d5dd60c88
No need to use OpenSSL malloc/free
2017-03-28 17:36:31 -07:00
Ryan Havar
53351321c4
ApproximateBestSubset should take inputs by reference, not value
2017-03-28 12:11:44 -06:00
Jonas Schnelli
4115af7ac7
Fix rebase issue where pwalletMain was used instead of pwallet
...
Ser./Deser. nInternalChainCounter as last element
2017-03-28 09:18:20 +02:00
Russell Yanofsky
e9a64615c8
Make qt wallet test compatible with qt4
...
Unlike Qt5, the Qt4 signals implementation doesn't allow a signal to be
directly connected to a c++ lambda expression. Work around this by defining a
Callback QObject with a virtual method that can forward calls to a closure.
The Qt4 error was reported by Patrick Strateman <patrick.strateman@gmail.com >
in https://github.com/bitcoin/bitcoin/pull/10039#issuecomment-289248763
2017-03-27 14:34:38 -04:00
Wladimir J. van der Laan
8d8f28dd52
refactor: Move RPCNotifyBlockChange out of rpc/server.h
2017-03-27 16:23:22 +02:00
Wladimir J. van der Laan
e6dcfeec05
refactor: Move GetDifficulty out of rpc/server.h
...
It has no business in `rpcserver.h`. Define it in the interface header
of the implementation unit `rpcblockchain` where it is defined.
Also modernize the signature to:
double GetDifficulty(const CBlockIndex* blockindex = nullptr);
(remove `extern`, replace `NULL` with `nullptr`)
2017-03-27 12:21:35 +02:00
Wladimir J. van der Laan
5114f81136
Merge #10057 : [init] Deduplicated sigaction() boilerplate
...
81a3857
2017-03-27 10:36:57 +02:00
Wladimir J. van der Laan
e6156a0aa3
Merge #10056 : [zmq] Call va_end() on va_start()ed args.
...
5ba61f0
2017-03-27 10:34:18 +02:00
Jonas Schnelli
0ddea4430d
Merge #10060 : [Qt] Ensure an item exists on the rpcconsole stack before adding
...
4df76e2
2017-03-27 09:55:17 +02:00
Jonas Schnelli
9382f0425e
Do not break backward compatibility during wallet encryption
2017-03-27 09:51:55 +02:00
Jameson Lopp
0fb288725b
Move several relay options into the Relay help group
2017-03-26 15:02:26 -04:00
Jameson Lopp
1403b1a689
move rpcserialversion into RPC option group
2017-03-26 10:25:17 -04:00
Jameson Lopp
d5690f1ab8
remove 'noconnect' option from documentation
2017-03-26 09:13:20 -04:00
MarcoFalke
fa55853219
rpc: Rename first named arg of createrawtransaction
2017-03-26 12:08:44 +02:00
Wladimir J. van der Laan
90dd9e6c4c
Merge #9946 : Fix build errors if spaces in path or parent directory
...
b1f584d
2017-03-25 12:15:06 +01:00
Wladimir J. van der Laan
5d7eb39aec
Merge #10067 : [trivial] Dead code removal
...
c59aedc
2017-03-25 09:10:03 +01:00
Andrew Chow
4df76e270c
Ensure an item exists on the rpcconsole stack before adding
...
Ensures that there is an item on the rpcconsole stack before adding something to the current stack so that a segmentation fault does not occur.
2017-03-24 21:41:34 -04:00
Matthew Zipkin
b1f584dbc1
fix build if spaces in src dir path
2017-03-24 18:22:34 -07:00
Thomas Snider
81a3857c4e
Deduplicated sigaction() boilerplate
2017-03-24 10:32:56 -07:00
Jonas Schnelli
1df08d1580
Add assertion for CanSupportFeature(FEATURE_HD_SPLIT)
2017-03-24 10:57:55 +01:00
Jonas Schnelli
cd468d07d5
Define CWallet::DeriveNewChildKey() as private
2017-03-24 10:57:31 +01:00
Jonas Schnelli
ed79e4f497
Optimize GetOldestKeyPoolTime(), return as soon as we have both oldest keys
2017-03-24 10:54:48 +01:00
Jonas Schnelli
771a304ffe
Make sure we set the wallets min version to FEATURE_HD_SPLIT at the very first point
2017-03-24 10:53:35 +01:00
Jonas Schnelli
003e197498
Remove FEATURE_HD_SPLIT bump TODO
2017-03-24 10:28:40 +01:00
Jonas Schnelli
d9638e5aa4
Overhaul the internal/external key derive switch
2017-03-24 10:28:40 +01:00
Jonas Schnelli
1090502c3e
Fix superfluous cast and code style nits in RPC wallet-hd.py test
2017-03-24 10:28:40 +01:00
Jonas Schnelli
58e148333e
CKeyPool avoid "catch (...)" in SerializationOp
2017-03-24 10:28:40 +01:00
Jonas Schnelli
e138876f0a
Only show keypoolsize_hd_internal if HD split is enabled
2017-03-24 10:28:40 +01:00
Jonas Schnelli
add38d9b83
GetOldestKeyPoolTime: if HD & HD Chain Split is enabled, response max(oldest-internal-key, oldest-external-key)
2017-03-24 10:28:39 +01:00
Jonas Schnelli
dd526c2a2d
Don't switch to HD-chain-split during wallet encryption of non HD-chain-split wallets
2017-03-24 10:28:39 +01:00
Jonas Schnelli
79df9df348
Switch to 100% for the HD internal keypool size
2017-03-24 10:28:39 +01:00
Jonas Schnelli
bcafca1077
Make sure we always generate one keypool key at minimum
2017-03-24 10:28:39 +01:00
Jonas Schnelli
d0a627a53a
Fix issue where CDataStream->nVersion was taken a CKeyPool record version
2017-03-24 10:28:39 +01:00
Jonas Schnelli
9af8f00a75
Make sure we hand out keypool keys if HD_SPLIT is not enabled
2017-03-24 10:28:38 +01:00
Jonas Schnelli
469a47b760
Make sure ReserveKeyFromKeyPool only hands out internal keys if HD_SPLIT is supported
2017-03-24 10:28:38 +01:00
Jonas Schnelli
05a9b493eb
Fix wrong keypool internal size in RPC getwalletinfo help
2017-03-24 10:28:38 +01:00
Jonas Schnelli
01de822c8d
Removed redundant IsLocked() check in NewKeyPool()
2017-03-24 10:28:38 +01:00
Jonas Schnelli
d59531ddfc
Immediately return setKeyPool's size if HD or HD_SPLIT is disabled or not supported
2017-03-24 10:28:37 +01:00
Jonas Schnelli
02592f4c5e
[Wallet] split the keypool in an internal and external part
2017-03-24 10:28:37 +01:00
Thomas Snider
c59aedc1b0
[trivial] Dead code removal
2017-03-23 15:08:54 -07:00
Eric Shaw Jr
9ab9e7d1b3
Add a button to open the config file in a text editor
2017-03-23 12:54:36 -04:00
Jonas Schnelli
3568b30ca3
Merge #9500 : [Qt][RPC] Autocomplete commands for 'help' command in debug console
...
6d8fe35
2017-03-23 08:27:16 +01:00
Jonas Schnelli
7b585cf70e
Merge #9558 : Clarify assumptions made about when BlockCheck is called
...
c4a6929
2017-03-23 08:18:43 +01:00
Jonas Schnelli
86f7d5b69b
Merge #10029 : Fix parameter naming inconsistencies between .h and .cpp files
...
97b8213
2017-03-23 08:16:27 +01:00
Karl-Johan Alm
5ba61f0034
[zmq] Call va_end() on va_start()ed args.
2017-03-22 12:56:44 -07:00
Jonas Schnelli
90586b6897
Merge #10045 : [trivial] Fix typos in comments
...
dbf30ff
2017-03-22 08:38:24 +01:00
practicalswift
dbf30ff10f
[trivial] Fix typos in comments
2017-03-21 19:49:08 +01:00
