85165d4332
scripted-diff: Rename mininode to p2p
...
-BEGIN VERIFY SCRIPT-
sed -i 's/\.mininode/\.p2p/g' $(git grep -l "mininode")
git mv test/functional/test_framework/mininode.py test/functional/test_framework/p2p.py
-END VERIFY SCRIPT-
2020-08-21 15:52:20 +01:00
dac7a111bd
refactor: test: use _ variable for unused loop counters
...
substitutes "for x in range(N):" by "for _ in range(N):"
indicates to the reader that a block is just repeated N times, and
that the loop counter is not used in the body
2020-08-06 18:39:33 +02:00
fa488f131f
scripted-diff: Bump copyright headers
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-
2020-04-16 13:33:09 -04:00
54be4e71d8
test: check specific reject reasons in feature_csv_activation.py
...
this also fixes a bug that was uncovered with this checks:
for the BIP112 version 1 tx tests, certain txs (bip112txs_vary_OP_CSV_v1) have
been sent twice due to a typo, leading also to a failure as expected but for the
wrong reason
2020-02-28 20:42:23 +01:00
5ffaf883b9
test: eliminiated magic numbers in feature_csv_activation.py
2020-02-28 09:04:59 +01:00
09f706ab8e
test: check for OP_CSV empty stack fail reject reason in feature_csv_activation.py
2020-02-28 09:04:59 +01:00
cbd345a75c
test: test OP_CSV empty stack fail in feature_csv_activation.py
...
With BIP112 activated, the operation OP_CHECKSEQUENCEVERIFY (former OP_NOP3)
leads to script interpreter termination with an error if one of the following
conditions is true:
-> stack is empty
-> top item on stack is negative (< 0)
-> top item on stack has disable flag unset and at least one of
four other conditions is true (contains the core CSV logic)
This commits adds the missing empty stack failure test to the functional test
by prepending a valid scriptSig with just OP_CHECKSEQUENCEVERIFY. If BIP112 is
inactive, the operator just behaves as a NOP (for both tx versions 1 and 2) and
the transaction remains valid -- if it is active, the tx is invalid due to an
empty stack (for both tx versions 1 and 2, as well).
2020-02-28 09:04:18 +01:00
fa45d60646
test: Reduce unneeded whitelist permissions in tests
2020-02-26 00:00:29 +07:00
993e38a4e2
tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such
2019-12-06 14:40:28 +00:00
1c93b9b31c
[Consensus] Bury CSV deployment height
...
Hard code CSV deployment height to 419328 for mainnet.
2019-08-14 15:52:52 -04:00
fa4680ed09
scripted-diff: Rename sync_blocks to send_blocks to avoid name collisions and confusion
...
-BEGIN VERIFY SCRIPT-
FILE_LIST=$(git grep -l 'def sync_blocks' ./test/functional/*.py)
sed -i -e 's/def sync_blocks/def send_blocks/g' $FILE_LIST
sed -i -e 's/self.sync_blocks/self.send_blocks/g' $FILE_LIST
-END VERIFY SCRIPT-
2019-04-08 19:40:00 -04:00
faa7cdf764
scripted-diff: Update copyright in ./test
...
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./test/
-END VERIFY SCRIPT-
2019-03-02 10:58:35 -05:00
fa0e65b772
scripted-diff: test: Remove brackets after assert
...
-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/assert ?\((.+)\)(( )*)?(#.*)?$/assert \1\3\3\4/g' $(git grep -l --extended-regexp 'assert ?\(' test)
-END VERIFY SCRIPT-
2019-03-02 10:51:35 -05:00
288ddf4ff5
Merge #14180 : qa: Run all tests even if wallet is not compiled
...
fac9539836faa669cbcd
2018-09-13 13:06:07 +02:00
fac9539836
qa: Run all tests even if wallet is not compiled
2018-09-10 17:53:21 -04:00
fac3e22b18
qa: Read reject reasons from debug log, not p2p messages
2018-08-31 10:27:19 -04:00
cf9ed307e6
qa: blocktools enforce named args for amount
2018-08-09 13:25:36 -04:00
f66e1c793e
Merge #13669 : Tests: Cleanup create_transaction implementations
...
44bbceeef1736f941424157651855fhttps://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_cltv.py#L52-L60 ), [2](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_csv_activation.py#L88-L95 ) [3](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_dersig.py#L40-L48 ), [4](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_nulldummy.py#L100-L108 ), [5](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L529-L535 ), [6](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/blocktools.py#L120-L129 ), [7](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_block.py#L1218-L1220 )) implementations of a function called something similar to `create_transaction` in the functional tests, some of which are exact copies of each other.
This PR aims to clean this up into [three different cases implemented in blocktools.py](https://github.com/conscott/bitcoin/blob/create_tx_cleanup/test/functional/test_framework/blocktools.py#L121-L149 )
1. `create_tx_with_script`: Return transaction object spending generic tx output optionally specifying scriptSig and scriptPubKey
2. `create_transaction`: Return transaction object spending coinbase tx
2. `create_raw_transaction`: Return raw transaction (hex string) spending coinbase tx
I am not committed to any of these function names, so I'll gladly take suggestions on there.
Additionally there are some related cleanups to feature_block.py tests, specifically removing the [PreviousSpendableOutput](https://github.com/conscott/bitcoin/blob/master/test/functional/feature_block.py#L51-L54 ) object, which seems like an unnecessary layer given that every instance spends the 0 output.
Tree-SHA512: 63c6233b6f0942c81ba1ca67ea6770809b8c9409314c6d4cf8e5a3991cb9ee92b22bebe88c0dde45cd71e754eb351230c4c404b70ff118f5f43c034452ada65c
2018-08-09 12:09:37 -04:00
8ac7125d59
Merge #13916 : qa: wait_for_verack by default
...
fa5587fe71
2018-08-09 08:07:28 -04:00
736f941424
[Tests] Cleanup extra instances of create_transaction
2018-08-09 12:58:36 +02:00
fa5587fe71
qa: wait_for_verack by default
2018-08-08 17:22:35 -04:00
eb7daf4d60
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
fa87da2f17
qa: Avoid start/stop of the network thread mid-test
2018-06-25 14:06:41 -04:00
12982682a6
[tests] Change feature_csv_activation.py to use BitcoinTestFramework
2018-03-22 09:38:31 -04:00
db7ffb9d1b
[tests] Move utility functions in feature_csv_activation.py out of class.
2018-03-22 09:37:00 -04:00
0842edf9ee
[tests] Remove nested loops from feature_csv_activation.py
...
Makes the test a lot clearer.
2018-03-22 09:35:11 -04:00
2e511d5424
[tests] improve logging in feature_csv_activation.py
2018-03-18 18:45:25 -04:00
6f7f5bc002
[tests] fix flake8 nits in feature_csv_activation.py
2018-03-18 18:45:22 -04:00
eefff65a4b
scripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests
...
-BEGIN VERIFY SCRIPT-
sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/*.py
sed -i 's/\<signrawtransaction\>/signrawtransactionwithwallet/g' test/functional/test_framework/*.py
-END VERIFY SCRIPT-
2018-02-17 11:42:01 -05:00
ca6523d0c8
[tests] Rename feature_* functional tests.
2018-01-25 09:44:29 +10:00
