Commit Graph

13 Commits

Author SHA1 Message Date
Vasil Dimov
7df4508369 test: improve sock_tests/move_assignment
Use also a socket for the moved-to object and check which one is closed when.
2023-08-28 14:32:17 +02:00
Vasil Dimov
5086a99b84 net: remove Sock default constructor, it's not necessary 2023-08-25 14:42:07 +02:00
Vasil Dimov
7829272f78 net: remove now unnecessary Sock::Get()
`Sock::Get()` was used only in `sock.{cpp,h}`. Remove it and access
`Sock::m_socket` directly.

Unit tests that used `Get()` to test for equality still verify that the
behavior is correct by using the added `operator==()`.
2023-08-25 14:41:31 +02:00
TheCharlatan
7d3b35004b refactor: Move system from util to common library
Since the kernel library no longer depends on the system file, move it
to the common library instead in accordance to the diagram in
doc/design/libraries.md.
2023-05-20 12:08:13 +02:00
Hennadii Stepanov
306ccd4927 scripted-diff: Bump copyright headers
-BEGIN VERIFY SCRIPT-
./contrib/devtools/copyright_header.py update ./
-END VERIFY SCRIPT-

Commits of previous years:
- 2021: f47dda2c58
- 2020: fa0074e2d8
- 2019: aaaaad6ac9
2022-12-24 23:49:50 +00:00
fanquake
b89530483d util: move threadinterrupt into util 2022-11-01 10:14:49 +00:00
fanquake
cc7b2fdd70 refactor: move compat.h into compat/ 2022-07-20 10:34:46 +01:00
Vasil Dimov
a724c39606 net: rename Sock::Reset() to Sock::Close() and make it private
Outside of `Sock`, `Sock::Reset()` was used in just one place (in
`i2p.cpp`) which can use the assignment operator instead.

This simplifies the public `Sock` API by having one method less.
2022-06-22 09:19:43 +02:00
Vasil Dimov
175fb2670a net: remove now unused Sock::Release() 2022-06-20 15:01:28 +02:00
Vasil Dimov
e286cd0d7b net: flag relevant Sock methods with [[nodiscard]] 2021-04-13 17:26:20 +02:00
Vasil Dimov
7059e6d822 test: add a test to ensure RecvUntilTerminator() limit works 2021-03-16 11:00:57 +01:00
fanquake
9cc8e30125 test: fix sign comparison warning in socket tests
This fixes:
```bash
In file included from test/sock_tests.cpp:10:
In file included from /usr/local/include/boost/test/unit_test.hpp:18:
In file included from /usr/local/include/boost/test/test_tools.hpp:46:
/usr/local/include/boost/test/tools/old/impl.hpp:107:17: warning: comparison of integers of different signs: 'const long' and 'const unsigned long' [-Wsign-compare]
    return left == right;
           ~~~~ ^  ~~~~~
```

which was introduced in #20788.
2021-02-12 10:12:00 +08:00
Vasil Dimov
615ba0eb96 test: add Sock unit tests 2021-02-11 10:44:53 +01:00