highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-17 21:32:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Compare commits

...

5 Commits
baed5edeb6 ... 3cbc8cbc71

Author SHA1 Message Date
fanquake
3cbc8cbc71
Merge : rpc: Drop migratewallet experimental warning 
f1684bb88a878eb3f54e945db39ea69b14256eef rpc: mention that migratewallet can take a while (Andrew Chow)
9ecff997e164e70c5958116b20ed441404ccd6f3 rpc: Drop migratewallet experimental warning (Andrew Chow)

Pull request description:

  The migration process itself hasn't fundamentally changed since it was added, so I think it's reasonable to say that it is no longer experimental.

ACKs for top commit:
  maflcko:
    lgtm ACK f1684bb88a878eb3f54e945db39ea69b14256eef
  josibake:
    ACK f1684bb88a
  furszy:
    ACK f1684bb88a
  ryanofsky:
    Code review ACK f1684bb88a878eb3f54e945db39ea69b14256eef
  willcl-ark:
    ACK f1684bb88a878eb3f54e945db39ea69b14256eef

Tree-SHA512: 99b176cddbf3878c76bd4c80c030106200bf03139785e26dbae3341e1a675b623a13cd6dc7a0bb78344335bf859ae7548d97b2b58eb650c6e7b305d7cdc86e40
 2024-02-16 12:28:05 +00:00
fanquake
dfff8ee02e
Merge : doc: Update translation process guide 
3b0ec06d6228d965e9cf9121c5dd300da2a930ea doc: Update translation_process.md (pablomartin4btc)

Pull request description:

  Updating Transifex broken link and setup Transifex config file with a token.

ACKs for top commit:
  hebasto:
    ACK 3b0ec06d6228d965e9cf9121c5dd300da2a930ea.
  hernanmarino:
    ACK 3b0ec06d6228d965e9cf9121c5dd300da2a930ea

Tree-SHA512: fc8e537a7d244e2e5983763ff7bd017a796359b2baf2119809c2fa051f43ba8a7bcbf5aef0687bc86c8badf5abc4b67cf2e0252f9e2ee14cafb50612dd51f3f7
 2024-02-16 12:24:59 +00:00
pablomartin4btc
3b0ec06d62 doc: Update translation_process.md 
Updating Transifex broken link and remove Transifex config file
section as it has been outdated.
 2024-02-14 21:39:39 -03:00
Andrew Chow
f1684bb88a rpc: mention that migratewallet can take a while 2023-10-19 09:58:16 -04:00
Andrew Chow
9ecff997e1 rpc: Drop migratewallet experimental warning 2023-07-06 11:01:44 -04:00
2 changed files with 3 additions and 17 deletions

16
doc/translation_process.md

@ -44,21 +44,7 @@ Visit the [Transifex Signup](https://www.transifex.com/signup/) page to create a
You can find the Bitcoin translation project at [https://www.transifex.com/bitcoin/bitcoin/](https://www.transifex.com/bitcoin/bitcoin/).
### Installing the Transifex client command-line tool
The client is used to fetch updated translations. If you are having problems, or need more details, see [https://docs.transifex.com/client/installing-the-client](https://docs.transifex.com/client/installing-the-client)
`pip install transifex-client`
Setup your Transifex client config as follows. Please *ignore the token field*.
```ini
nano ~/.transifexrc
[https://www.transifex.com]
hostname = https://www.transifex.com
password = PASSWORD
token =
username = USERNAME
```
The client is used to fetch updated translations. Please check installation instructions and any other details at https://developers.transifex.com/docs/cli.
The Transifex Bitcoin project config file is included as part of the repo. It can be found at `.tx/config`, however you shouldn’t need to change anything.

4
src/wallet/rpc/wallet.cpp

@ -748,13 +748,13 @@ RPCHelpMan simulaterawtransaction()
static RPCHelpMan migratewallet()
{
return RPCHelpMan{"migratewallet",
"EXPERIMENTAL warning: This call may not work as expected and may be changed in future releases\n"
"\nMigrate the wallet to a descriptor wallet.\n"
"A new wallet backup will need to be made.\n"
"\nThe migration process will create a backup of the wallet before migrating. This backup\n"
"file will be named <wallet name>-<timestamp>.legacy.bak and can be found in the directory\n"
"for this wallet. In the event of an incorrect migration, the backup can be restored using restorewallet."
"\nEncrypted wallets must have the passphrase provided as an argument to this call.",
"\nEncrypted wallets must have the passphrase provided as an argument to this call.\n"
"\nThis RPC may take a long time to complete. Increasing the RPC client timeout is recommended.",
{
{"wallet_name", RPCArg::Type::STR, RPCArg::DefaultHint{"the wallet name from the RPC endpoint"}, "The name of the wallet to migrate. If provided both here and in the RPC endpoint, the two must be identical."},
{"passphrase", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The wallet passphrase"},