mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-07-01 03:01:09 +02:00
6e5b67a370
fa21631595test: Use self.log (MarcoFalke)fa346f7797test: Move error string into exception (MarcoFalke)fa1986181ftest: Remove useless catch-throw (MarcoFalke)fa2f1c55b7move-only util data to test/functional/data/util (MarcoFalke)faa18bf287test: Turn util/test_runner into functional test (MarcoFalke)fa955154c7test: Add missing skip_if_no_bitcoin_tx (MarcoFalke)fac9db6eb0test: Add missing tx util to Binaries (MarcoFalke)fa91835ec6test: Use lowercase env var as attribute name (MarcoFalke)fac49094cdtest: Remove duplicate ConfigParser (MarcoFalke) Pull request description: The `test/util/test_runner.py` has many issues: * The boilerplate for the test runner is duplicate or inconsistent with the other (functional) tests. For example, logging options, `ConfigParser` handling, `Binaries` handling ... * The cmake/ci behavior is brittle and can silently fail, as explained in https://github.com/bitcoin/bitcoin/issues/31476 * corecheck (and likely other places that manually run the tests) completely forget to run it * If the test is manually called, it runs single threaded, when it could just run in parallel with the other functional tests Fix all issues by removing the util test_runner and moving the test logic into a new functional test file. ACKs for top commit: janb84: re ACKfa21631595brunoerg: re-ACKfa21631595hebasto: re-ACKfa21631595, additional feedback has been addressed since my previous [review](https://github.com/bitcoin/bitcoin/pull/32697#pullrequestreview-2940350432). Tree-SHA512: 694e647887801f002843a74011035d5ed3dfed091d3f0ae18e812a16a4680e04e60e50de0a92af7e047e8ddd6ff5a7834c690f16fd42b74ebc1674bf9989406f