mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-11-30 15:58:24 +01:00
8e02b48059
fa5e706459ci: Skip broken Wine64 tests by default (MarcoFalke) Pull request description: I don't think the unit tests run in Wine after the Windows cross-compilation have ever shown a true positive since the MSVC task was added. However, they are a source of frequent false-positives. Thus, disable them by default for now. Anyone can still enable them by setting `RUN_UNIT_TESTS=true`. A follow-up could run them on real Windows, see https://github.com/bitcoin/bitcoin/pull/31176. Conceptually there are many other nightly tasks, which rarely find issues and are not run by default, like the valgrind or s390x tasks. So putting the Wine unit tests in the same bucket should be fine. ACKs for top commit: hebasto: ACKfa5e706459, to avoid false-positives. willcl-ark: ACKfa5e706459Tree-SHA512: 6bd54470e4d5ce18923c5d724aba0dbf475d053d7097d3f87e822a455cc537b6ce5f0dfcc8ccd0719c12c5d0c8fc7355a6c84185a6c9b5d484d98aee763d0c49