mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00

Files

Ava Chow 8405fdb06e Merge bitcoin/bitcoin#33169 : interfaces, chain, refactor: Remove unused getTipLocator and incaccurate getActiveChainLocator

2b00030af8 interfaces, chain, refactor: Remove inaccurate getActiveChainLocator (pablomartin4btc)
110a0f405c interfaces, chain, refactor: Remove unused getTipLocator (pablomartin4btc)

Pull request description:

  Remove `Chain::getTipLocator`, `Chain::GetLocator()`, and `Chain::getActiveChainLocator`:
  - `Chain::getTipLocator` is no longer used.
  - `Chain::GetLocator`, replaced its call by `GetLocator()`, which uses `LocatorEntries`, avoiding direct access to the chain itself (change suggested by l0rinc while reviewing this PR to maintain consistency with the overall refactoring).
  - `Chain::getActiveChainLocator`, whose name was misleading, has functionality redundant with Chain::findBlock.
    - Additionally, the comment for getActiveChainLocator became inaccurate following changes in commit ed470940cd (from PR #25717).

  This is a [follow-up](https://github.com/bitcoin/bitcoin/pull/29652#issuecomment-3151665095) to #29652.

ACKs for top commit:
  achow101:
    ACK 2b00030af8
  furszy:
    ACK 2b00030af8
  stickies-v:
    ACK 2b00030af8
  w0xlt:
    ACK 2b00030af8

Tree-SHA512: b12ba6a15feeaeec692d69204a6e155e3af43edfac25597dabf14cacca1e4a2152574816e58dc544f39043c5721f5e707acf544f4541d3b9c0f8c0c40069215e

2025-08-14 11:30:45 -07:00

chain.h

Merge bitcoin/bitcoin#33169 : interfaces, chain, refactor: Remove unused getTipLocator and incaccurate getActiveChainLocator

2025-08-14 11:30:45 -07:00

echo.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

handler.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

init.h

multiprocess: Add -ipcbind option to bitcoin-node

2024-09-06 09:08:10 -04:00

ipc.h

multiprocess: Add IPC connectAddress and listenAddress methods

2024-09-06 09:08:10 -04:00

mining.h

Add checkBlock to Mining interface

2025-06-14 14:32:45 +02:00

node.h

remove RPCTimerInterface and RPCRunLater

2025-07-03 06:26:23 -04:00

README.md

multiprocess: Add comments and documentation

2021-04-23 03:02:50 -05:00

types.h

refactor: rename BlockKey to BlockRef

2024-09-17 09:14:15 +02:00

wallet.h

refactor: Move transaction_identifier.h to primitives

2025-08-11 16:47:51 +01:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #19160.
Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.