mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 05:32:22 +02:00
08dfaa04f4
fa0fe212f5test: [refactor] Properly use BOOST_CHECK_EXCEPTION (MarcoFalke) Pull request description: The exception checking in unit tests is partly verbose, fragile, inconsistent and thus confusing. Fix all those issues by using `BOOST_CHECK_EXCEPTION` consistently: * The test code is less bloated and follows a standard pattern; Extra state and dead code like `exceptionThrown = false;` or `BOOST_CHECK(0)` can be removed. * The checks are more strict, because they use `HasReason{...}` or a similar predicate. ACKs for top commit: l0rinc: ACKfa0fe212f5janb84: ACKfa0fe212f5jonatack: Light ACKfa0fe212f5Tree-SHA512: f3a9abfe02988299f6d2604643feb630e078c2177287899d4fcc191802536d41d09e6365d81d0184bf3533583987969cb1b85ab3e112e7364fdb5b85a3405cb7