bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-09 14:41:42 +02:00

History

Merge bitcoin/bitcoin#29356 : test: make v2transport arg in addconnection mandatory and few cleanups

e7fd70f4b6b163f4ad5b25b4da7fa79899245235 [test] make v2transport arg in addconnection mandatory and few cleanups (stratospher)

Pull request description:

  - make `v2transport` argument in `addconnection` regression-testing only RPC mandatory. https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1470738750
  - previously it was an optional arg with default `false` value.
  - only place this RPC is used is in the [functional tests](11b436a66a/test/functional/test_framework/test_node.py (L742)) where we always pass the appropriate `v2transport` option to the RPC anyways. (and that too just for python dummy peer(`P2PInterface`) and bitcoind(`TestNode`) interactions)
  - rename `v2_handshake()` to `_on_data_v2_handshake()` https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1466958424
  - more compact return statement in `wait_for_reconnect()` https://github.com/bitcoin/bitcoin/pull/24748#discussion_r1466979708
  - assertion to check that empty version packets are received from `TestNode`.

ACKs for top commit:
  glozow:
    ACK e7fd70f4b6
  theStack:
    Code-review ACK e7fd70f4b6b163f4ad5b25b4da7fa79899245235
  mzumsande:
    Code Review ACK e7fd70f4b6b163f4ad5b25b4da7fa79899245235

Tree-SHA512: e66e29baccd91e1e4398b91f7d45c5fc7c2841d77d8a6178734586017bf2be63496721649da91848dec71da605ee31664352407d5bb896e624cc693767c61a1f

2024-02-06 11:02:36 +00:00

crypto

[test/crypto] Add FSChaCha20Poly1305 AEAD python implementation

2023-09-29 17:50:38 +05:30

__init__.py

…

address.py

…

authproxy.py

…

bdb.py

…