glozow ba7c67f609 Merge bitcoin/bitcoin#29879: fuzz: explicitly cap the vsize of RBFs for diagram checks ...

016ed248ba fuzz: explicitly cap the vsize of RBFs for diagram checks (Greg Sanders)

Pull request description:

  In master we are hitting a case where vsize transactions much larger than max standard size are causing an overflow in not-yet-exposed RBF diagram checking code: https://github.com/bitcoin/bitcoin/pull/29757#issuecomment-2049220195

  `ConsumeTxMemPoolEntry` is creating entries with tens of thousands of sigops cost, causing the resulting RBFs to be "overly large".

  To fix this I cause the fuzz test to stop adding transactions to the mempool when we reach a potential overflow of `int32_t`.

ACKs for top commit:
  glozow:
    ACK 016ed248ba
  marcofleon:
    ACK 016ed248ba. I ran libFuzzer on `package_rbf` on the current master branch until the overflow was encountered. Then I built the PR branch and ran the fuzzer using the crash input.

Tree-SHA512: b3ffc98d2c4598eb3010edd58b9370aab1441aafbb1044c83b2b90c17dfe9135b8de9dba475dd0108863c1ffedede443cd978e95231a41cf1f0715629197fa51

2024-04-22 12:33:06 +01:00

..

util

refactor, bench, fuzz: Drop unneeded UCharCast calls

2024-04-06 15:46:53 +01:00

addition_overflow.cpp

…

addrman.cpp

…

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

…

base_encode_decode.cpp

…

bech32.cpp

…

bip324.cpp

…

bitdeque.cpp

…

block_header.cpp

…

block.cpp

…

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

…

coins_view.cpp

…

coinscache_sim.cpp

…

connman.cpp

…

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

Add fuzz test for FeeFrac

2024-03-18 10:32:00 -04:00

feeratediagram.cpp

fuzz: fuzz diagram creation and comparison

2024-03-18 10:32:00 -04:00

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

Merge bitcoin/bitcoin#27375: net: support unix domain sockets for -proxy and -onion

2024-03-13 06:53:07 -04:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

…

headerssync.cpp

Rename CalculateHeadersWork to CalculateClaimedHeadersWork

2024-03-05 10:01:24 -05:00

hex.cpp

…

http_request.cpp

…

integer.cpp

crypto: replace CountBits with std::bit_width

2024-02-26 16:13:12 +00:00

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

…

load_external_block_file.cpp

…

locale.cpp

…

merkleblock.cpp

…

message.cpp

…

mini_miner.cpp

…

miniscript.cpp

…

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

Merge bitcoin/bitcoin#27114: p2p: Allow whitelisting manual connections

2024-03-12 12:59:02 -04:00

net.cpp

fuzz: add target for local addresses

2024-02-29 14:13:58 -03:00

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

p2p_transport_serialization.cpp

fuzz: actually test garbage >64b in p2p transport test

2024-03-17 11:35:01 -04:00

package_eval.cpp

fuzz: Add coverage for client_maxfeerate

2024-04-09 14:53:34 +02:00

parse_hd_keypath.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

partially_downloaded_block.cpp

refactor: Simplify extra_txn to be a vec of CTransactionRef instead of a vec of pair<Wtxid, CTransactionRef>

2024-04-06 19:17:20 +01:00

policy_estimator_io.cpp

…

policy_estimator.cpp

…

poolresource.cpp

…

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

refactor: De-globalize g_signals

2024-02-15 14:37:01 +01:00

process_messages.cpp

refactor: De-globalize g_signals

2024-02-15 14:37:01 +01:00

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

fuzz: explicitly cap the vsize of RBFs for diagram checks

2024-04-16 11:27:59 -04:00

rolling_bloom_filter.cpp

…

rpc.cpp

…

script_assets_test_minimizer.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

…

script_sign.cpp

…

script.cpp

…

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

…

strprintf.cpp

…

system.cpp

…

timedata.cpp

…

torcontrol.cpp

…

transaction.cpp

…

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

scripted-diff: Rename max_sane_feerate to client_maxfeerate

2024-03-25 11:48:18 -04:00

txorphan.cpp

…

txrequest.cpp

…

util.cpp

fuzz: restrict fopencookie usage to Linux & FreeBSD

2024-03-05 21:18:44 +00:00

util.h

…

utxo_snapshot.cpp

…

utxo_total_supply.cpp

…

validation_load_mempool.cpp

…

versionbits.cpp

…