fanquake 214f8f18b3 Merge bitcoin/bitcoin#27774: refactor: Add [[nodiscard]] where ignoring a Result return type is an error ...

fa5680b752 fix includes for touched header files (iwyu) (MarcoFalke)
dddde27f6f Add [[nodiscard]] where ignoring a Result return type is an error (MarcoFalke)

Pull request description:

  Only add it for those where it is an error to ignore. Also, fix the gcc compile warning https://github.com/bitcoin/bitcoin/pull/25977#issuecomment-1564350880. Also, fix iwyu for touched header files.

ACKs for top commit:
  TheCharlatan:
    ACK fa5680b752
  stickies-v:
    ACK fa5680b752

Tree-SHA512: c3509103bfeae246e2cf565bc561fcd68d8118515bac5431ba5304c3a63c8254b9c4f40e268b6f6d6b79405675c5a960db9b4eb3bdd14aedca333dc1c9e76415

2023-05-30 15:32:19 +01:00

..

rpc

refactor: Split util::AnyPtr into its own file

2023-05-20 12:03:33 +02:00

test

test: add coverage for wallet read write db deadlock

2023-05-15 12:29:38 -03:00

bdb.cpp

wallet: bugfix, GetNewCursor() misses to provide batch ptr to BerkeleyCursor

2023-05-15 12:23:15 -03:00

bdb.h

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

coinselection.h

refactor: Split util::insert into its own file

2023-05-20 12:03:31 +02:00

context.cpp

…

context.h

…

crypter.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

external_signer_scriptpubkeyman.h

…

feebumper.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

interfaces.cpp

…

load.cpp

…

load.h

…

receive.cpp

…

receive.h

…

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

wallet: skip block scan if block was created before wallet birthday

2023-05-25 10:45:38 -03:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#27759: Fix #includes in src/wallet

2023-05-29 16:33:14 +01:00

spend.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

spend.h

…

sqlite.cpp

…

sqlite.h

…

transaction.cpp

…

transaction.h

…

types.h

…

wallet.cpp

Merge bitcoin/bitcoin#27759: Fix #includes in src/wallet

2023-05-29 16:33:14 +01:00

wallet.h

Add [[nodiscard]] where ignoring a Result return type is an error

2023-05-29 13:12:45 +02:00

walletdb.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

walletdb.h

walletdb: Remove unused CreateMockWalletDatabase

2023-05-15 16:14:43 -04:00

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

Fix #includes in src/wallet

2023-05-25 15:52:08 +01:00