Andrew Chow 535424a10b Merge bitcoin/bitcoin#28903: refactor: Make CTxMemPoolEntry only explicitly copyable ...

705e3f1de0 refactor: Make CTxMemPoolEntry only explicitly copyable (TheCharlatan)

Pull request description:

  This has the goal of prohibiting users from accidentally creating runtime failures, e.g. by interacting with iterator_to with a copied entry. This was brought up here:  https://github.com/bitcoin/bitcoin/pull/28886#issuecomment-1814794954.

  CTxMemPoolEntry is already implicitly not move-constructable. So be explicit about this and use a std::list to collect the values in the policy_estimator fuzz test instead of a std::vector.

ACKs for top commit:
  maflcko:
    ACK 705e3f1de0 🌯
  achow101:
    ACK 705e3f1de0
  ajtowns:
    ACK 705e3f1de0
  ismaelsadeeq:
    ACK 705e3f1de0

Tree-SHA512: 62056905c679c919d00f9ae065ed66ac986e7e7062015aea542843d8deecda57104d7a68d002f7b20afa3164f8e9215d2d2d002c167224129540e3b1bd0712cc

2023-11-28 14:45:23 -05:00

..

bitcoinkernel.cpp

b-cs: Define G_TRANSLATION_FUN in bitcoinkernel.cpp

2022-04-26 16:30:53 -04:00

blockmanager_opts.h

refactor: Move stopafterblockimport handling out of blockstorage

2023-07-11 12:00:57 +02:00

chain.cpp

validation: add ChainstateRole

2023-09-30 06:38:47 -04:00

chain.h

validation: add ChainstateRole

2023-09-30 06:38:47 -04:00

chainparams.cpp

Change petertodd seeds to petertodd.net

2023-11-25 13:59:41 +00:00

chainparams.h

chainparams: add blockhash to AssumeutxoData

2023-09-30 06:38:47 -04:00

chainstatemanager_opts.h

kernel: Remove StartShutdown calls from validation code

2023-07-11 12:30:56 -04:00

checks.cpp

refactor: Replace std::optional<bilingual_str> with util::Result

2023-05-24 08:55:47 -04:00

checks.h

fix includes for touched header files (iwyu)

2023-05-29 13:26:31 +02:00

coinstats.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

coinstats.h

coinstats: Fix hash_serialized2 calculation

2023-10-20 22:53:05 +02:00

context.cpp

util: Add SignalInterrupt class and use in shutdown.cpp

2023-06-28 09:49:28 +02:00

context.h

util: Add SignalInterrupt class and use in shutdown.cpp

2023-06-28 09:49:28 +02:00

cs_main.cpp

kernel: add missing include

2023-02-22 15:46:21 +00:00

cs_main.h

refactor: add kernel/cs_main.*

2023-01-05 09:05:14 +00:00

disconnected_transactions.cpp

bugfix: correct DisconnectedBlockTransactions memory usage

2023-10-19 16:14:36 +01:00

disconnected_transactions.h

bugfix: correct DisconnectedBlockTransactions memory usage

2023-10-19 16:14:36 +01:00

mempool_entry.h

refactor: Make CTxMemPoolEntry only explicitly copyable

2023-11-17 23:02:02 +01:00

mempool_limits.h

refactor: mempool: add MemPoolLimits::NoLimits()

2022-10-05 13:07:11 +01:00

mempool_options.h

mempool: persist with XOR

2023-11-09 19:44:50 +01:00

mempool_persist.cpp

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

mempool_persist.h

Add importmempool RPC

2023-08-07 11:33:34 +02:00

mempool_removal_reason.cpp

move-only: Create src/kernel/mempool_removal_reason.h

2023-08-17 16:26:20 +02:00

mempool_removal_reason.h

move-only: Create src/kernel/mempool_removal_reason.h

2023-08-17 16:26:20 +02:00

messagestartchars.h

kernel: Move MessageStartChars to its own file

2023-09-12 22:51:38 +02:00

notifications_interface.h

kernel: Remove StartShutdown calls from validation code

2023-07-11 12:30:56 -04:00

validation_cache_sizes.h

validationcaches: Use size_t for sizes

2022-08-03 12:03:28 -04:00