fanquake f7c73b03d9 Merge #19569: Enable fetching of orphan parents from wtxid peers ...

10b7a6d532 refactor: make txmempool interface use GenTxid (Pieter Wuille)
5c124e1740 refactor: make FindTxForGetData use GenTxid (Pieter Wuille)
a2bfac8935 refactor: use GenTxid in tx request functions (Pieter Wuille)
e65d115b72 test: request parents of orphan from wtxid relay peer (Anthony Towns)
900d7f6c07 p2p: enable fetching of orphans from wtxid peers (Pieter Wuille)
9efd86a908 refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic (Pieter Wuille)
d362f19355 doc: list support for BIP 339 in doc/bips.md (Pieter Wuille)

Pull request description:

  This is based on https://github.com/bitcoin/bitcoin/pull/18044#discussion_r450687076.

  A new type `GenTxid` is added to protocol.h, which represents a tagged txid-or-wtxid. The tx request logic is updated to use these instead of uint256s, permitting per-announcement distinguishing of txid/wtxid (instead of assuming that everything we want to request from a wtxid peer is wtx). Then the restriction of orphan-parent requesting to non-wtxid peers is lifted.

  Also document BIP339 in doc/bips.md.

ACKs for top commit:
  jnewbery:
    Code review ACK 10b7a6d532
  jonatack:
    ACK 10b7a6d532
  ajtowns:
    ACK 10b7a6d532 -- code review. Using gtxid to replace the is_txid_or_wtxid flag for the mempool functions is nice.
  naumenkogs:
    utACK 10b7a6d

Tree-SHA512: d518d13ffd71f8d2b3c175dc905362a7259689e6022a97a0b4f14f1f9fdd87475cf5af70cb12338d1e5d31b52c12e4faaea436114056a2ae9669cb506240758b

2020-07-31 19:52:18 +08:00

..

bench

Merge #18011: Replace current benchmarking framework with nanobench

2020-07-30 15:34:17 +02:00

compat

…

config

…

consensus

Merge #18044: Use wtxid for transaction relay

2020-07-22 20:58:55 +02:00

crc32c

…

crypto

…

index

…

interfaces

Merge #15935: Add <datadir>/settings.json persistent settings storage

2020-07-23 18:39:42 +02:00

leveldb

…

logging

…

node

Add support for tx-relay via wtxid

2020-07-19 02:05:29 -04:00

policy

…

primitives

refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic

2020-07-30 13:44:54 -07:00

qt

Merge #19604: Pass mempool pointer to UnloadBlockIndex/GetCoinsCacheSizeState

2020-07-30 17:30:52 +02:00

rpc

Merge #19585: rpc: RPCResult Type of MempoolEntryDescription should be OBJ.

2020-07-31 07:52:40 +02:00

script

span: Add Span::empty() and use it in script/descriptor

2020-07-19 20:51:06 +02:00

secp256k1

…

support

…

test

Merge #19604: Pass mempool pointer to UnloadBlockIndex/GetCoinsCacheSizeState

2020-07-30 17:30:52 +02:00

univalue

…

util

Merge #15935: Add <datadir>/settings.json persistent settings storage

2020-07-23 18:39:42 +02:00

wallet

Merge #19561: refactor: Pass ArgsManager into functions that register args

2020-07-30 17:08:46 +02:00

zmq

…

.clang-format

…

addrdb.cpp

…

addrdb.h

…

addrman.cpp

…

addrman.h

…

amount.h

…

arith_uint256.cpp

…

arith_uint256.h

…

attributes.h

…

banman.cpp

…

banman.h

…

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

scripted-diff: Replace gArgs with local argsman

2020-07-29 16:39:00 +07:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

scripted-diff: Replace gArgs with local argsman

2020-07-29 16:39:00 +07:00

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

scripted-diff: Replace gArgs with local argsman

2020-07-29 16:39:00 +07:00

bitcoind-res.rc

…

bitcoind.cpp

Add <datadir>/settings.json persistent settings storage.

2020-07-11 05:41:12 -04:00

blockencodings.cpp

…

blockencodings.h

…

blockfilter.cpp

…

blockfilter.h

…

bloom.cpp

…

bloom.h

…

chain.cpp

…

chain.h

…

chainparams.cpp

refactor: use local argsmanager in CRegTestParams

2020-07-29 16:39:03 +07:00

chainparams.h

…

chainparamsbase.cpp

scripted-diff: Replace gArgs with local argsman

2020-07-29 16:39:00 +07:00

chainparamsbase.h

refactor: add unused ArgsManager to replace gArgs

2020-07-29 16:36:44 +07:00

chainparamsseeds.h

…

checkqueue.h

…

clientversion.cpp

…

clientversion.h

…

coins.cpp

…

coins.h

…

compat.h

…

compressor.cpp

…

compressor.h

…

core_io.h

…

core_memusage.h

…

core_read.cpp

…

core_write.cpp

Merge #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv

2020-07-16 21:38:09 +02:00

cuckoocache.h

…

dbwrapper.cpp

…

dbwrapper.h

…

dummywallet.cpp

scripted-diff: Replace gArgs with local argsman

2020-07-29 16:39:00 +07:00

flatfile.cpp

…

flatfile.h

…

fs.cpp

…

fs.h

…

hash.cpp

…

hash.h

…

httprpc.cpp

…

httprpc.h

…

httpserver.cpp

…

httpserver.h

…

indirectmap.h

…

init.cpp

Merge #19604: Pass mempool pointer to UnloadBlockIndex/GetCoinsCacheSizeState

2020-07-30 17:30:52 +02:00

init.h

…

key_io.cpp

…

key_io.h

…

key.cpp

…

key.h

…

limitedmap.h

…

logging.cpp

…

logging.h

…

Makefile.am

…

Makefile.bench.include

…

Makefile.crc32c.include

…

Makefile.leveldb.include

…

Makefile.qt_locale.include

…

Makefile.qt.include

…

Makefile.qttest.include

…

Makefile.test_fuzz.include

…

Makefile.test_util.include

…

Makefile.test.include

Merge #18011: Replace current benchmarking framework with nanobench

2020-07-30 15:34:17 +02:00

memusage.h

…

merkleblock.cpp

…

merkleblock.h

…

miner.cpp

…

miner.h

…

net_permissions.cpp

…

net_permissions.h

…

net_processing.cpp

refactor: make txmempool interface use GenTxid

2020-07-30 13:45:03 -07:00

net_processing.h

Merge #19472: [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect()

2020-07-24 17:20:58 +02:00

net_types.h

…

net.cpp

Merge #19473: net: Add -networkactive option

2020-07-23 18:32:59 +02:00

net.h

Merge #19473: net: Add -networkactive option

2020-07-23 18:32:59 +02:00

netaddress.cpp

net: save the network type explicitly in CNetAddr

2020-07-27 15:13:24 +02:00

netaddress.h

net: save the network type explicitly in CNetAddr

2020-07-27 15:13:24 +02:00

netbase.cpp

…

netbase.h

…

netmessagemaker.h

…

noui.cpp

…

noui.h

…

optional.h

…

outputtype.cpp

…

outputtype.h

…

pow.cpp

…

pow.h

…

prevector.h

…

protocol.cpp

refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic

2020-07-30 13:44:54 -07:00

protocol.h

refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic

2020-07-30 13:44:54 -07:00

psbt.cpp

…

psbt.h

…

pubkey.cpp

…

pubkey.h

…

random.cpp

…

random.h

…

randomenv.cpp

…

randomenv.h

…

rest.cpp

rpc: Avoid useless mempool query in gettxoutproof

2020-07-26 16:44:07 +02:00

reverse_iterator.h

…

scheduler.cpp

…

scheduler.h

…

serialize.h

…

shutdown.cpp

…

shutdown.h

…

span.h

span: Add Span::empty() and use it in script/descriptor

2020-07-19 20:51:06 +02:00

streams.h

refactor: Drop unused CBufferedFile::Seek()

2020-07-26 22:46:28 +03:00

sync.cpp

…

sync.h

…

threadinterrupt.cpp

…

threadinterrupt.h

…

threadsafety.h

…

timedata.cpp

…

timedata.h

…

tinyformat.h

…

torcontrol.cpp

…

torcontrol.h

…

txdb.cpp

Merge #18637: coins: allow cache resize after init

2020-07-29 07:53:19 +02:00

txdb.h

…

txmempool.cpp

refactor: make txmempool interface use GenTxid

2020-07-30 13:45:03 -07:00

txmempool.h

refactor: make txmempool interface use GenTxid

2020-07-30 13:45:03 -07:00

uint256.cpp

…

uint256.h

…

undo.h

…

validation.cpp

Pass mempool pointer to GetCoinsCacheSizeState

2020-07-29 12:30:11 +02:00

validation.h

Pass mempool pointer to GetCoinsCacheSizeState

2020-07-29 12:30:11 +02:00

validationinterface.cpp

…

validationinterface.h

…

version.h

Add p2p message "wtxidrelay"

2020-07-19 02:10:41 -04:00

versionbits.cpp

…

versionbits.h

…

versionbitsinfo.cpp

…

versionbitsinfo.h

…

walletinitinterface.h

refactor: add unused ArgsManager to replace gArgs

2020-07-29 16:36:44 +07:00

warnings.cpp

…

warnings.h

…