highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-26 07:26:15 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
06329eb13488640159057c897978b3f0f2e33ab5
bitcoin/src
History
Ava Chow 06329eb134 Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections 
e4e3b44e9c net: call `Select` with reachable networks in `ThreadOpenConnections` (brunoerg)
829becd990 addrman: change `Select` to support multiple networks (brunoerg)
f698636ec8 net: add `All()` in `ReachableNets` (brunoerg)

Pull request description:

  This PR changes addrman's `Select` to support multiple networks and change `ThreadOpenConnections` to call it with reachable networks. It can avoid unnecessary `Select` calls and avoid exceeding the max number of tries (100), especially when turning a clearnet + Tor/I2P/CJDNS node to Tor/I2P/CJDNS. Compared to #29330, this approach is "less aggresive". It does not add a new init flag and does not impact address relay.

  I did an experiment of calling `Select` without passing a network until it finds an address from a network that compose 20% ~ 25% of the addrman (limited to 100 tries).

  ![Screenshot 2024-02-14 at 14 37 58](https://github.com/bitcoin/bitcoin/assets/19480819/7b6863a5-d7a6-40b6-87d5-01667c2de66a)

ACKs for top commit:
  achow101:
    ACK e4e3b44e9c
  vasild:
    ACK e4e3b44e9c
  naumenkogs:
    ACK e4e3b44e9c

Tree-SHA512: e8466b72b85bbc2ad8bfb14471eb27d2c50d4e84218f5ede2c15a6fa3653af61b488cde492dbd398f7502bd847e95bfee1abb7e01092daba2236d3ce3d6d2268
2024-09-16 16:49:25 -04:00
..
bench
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections
2024-09-16 16:49:25 -04:00
common
multiprocess: Add -ipcbind option to bitcoin-node
2024-09-06 09:08:10 -04:00
compat
…
config
…
consensus
doc: fix a few simple codespell warnings
2024-08-28 18:42:10 +02:00
crc32c
…
crypto
cmake: Build bitcoin_crypto library
2024-08-16 19:27:38 +01:00
index
util: Use compile-time check for FatalErrorf
2024-09-12 15:01:20 +02:00
init
multiprocess: Add -ipcbind option to bitcoin-node
2024-09-06 09:08:10 -04:00
interfaces
Have createNewBlock return BlockTemplate interface
2024-09-13 10:14:53 +02:00
ipc
multiprocess: Add unit tests for connect, serve, and listen functions
2024-09-06 09:08:10 -04:00
kernel
Merge bitcoin/bitcoin#30814: kernel: Create usable static kernel library
2024-09-12 16:39:34 +01:00
leveldb
Update leveldb-subtree subtree to latest upstream
2024-06-13 13:17:57 +01:00
logging
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
minisketch
Update minisketch subtree to latest master
2024-06-12 14:38:39 +01:00
node
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
policy
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
primitives
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
qt
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
rpc
Merge bitcoin/bitcoin#30410: rpc, rest: Improve block rpc error handling, check header before attempting to read block data.
2024-09-16 16:17:59 -04:00
script
Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string
2024-08-28 15:56:15 +01:00
secp256k1
Update secp256k1 subtree to latest master
2024-09-07 18:15:41 +01:00
support
cleanse: Use SecureZeroMemory for mingw-w64 (release) builds
2024-07-24 09:57:49 +01:00
test
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections
2024-09-16 16:49:25 -04:00
univalue
build: Remove Autotools-based build system
2024-08-30 21:31:39 +01:00
util
util: Use compile-time check for FatalErrorf
2024-09-12 15:01:20 +02:00
wallet
Merge bitcoin/bitcoin#30684: init: fix init fatal error on invalid negated option value
2024-09-09 12:44:29 -04:00
zmq
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
.clang-format
…
.clang-tidy
tidy: add clang-tidy modernize-use-starts-ends-with check
2024-09-14 20:33:32 +03:00
addrdb.cpp
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
addrdb.h
…
addresstype.cpp
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addresstype.h
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addrman_impl.h
addrman: change Select to support multiple networks
2024-09-10 12:58:54 -03:00
addrman.cpp
addrman: change Select to support multiple networks
2024-09-10 12:58:54 -03:00
addrman.h
addrman: change Select to support multiple networks
2024-09-10 12:58:54 -03:00
arith_uint256.cpp
…
arith_uint256.h
doc + test: Correct uint256 hex string endianness
2024-08-03 21:59:54 +02:00
attributes.h
…
banman.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
banman.h
net_processing: remove Misbehavior score and increments
2024-05-30 08:35:18 -04:00
base58.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
base58.h
…
bech32.cpp
fuzz: replace hardcoded numbers for bech32 limits
2024-08-06 11:03:31 +02:00
bech32.h
fuzz: replace hardcoded numbers for bech32 limits
2024-08-06 11:03:31 +02:00
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: Move background load thread to node context
2024-09-13 16:10:31 +02:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge bitcoin/bitcoin#30148: cli: restrict multiple exclusive argument usage in bitcoin-cli
2024-09-04 14:47:38 -04:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
refactor: Replace ParseHashStr with FromHex
2024-07-24 17:40:18 +02:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes
2024-05-01 08:33:04 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
testnet: Introduce Testnet4
2024-08-06 01:38:10 +02:00
bitcoind-res.rc
…
bitcoind.cpp
multiprocess: Add -ipcbind option to bitcoin-node
2024-09-06 09:08:10 -04:00
blockencodings.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
blockencodings.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
blockfilter.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
blockfilter.h
…
chain.cpp
…
chain.h
scripted-diff: Modernize naming of nChainTx and nTxCount
2024-08-04 14:24:43 +02:00
chainparams.cpp
testnet: Introduce Testnet4
2024-08-06 01:38:10 +02:00
chainparams.h
…
chainparamsbase.cpp
Deduplicate list of chain strings in RPC help texts
2024-08-13 14:00:33 -03:00
chainparamsbase.h
Deduplicate list of chain strings in RPC help texts
2024-08-13 14:00:33 -03:00
chainparamsseeds.h
seeds: Regenerate mainnet seeds
2024-08-27 07:00:27 +02:00
checkqueue.h
…
clientversion.cpp
doc: Drop mentions of share/genbuild.sh
2024-08-29 12:38:37 +01:00
clientversion.h
scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes
2024-05-01 08:33:04 +02:00
cluster_linearize.h
clusterlin: only start/use search when enough iterations left
2024-09-12 15:15:36 -04:00
CMakeLists.txt
build: Skip secp256k1 ctime tests when tests are not being built
2024-09-12 14:24:26 +01:00
coins.cpp
Reduce cache lookups in CCoinsViewCache::FetchCoin
2024-08-08 22:51:24 +02:00
coins.h
coins: move Sync logic to CoinsViewCacheCursor
2024-08-05 22:34:35 -04:00
compressor.cpp
…
compressor.h
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
core_io.h
refactor: Replace ParseHashStr with FromHex
2024-07-24 17:40:18 +02:00
core_memusage.h
…
core_read.cpp
refactor: Replace ParseHashStr with FromHex
2024-07-24 17:40:18 +02:00
core_write.cpp
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
cuckoocache.h
validation: Don't error if maxsigcachesize exceeds uint32::max
2024-07-04 22:35:29 +02:00
dbwrapper.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
wallet, test: Be able to always swap BDB endianness
2024-05-16 15:03:13 -04:00
external_signer.cpp
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
external_signer.h
…
flatfile.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
flatfile.h
refactor: Add FlatFileSeq member variables in BlockManager
2024-07-24 09:39:35 +02:00
hash.cpp
…
hash.h
…
headerssync.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
headerssync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
httprpc.cpp
Merge bitcoin/bitcoin#30401: fix: increase consistency of rpcauth parsing
2024-09-09 12:29:17 -04:00
httprpc.h
…
httpserver.cpp
tidy: add clang-tidy modernize-use-starts-ends-with check
2024-09-14 20:33:32 +03:00
httpserver.h
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
i2p.cpp
Merge bitcoin/bitcoin#29833: i2p: fix and improve logs
2024-06-26 15:28:26 -04:00
i2p.h
i2p: log errors properly according to their severity
2024-06-12 16:19:50 -03:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
init.h
multiprocess: Add -ipcbind option to bitcoin-node
2024-09-06 09:08:10 -04:00
key_io.cpp
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
key_io.h
…
key.cpp
refactor: remove un-tested early returns
2024-08-04 08:52:22 +02:00
key.h
refactor: move SignSchnorr to KeyPair
2024-08-04 08:51:36 +02:00
logging.cpp
rpc: make logging method reject "0" category and correct the help text
2024-08-04 06:43:00 +02:00
logging.h
bench: Remove redundant logging benchmarks
2024-09-05 07:17:22 +02:00
mapport.cpp
upnp: add compatibility for miniupnpc 2.2.8
2024-06-18 12:24:48 +00:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net_permissions.cpp
util: move fees.h and error.h to common/messages.h
2024-05-16 10:16:08 -05:00
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#30661: fuzz: Test headers pre-sync through p2p
2024-09-16 13:59:22 -04:00
net_processing.h
net_processing: Make MAX_HEADERS_RESULTS a PeerManager option
2024-09-02 15:42:44 +01:00
net_types.cpp
rpc: avoid copying into UniValue
2024-05-20 16:48:19 +00:00
net_types.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net.cpp
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections
2024-09-16 16:49:25 -04:00
net.h
assumeUTXO: fix peers disconnection during sync
2024-09-10 18:08:32 -03:00
netaddress.cpp
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
netaddress.h
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
netbase.cpp
Merge bitcoin/bitcoin#30868: refactor: add clang-tidy modernize-use-starts-ends-with check
2024-09-16 15:47:04 -04:00
netbase.h
net: add All() in ReachableNets
2024-09-10 11:20:40 -03:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
fix incorrect multisig redeem script size limit for segwit
2024-05-03 14:20:44 -03:00
outputtype.h
fix incorrect multisig redeem script size limit for segwit
2024-05-03 14:20:44 -03:00
pow.cpp
Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check
2024-09-02 15:43:33 +01:00
pow.h
Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check
2024-09-02 15:43:33 +01:00
prevector.h
refactor: Require std::input_iterator for all InputIterator in prevector
2024-07-12 11:19:00 +02:00
protocol.cpp
…
protocol.h
Merge bitcoin/bitcoin#29421: net: make the list of known message types a compile time constant
2024-05-21 13:59:33 -04:00
psbt.cpp
util: add TransactionError includes and namespace declarations
2024-05-16 10:16:08 -05:00
psbt.h
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
pubkey.cpp
refactor: Hand-replace some ParseHex -> ""_hex
2024-08-28 19:11:59 +02:00
pubkey.h
refactor: Make XOnlyPubKey tolerate constexpr std::arrays
2024-08-28 19:09:51 +02:00
random.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
random.h
random: drop ad-hoc Shuffle in favor of std::shuffle
2024-07-06 09:06:36 -04:00
randomenv.cpp
Fix MSVC warning C4273 "inconsistent dll linkage"
2024-07-19 22:01:01 +01:00
randomenv.h
…
rest.cpp
rest: improve error when only header of a block is available.
2024-09-13 10:50:43 -04:00
rest.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
signet.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
signet.h
…
span.h
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
streams.cpp
…
streams.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
sync.cpp
util: avoid using thread_local variable that has a destructor
2024-05-16 18:16:46 +02:00
sync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
threadsafety.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
tinyformat.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
torcontrol.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
torcontrol.h
…
txdb.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
txdb.h
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
txmempool.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
txmempool.h
Revert "build: work around issue with Boost <= 1.80 and Clang >= 18"
2024-09-06 15:57:00 +02:00
txorphanage.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
txorphanage.h
Merge bitcoin/bitcoin#30082: test: expand LimitOrphan and EraseForPeer coverage
2024-08-05 17:25:57 -04:00
txrequest.cpp
Merge bitcoin/bitcoin#30194: refactor: use recommended type hiding on multi_index types
2024-08-07 20:00:28 +01:00
txrequest.h
…
uint256.cpp
scripted-diff: Rename SetHex to SetHexDeprecated
2024-07-24 09:15:34 +02:00
uint256.h
test: remove test-only uint256S
2024-09-06 17:36:18 +02:00
undo.h
…
validation.cpp
assumeUTXO: fix peers disconnection during sync
2024-09-10 18:08:32 -03:00
validation.h
kernel: Move background load thread to node context
2024-09-13 16:10:31 +02:00
validationinterface.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
validationinterface.h
[refactor] change ActiveTipChange to use CBlockIndex ref instead of ptr
2024-07-25 11:01:22 +01:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00