highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-28 23:43:53 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
06329eb13488640159057c897978b3f0f2e33ab5
bitcoin/src
History
Ava Chow 06329eb134 Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections 
e4e3b44e9c net: call `Select` with reachable networks in `ThreadOpenConnections` (brunoerg)
829becd990 addrman: change `Select` to support multiple networks (brunoerg)
f698636ec8 net: add `All()` in `ReachableNets` (brunoerg)

Pull request description:

  This PR changes addrman's `Select` to support multiple networks and change `ThreadOpenConnections` to call it with reachable networks. It can avoid unnecessary `Select` calls and avoid exceeding the max number of tries (100), especially when turning a clearnet + Tor/I2P/CJDNS node to Tor/I2P/CJDNS. Compared to #29330, this approach is "less aggresive". It does not add a new init flag and does not impact address relay.

  I did an experiment of calling `Select` without passing a network until it finds an address from a network that compose 20% ~ 25% of the addrman (limited to 100 tries).

  ![Screenshot 2024-02-14 at 14 37 58](https://github.com/bitcoin/bitcoin/assets/19480819/7b6863a5-d7a6-40b6-87d5-01667c2de66a)

ACKs for top commit:
  achow101:
    ACK e4e3b44e9c
  vasild:
    ACK e4e3b44e9c
  naumenkogs:
    ACK e4e3b44e9c

Tree-SHA512: e8466b72b85bbc2ad8bfb14471eb27d2c50d4e84218f5ede2c15a6fa3653af61b488cde492dbd398f7502bd847e95bfee1abb7e01092daba2236d3ce3d6d2268
2024-09-16 16:49:25 -04:00
..
bench
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections
2024-09-16 16:49:25 -04:00
common
…
compat
…
config
…
consensus
…
crc32c
…
crypto
…
index
…
init
…
interfaces
…
ipc
…
kernel
…
leveldb
…
logging
…
minisketch
…
node
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
policy
…
primitives
…
qt
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
rpc
Merge bitcoin/bitcoin#30410: rpc, rest: Improve block rpc error handling, check header before attempting to read block data.
2024-09-16 16:17:59 -04:00
script
…
secp256k1
…
support
…
test
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections
2024-09-16 16:49:25 -04:00
univalue
…
util
…
wallet
…
zmq
…
.clang-format
…
.clang-tidy
…
addrdb.cpp
…
addrdb.h
…
addresstype.cpp
…
addresstype.h
…
addrman_impl.h
…
addrman.cpp
…
addrman.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
…
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
…
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
chain.cpp
…
chain.h
…
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
cluster_linearize.h
…
CMakeLists.txt
…
coins.cpp
…
coins.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
…
flatfile.h
…
hash.cpp
…
hash.h
…
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
…
httpserver.h
…
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
init.h
…
key_io.cpp
…
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
…
logging.h
…
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
…
net_processing.h
…
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections
2024-09-16 16:49:25 -04:00
net.h
…
netaddress.cpp
…
netaddress.h
…
netbase.cpp
Merge bitcoin/bitcoin#30868: refactor: add clang-tidy modernize-use-starts-ends-with check
2024-09-16 15:47:04 -04:00
netbase.h
…
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
…
psbt.h
…
pubkey.cpp
…
pubkey.h
…
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
rest.cpp
…
rest.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
signet.cpp
…
signet.h
…
span.h
…
streams.cpp
…
streams.h
…
sync.cpp
…
sync.h
…
threadsafety.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
…
txdb.h
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
txmempool.cpp
…
txmempool.h
…
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
…
validation.h
…
validationinterface.cpp
…
validationinterface.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…