highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-02 16:01:58 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
Ava Chow 06329eb134
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections 
e4e3b44e9cc7227b3ad765397c884999f57bac2e net: call `Select` with reachable networks in `ThreadOpenConnections` (brunoerg)
829becd990b504a2e8a57fa8a6ff6ac6ae8ff900 addrman: change `Select` to support multiple networks (brunoerg)
f698636ec86c004ab331994559c163b7319e6423 net: add `All()` in `ReachableNets` (brunoerg)

Pull request description:

  This PR changes addrman's `Select` to support multiple networks and change `ThreadOpenConnections` to call it with reachable networks. It can avoid unnecessary `Select` calls and avoid exceeding the max number of tries (100), especially when turning a clearnet + Tor/I2P/CJDNS node to Tor/I2P/CJDNS. Compared to #29330, this approach is "less aggresive". It does not add a new init flag and does not impact address relay.

  I did an experiment of calling `Select` without passing a network until it finds an address from a network that compose 20% ~ 25% of the addrman (limited to 100 tries).

  ![Screenshot 2024-02-14 at 14 37 58](https://github.com/bitcoin/bitcoin/assets/19480819/7b6863a5-d7a6-40b6-87d5-01667c2de66a)

ACKs for top commit:
  achow101:
    ACK e4e3b44e9cc7227b3ad765397c884999f57bac2e
  vasild:
    ACK e4e3b44e9cc7227b3ad765397c884999f57bac2e
  naumenkogs:
    ACK e4e3b44e9cc7227b3ad765397c884999f57bac2e

Tree-SHA512: e8466b72b85bbc2ad8bfb14471eb27d2c50d4e84218f5ede2c15a6fa3653af61b488cde492dbd398f7502bd847e95bfee1abb7e01092daba2236d3ce3d6d2268
2024-09-16 16:49:25 -04:00
..
bench
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections
2024-09-16 16:49:25 -04:00
common
multiprocess: Add -ipcbind option to bitcoin-node
2024-09-06 09:08:10 -04:00
compat
…
config
…
consensus
…
crc32c
…
crypto
…
index
util: Use compile-time check for FatalErrorf
2024-09-12 15:01:20 +02:00
init
multiprocess: Add -ipcbind option to bitcoin-node
2024-09-06 09:08:10 -04:00
interfaces
Have createNewBlock return BlockTemplate interface
2024-09-13 10:14:53 +02:00
ipc
multiprocess: Add unit tests for connect, serve, and listen functions
2024-09-06 09:08:10 -04:00
kernel
Merge bitcoin/bitcoin#30814: kernel: Create usable static kernel library
2024-09-12 16:39:34 +01:00
leveldb
…
logging
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
minisketch
…
node
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
policy
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
primitives
…
qt
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
rpc
Merge bitcoin/bitcoin#30410: rpc, rest: Improve block rpc error handling, check header before attempting to read block data.
2024-09-16 16:17:59 -04:00
script
…
secp256k1
Update secp256k1 subtree to latest master
2024-09-07 18:15:41 +01:00
support
…
test
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections
2024-09-16 16:49:25 -04:00
univalue
build: Remove Autotools-based build system
2024-08-30 21:31:39 +01:00
util
util: Use compile-time check for FatalErrorf
2024-09-12 15:01:20 +02:00
wallet
Merge bitcoin/bitcoin#30684: init: fix init fatal error on invalid negated option value
2024-09-09 12:44:29 -04:00
zmq
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
.clang-format
…
.clang-tidy
tidy: add clang-tidy modernize-use-starts-ends-with check
2024-09-14 20:33:32 +03:00
addrdb.cpp
…
addrdb.h
…
addresstype.cpp
…
addresstype.h
…
addrman_impl.h
addrman: change Select to support multiple networks
2024-09-10 12:58:54 -03:00
addrman.cpp
addrman: change Select to support multiple networks
2024-09-10 12:58:54 -03:00
addrman.h
addrman: change Select to support multiple networks
2024-09-10 12:58:54 -03:00
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: Move background load thread to node context
2024-09-13 16:10:31 +02:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge bitcoin/bitcoin#30148: cli: restrict multiple exclusive argument usage in bitcoin-cli
2024-09-04 14:47:38 -04:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
…
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
multiprocess: Add -ipcbind option to bitcoin-node
2024-09-06 09:08:10 -04:00
blockencodings.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
chain.cpp
…
chain.h
…
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
doc: Drop mentions of share/genbuild.sh
2024-08-29 12:38:37 +01:00
clientversion.h
…
cluster_linearize.h
clusterlin: only start/use search when enough iterations left
2024-09-12 15:15:36 -04:00
CMakeLists.txt
build: Skip secp256k1 ctime tests when tests are not being built
2024-09-12 14:24:26 +01:00
coins.cpp
…
coins.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
flatfile.h
…
hash.cpp
…
hash.h
…
headerssync.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
headerssync.h
…
httprpc.cpp
Merge bitcoin/bitcoin#30401: fix: increase consistency of rpcauth parsing
2024-09-09 12:29:17 -04:00
httprpc.h
…
httpserver.cpp
tidy: add clang-tidy modernize-use-starts-ends-with check
2024-09-14 20:33:32 +03:00
httpserver.h
…
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
init.h
multiprocess: Add -ipcbind option to bitcoin-node
2024-09-06 09:08:10 -04:00
key_io.cpp
…
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
…
logging.h
bench: Remove redundant logging benchmarks
2024-09-05 07:17:22 +02:00
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#30661: fuzz: Test headers pre-sync through p2p
2024-09-16 13:59:22 -04:00
net_processing.h
net_processing: Make MAX_HEADERS_RESULTS a PeerManager option
2024-09-02 15:42:44 +01:00
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#29436: net: call Select with reachable networks in ThreadOpenConnections
2024-09-16 16:49:25 -04:00
net.h
assumeUTXO: fix peers disconnection during sync
2024-09-10 18:08:32 -03:00
netaddress.cpp
…
netaddress.h
…
netbase.cpp
Merge bitcoin/bitcoin#30868: refactor: add clang-tidy modernize-use-starts-ends-with check
2024-09-16 15:47:04 -04:00
netbase.h
net: add All() in ReachableNets
2024-09-10 11:20:40 -03:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check
2024-09-02 15:43:33 +01:00
pow.h
Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check
2024-09-02 15:43:33 +01:00
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
…
psbt.h
…
pubkey.cpp
refactor: Hand-replace some ParseHex -> ""_hex
2024-08-28 19:11:59 +02:00
pubkey.h
…
random.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
rest: improve error when only header of a block is available.
2024-09-13 10:50:43 -04:00
rest.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
signet.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
signet.h
…
span.h
…
streams.cpp
…
streams.h
…
sync.cpp
…
sync.h
…
threadsafety.h
…
tinyformat.h
…
torcontrol.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
torcontrol.h
…
txdb.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
txdb.h
Merge bitcoin/bitcoin#28358: Drop -dbcache limit
2024-09-16 15:56:02 -04:00
txmempool.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
txmempool.h
Revert "build: work around issue with Boost <= 1.80 and Clang >= 18"
2024-09-06 15:57:00 +02:00
txorphanage.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
txorphanage.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
test: remove test-only uint256S
2024-09-06 17:36:18 +02:00
undo.h
…
validation.cpp
assumeUTXO: fix peers disconnection during sync
2024-09-10 18:08:32 -03:00
validation.h
kernel: Move background load thread to node context
2024-09-13 16:10:31 +02:00
validationinterface.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
validationinterface.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…