laanwj 06ea2783a2 Merge bitcoin/bitcoin#25220: rpc: fix incorrect warning for address type p2sh-segwit in createmultisig ...

3a9b9bb38e test: ensure createmultisig and addmultisigaddress are not returning any warning for expected cases (brunoerg)
eaf6f630c0 rpc: fix inappropriate warning for address type p2sh-segwit in createmultisig and addmultisigaddress (brunoerg)

Pull request description:

  Fixes #25127

  If there are any uncompressed keys when calling `AddAndGetMultisigDestination`, it will just default to a legacy address regardless of the chosen `address_type`. So, #23113 added a warnings field which will warn the user why their address format is different.

  However, when creating a multisig (p2sh-segwit), it is returning an inappropriate warning, because when getting the output type from destination (`OutputTypeFromDestination`), it returns `ScriptHash` for both legacy and `P2SH_SEGWIT`. So, since `P2SH_SEGWIT` is different from `ScriptHash`, it returns the warning:
  192d639a6b/src/rpc/output_script.cpp (L166-L169)

  So, to avoid this mistake I changed `OutputTypeFromDestination` to `descriptor->GetOutputType()` to get the appropriate output type.

ACKs for top commit:
  jonatack:
    ACK 3a9b9bb38e
  laanwj:
    Code review ACK 3a9b9bb38e

Tree-SHA512: 49f717479c2b8906277e7591ddd4747f7961c2d5c77494b5124045de9036a4277d46b9ad99279d51f0c4484284c445f1e1d3c55c49bbf0716741bad426a89369

2022-06-06 17:13:22 +02:00

..

rpc

Merge bitcoin/bitcoin#25220: rpc: fix incorrect warning for address type p2sh-segwit in createmultisig

2022-06-06 17:13:22 +02:00

test

fuzz: coinselection, add missing fee rate.

2022-05-25 14:07:33 -03:00

bdb.cpp

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

bdb.h

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

coincontrol.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

coincontrol.h

wallet: add input weights to CCoinControl

2022-01-24 11:23:31 -05:00

coinselection.cpp

logging: Unconditionally log levels >= WARN

2022-05-25 11:26:15 +02:00

coinselection.h

Set effective_value when initializing a COutput

2022-05-21 11:25:54 -04:00

context.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

context.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

db.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

db.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

external_signer_scriptpubkeyman.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

external_signer_scriptpubkeyman.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

feebumper.cpp

wallet: CreateTransaction(): return out-params as (optional) struct

2022-05-16 17:46:34 +02:00

feebumper.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

init.cpp

Merge bitcoin/bitcoin#18554: wallet: ensure wallet files are not reused across chains

2022-04-28 15:59:47 -04:00

interfaces.cpp

Merge bitcoin/bitcoin#25148: refactor: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code

2022-05-18 16:23:43 +02:00

ismine.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

load.cpp

wallet: Postpone NotifyWalletLoaded() for encrypted wallets

2022-03-30 21:28:53 +02:00

load.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

receive.cpp

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

receive.h

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

salvage.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

salvage.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

spend.cpp

Merge bitcoin/bitcoin#25003: tracing: fix coin_selection:aps_create_tx_internal calling logic

2022-05-26 13:49:52 -04:00

spend.h

Set effective_value when initializing a COutput

2022-05-21 11:25:54 -04:00

sqlite.cpp

scripted-diff: rename BytePtr to AsBytePtr

2022-04-26 09:41:45 +01:00

sqlite.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

transaction.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

transaction.h

wallet: add GetWitnessHash()

2022-02-01 08:44:51 -03:00

wallet.cpp

Merge bitcoin/bitcoin#25148: refactor: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code

2022-05-18 16:23:43 +02:00

wallet.h

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

walletdb.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

walletdb.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

wallettool.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

wallettool.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

walletutil.cpp

Use ArgsManager::GetPathArg() for "-walletdir" option

2022-02-09 19:31:23 +02:00

walletutil.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00