fanquake 081965ccc3 Merge bitcoin/bitcoin#25464: rpc: Reduce Univalue push_backV peak memory usage in listtransactions ...

fa8a1c0696 rpc: Fix Univalue push_backV OOM in listtransactions (MacroFake)

Pull request description:

  Related to, but not intended as a fix for #25229.

  Currently the RPC will have the same data stored thrice:

  * `UniValue ret` (memory filled by `ListTransactions`)
  * `std::vector<UniValue> vec` (constructed by calling `push_backV`)
  * `UniValue result` (the actual result, memory filled by `push_backV`)

  Fix this by filling the memory only once:

  * `std::vector<UniValue> ret` (memory filled by `ListTransactions`)
  * Pass iterators to `push_backV` instead of creating a full copy
  * Move memory into `UniValue result` instead of copying it

ACKs for top commit:
  shaavan:
    Code Review ACK fa8a1c0696

Tree-SHA512: 1c3ca40fc8497134a4141195160e4aa9fe72b3c00c5998c972b58ad0eb498ebea05013f9105bb80e7264c9db1d0e7a2032396a8a4af1f326d831fbee20f32ea3

2022-07-13 15:58:53 +01:00

..

addresses.cpp

wallet: refactor GetNewDestination, use BResult

2022-07-08 11:18:35 -03:00

backup.cpp

…

coins.cpp

Merge bitcoin/bitcoin#25337: refactor: encapsulate wallet's address book access

2022-07-08 10:16:08 -04:00

encrypt.cpp

…

signmessage.cpp

…

spend.cpp

send: refactor CreateTransaction flow to return a BResult<CTransactionRef>

2022-07-08 11:18:35 -03:00

transactions.cpp

Merge bitcoin/bitcoin#25464: rpc: Reduce Univalue push_backV peak memory usage in listtransactions

2022-07-13 15:58:53 +01:00

util.cpp

…

util.h

…

wallet.cpp

…

wallet.h

…