mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 21:52:53 +02:00
c6f225c757
451fdd26a4test: wallet: Constructing a DSPKM that can't TopUp() throws. (David Gumberg)32946e0291wallet: Setup new autogenerated descriptors on construction (Ava Chow)e20aaff70fwallet: Construct ExternalSignerSPKM with the new descriptor (Ava Chow)aa4f7823aawallet: include keys when constructing DescriptorSPKM during import (Ava Chow)6538f69135fuzz: Skip adding descriptor to wallet if it cannot be expanded (Ava Chow)8be5ee554btest: wallet: Check that loading wallet with both unencrypted and encrypted keys fails. (David Gumberg)80b0c25992wallet: Load everything into DescSPKM on construction (Ava Chow)f713fd1725refactor: wallet: Don't reuse WALLET_BLANK flag for born-encrypted wallets. (David Gumberg)cd912c4e10wallet: Consolidate generation setup callers into one function (Ava Chow)0301c758eawallet migration, fuzz: Migrate hd seed once (Ava Chow) Pull request description: Instead of constructing ScriptPubKeyMans with no data, and then loading data as we find it, we should gather everything first and then load it all on construction. If there actually is no data and we want to setup generation, then that should also occur in a constructor rather than afterwards. This change is only applied to DescriptorScriptPubKeyMan and ExternalSignerScriptPubKeyMan, and should be done for any ScriptPubKeyMans added in the future. I don't think it's really worth it to do this for LegacyScriptPubKeyMan since it would make loading performance worse (or cause layer violations) and it's (supposed to be) going away soon. ACKs for top commit: polespinasa: ACK451fdd26a4davidgumberg: re crACK451fdd26a4w0xlt: ACK451fdd26a4Tree-SHA512: 58a889bf7c77d5da78041907a76a1958207f95a19bec8dc4d86d4e4108d256a729e0949c0973f7d447178f78a7fd4268cda71d358cae4dec5a76dc453b5283af