mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 13:42:10 +02:00
a9301cfa07refactor: disable default std::hash for CTransactionRef (Sjors Provoost)47d68cd981ci: backport iwyu PR 2013 std::hash mapping (Sjors Provoost) Pull request description: While working on #33922 I initially forgot to add `CTransactionRefComp` to the `std::unordered_map<CTransactionRef` defined there. This PR turns that into a compiler error. See https://github.com/bitcoin/bitcoin/pull/33922#discussion_r2894597519 This change triggers a false positive IWYU error, and an inconsistent one at that: our CI wants `<variant>`, while a manual build on Ubuntu (version 0.26 with clang version 22.1.1) wants `<string_view>`. Various workarounds were discussed in: - https://github.com/include-what-you-use/include-what-you-use/issues/2007 - https://github.com/bitcoin/bitcoin/pull/35073 - https://github.com/bitcoin/bitcoin/pull/33922#discussion_r3100806462 Addressed by back-porting: - https://github.com/include-what-you-use/include-what-you-use/pull/2013 ACKs for top commit: achow101: ACKa9301cfa07vasild: ACKa9301cfa07w0xlt: lgtm ACKa9301cfa07Tree-SHA512: 11b3f8698e66457a14d1c16f55cac3ee17a572e9c1c98f5aa9c8a8f1e8928246b1676f7544f2819bc16ec4dcf025585b9cbd60ab3f20839d3d9bcc65ee9e7c0f