mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-14 15:25:51 +02:00
ec6cf49b91
The cs_LastBlockFile mutex is redundant: all critical sections are already covered by cs_main. This is demonstrated in this patch by replacing all instances of locking cs_LastBlockFile with pairs of `AssertLockHeld(::cs_main)` and `EXCLUSIVE_LOCKS_REQUIRED(::cs_main)` annotations. No additional `::cs_main` LOCK(...)s are introduced. It is also not clear for which sections `cs_LastBlockFile` is responsible for. It is annotated for `m_blockfile_cursors`, but sporadically and inconsistently also covers `m_blockfile_info`. Since it has no semantic meaning, and seems confusing to developers, remove it.
69 lines
2.1 KiB
C++
69 lines
2.1 KiB
C++
// Copyright (c) 2023-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <bench/bench.h>
|
|
#include <bench/data/block413567.raw.h>
|
|
#include <flatfile.h>
|
|
#include <node/blockstorage.h>
|
|
#include <primitives/block.h>
|
|
#include <primitives/transaction.h>
|
|
#include <serialize.h>
|
|
#include <span.h>
|
|
#include <streams.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <validation.h>
|
|
|
|
#include <cassert>
|
|
#include <cstdint>
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
static CBlock CreateTestBlock()
|
|
{
|
|
CBlock block;
|
|
SpanReader{benchmark::data::block413567} >> TX_WITH_WITNESS(block);
|
|
return block;
|
|
}
|
|
|
|
static void WriteBlockBench(benchmark::Bench& bench)
|
|
{
|
|
const auto testing_setup{MakeNoLogFileContext<const TestingSetup>(ChainType::MAIN)};
|
|
auto& blockman{testing_setup->m_node.chainman->m_blockman};
|
|
const CBlock block{CreateTestBlock()};
|
|
bench.run([&] {
|
|
LOCK(::cs_main);
|
|
const auto pos{blockman.WriteBlock(block, 413'567)};
|
|
assert(!pos.IsNull());
|
|
});
|
|
}
|
|
|
|
static void ReadBlockBench(benchmark::Bench& bench)
|
|
{
|
|
const auto testing_setup{MakeNoLogFileContext<const TestingSetup>(ChainType::MAIN)};
|
|
auto& blockman{testing_setup->m_node.chainman->m_blockman};
|
|
const auto& test_block{CreateTestBlock()};
|
|
const auto& expected_hash{test_block.GetHash()};
|
|
const auto& pos{WITH_LOCK(::cs_main, return blockman.WriteBlock(test_block, 413'567))};
|
|
bench.run([&] {
|
|
CBlock block;
|
|
const auto success{blockman.ReadBlock(block, pos, expected_hash)};
|
|
assert(success);
|
|
});
|
|
}
|
|
|
|
static void ReadRawBlockBench(benchmark::Bench& bench)
|
|
{
|
|
const auto testing_setup{MakeNoLogFileContext<const TestingSetup>(ChainType::MAIN)};
|
|
auto& blockman{testing_setup->m_node.chainman->m_blockman};
|
|
const auto pos{WITH_LOCK(::cs_main, return blockman.WriteBlock(CreateTestBlock(), 413'567))};
|
|
bench.run([&] {
|
|
const auto res{blockman.ReadRawBlock(pos)};
|
|
assert(res);
|
|
});
|
|
}
|
|
|
|
BENCHMARK(WriteBlockBench);
|
|
BENCHMARK(ReadBlockBench);
|
|
BENCHMARK(ReadRawBlockBench);
|