bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-01 02:30:51 +02:00

History

Merge bitcoin/bitcoin#29777 : test: refactor: introduce and use calculate_input_weight helper

6d91cb781c30966963f28e7577c7aa3829fa9390 test: add unit tests for `calculate_input_weight` (Sebastian Falbesoner)
f81fad5e0f3be1f7aed59f9da00396c75c2a6406 test: introduce and use `calculate_input_weight` helper (Sebastian Falbesoner)

Pull request description:

  Rather than manually estimating an input's weight by adding up all the involved components (fixed-size skeleton, compact-serialized lengths, and the actual scriptSig / witness stack items) we can simply take use of the serialization classes `CTxIn` / `CTxInWitness` instead, to achieve the same with significantly less code.

  The new helper is used in the functional tests rpc_psbt.py and wallet_send.py, where the previous manual estimation code was
  duplicated. Unit tests are added in the second commit.

ACKs for top commit:
  kevkevinpal:
    tACK [6d91cb7](6d91cb781c)
  QureshiFaisal:
    tACK [6d91cb7](6d91cb781c)
  achow101:
    ACK 6d91cb781c30966963f28e7577c7aa3829fa9390
  AngusP:
    tACK 6d91cb781c30966963f28e7577c7aa3829fa9390
  rkrux:
    tACK [6d91cb7](6d91cb781c)

Tree-SHA512: 04424e4d94d0e13745a9c11df2dd3697c98552bbb0e792c4af67ecbb66060adc3cc0cefc202cdee2d9db0baf85b8bedf2eb339ac4b316d986b5f10f6b70c5a33

2024-04-22 18:51:59 -04:00

crypto

test: speedup bip324_cipher.py unit test

2024-02-06 01:35:03 +01:00

__init__.py

…

address.py

refactor: move address_to_scriptpubkey to address.py

2023-03-28 16:54:28 +01:00

authproxy.py

test: Rename EncodeDecimal to serialization_fallback

2023-06-29 19:51:43 +02:00