fanquake 0a13d15c14

Merge #20530: lint, refactor: Update cppcheck linter to c++17 and improve explicit usage ...

1e62350ca20898189904a88dfef9ea11ddcd8626 refactor: Improve use of explicit keyword (Fabian Jahr)
c502a6dbfb854ca827a5a3925394f9e09d29b898 lint: Use c++17 std in cppcheck linter (Fabian Jahr)

Pull request description:

  I found the `extended-lint-cppcheck` linter still uses `std=c++11` when reviewing #20471. The only difference in the output after this change is one line is missing:

  ```
  src/script/descriptor.cpp:159:5: warning: Struct 'PubkeyProvider' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  ```

  After some digging, I am still not sure why this one is ignored with c++17 when 40 other`noExplicitConstructor` warnings were still appearing.

  In the second commit, I fix these warnings, adding `explicit` where appropriate and adding fixes to ignore otherwise.

ACKs for top commit:
  practicalswift:
    cr ACK 1e62350ca20898189904a88dfef9ea11ddcd8626: patch looks correct!
  MarcoFalke:
    review ACK 1e62350ca20898189904a88dfef9ea11ddcd8626

Tree-SHA512: dff7b324429a57160e217cf38d9ddbb6e70c6cb3d3e3e0bd4013d88e07afc2292c3df94d0acf7122e9d486322821682ecf15c8f2724a78667764c05d47f89a12

2020-12-02 20:52:19 +08:00

..

test

Merge #15710: wallet: Catch ios_base::failure specifically

2020-11-19 12:32:48 +01:00

bdb.cpp

Determine wallet file type based on file magic

2020-10-14 11:28:18 -04:00

bdb.h

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

Refactor OutputGroups to handle effective values, fees, and filtering

2020-08-11 14:25:02 -04:00

coinselection.h

Refactor OutputGroups to handle effective values, fees, and filtering

2020-08-11 14:25:02 -04:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

refactor: Pass wallet database into CWallet::Create

2020-09-03 12:24:32 -04:00

db.h

rpc, wallet: Expose database format in getwalletinfo

2020-10-14 21:47:42 +01:00

feebumper.cpp

[send] Make send RPCs return fee reason

2020-09-26 17:57:26 -07:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Do not compile BDB things when USE_BDB is defined

2020-11-18 11:56:08 -05:00

interfaces.cpp

Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp

2020-11-24 10:20:16 -05:00

ismine.h

…

load.cpp

Ignoring (but warn) on duplicate -wallet parameters

2020-11-03 12:06:32 +01:00

load.h

Do not create default wallet

2020-09-08 21:02:53 -04:00

rpcdump.cpp

Merge #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet

2020-11-09 20:19:00 +01:00

rpcwallet.cpp

Merge #20448: RPC/Wallet: unloadwallet: Allow specifying wallet_name param matching RPC endpoint wallet

2020-11-28 10:14:45 +01:00

rpcwallet.h

Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)

2020-09-22 20:49:30 +02:00

salvage.cpp

Enforce salvage is only for BDB wallets

2020-11-18 11:56:12 -05:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

Merge #20403: wallet: upgradewallet fixes, improvements, test coverage

2020-11-25 12:46:27 +01:00

scriptpubkeyman.h

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

sqlite.cpp

Fix mock SQLiteDatabases

2020-11-18 11:56:12 -05:00

sqlite.h

rpc, wallet: Expose database format in getwalletinfo

2020-10-14 21:47:42 +01:00

wallet.cpp

Merge #19980: refactor: Some wallet cleanups

2020-12-02 08:23:00 +08:00

wallet.h

Merge #19980: refactor: Some wallet cleanups

2020-12-02 08:23:00 +08:00

walletdb.cpp

Merge #19980: refactor: Some wallet cleanups

2020-12-02 08:23:00 +08:00

walletdb.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

wallettool.cpp

Do not compile BDB things when USE_BDB is defined

2020-11-18 11:56:08 -05:00

wallettool.h

wallet: Remove path checking code from bitcoin-wallet tool

2020-09-03 12:24:32 -04:00

walletutil.cpp

Merge #20403: wallet: upgradewallet fixes, improvements, test coverage

2020-11-25 12:46:27 +01:00

walletutil.h

wallet: Add GetClosestWalletFeature function

2020-10-19 00:14:38 -04:00