bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00

Files

Andrew Chow c2d4e40e45 Merge bitcoin/bitcoin#28651 : Make miniscript GetWitnessSize accurate for tapscript

b22810887b miniscript: make GetWitnessSize accurate for tapscript (Pieter Wuille)
8be9851408 test: add tests for miniscript GetWitnessSize (Pieter Wuille)
7ed2b2d430 test: remove mutable global contexts in miniscript fuzzer/test (Pieter Wuille)

Pull request description:

  So far, the same algorithm is used to compute an (upper bound on) the maximum witness size for both P2WSH and P2TR miniscript. That's unfortunate, because it means fee estimations for P2TR miniscript will miss out on the generic savings brought by P2TR witnesses (smaller signatures and public keys, specifically).

  Fix this by making the algorithm use script context specification calculations, and add tests for it. Also included is a cleanup for the tests to avoid mutable globals, as I found it hard to reason about what exactly was being tested.

ACKs for top commit:
  achow101:
    ACK b22810887b
  darosior:
    ACK b22810887b

Tree-SHA512: e4bda7376628f3e91cfc74917cefc554ca16eb5f2a0e1adddc33eb8717c4aaa071e56a40f85a2041ae74ec445a7bd0129bba48994c203e0e6e4d25af65954d9e

2023-10-17 18:27:52 -04:00

bitcoinconsensus.cpp

lib: add Taproot support to libconsensus

2023-10-13 08:55:07 -03:00

bitcoinconsensus.h

lib: add Taproot support to libconsensus

2023-10-13 08:55:07 -03:00

descriptor.cpp

descriptors: Move InferScript's pubkey validity checks to InferPubkey

2023-10-09 14:07:37 -04:00

descriptor.h

wallet: accurately account for the size of the witness stack