fanquake e862bceb17

Merge bitcoin/bitcoin#27935: fuzz: call lookup functions before calling Ban ...

fca0a8938e34cb4f6c400e1d1d0be02f027d80c5 ci: remove "--exclude banman" for fuzzing in mac (brunoerg)
f9b286353f79cdb5e55e2ff4ca47d73e14f9da48 fuzz: call lookup functions before calling `Ban` (brunoerg)

Pull request description:

  Fixes #27924

  To not have any discrepancy, it's required to call lookup functions before calling `Ban`. If we don't do it, the assertion `assert(banmap == banmap_read);` may fail because `BanMapFromJson` will call `LookupSubNet` and cause the discrepancy between the banned and the loaded one. It happens especially in MacOS (#27924).

  Also, calling lookup functions before banning is what RPC `setban` does.

ACKs for top commit:
  maflcko:
    lgtm ACK fca0a8938e34cb4f6c400e1d1d0be02f027d80c5
  dergoegge:
    ACK fca0a8938e34cb4f6c400e1d1d0be02f027d80c5

Tree-SHA512: a3d635088a556df4507e65542157f10b41d4f87dce42927b58c3b812f262f4544b6b57f3384eef1097ffdd7c32b8dd1556aae201254960cbfbf48d45551200f7

2023-11-13 10:57:01 +00:00

..

00_setup_env_android.sh

ci: Add missing amd64 to win64-cross task

2023-08-18 14:23:17 +02:00

00_setup_env_arm.sh

ci: Use qemu-user through container engine

2023-08-07 17:36:14 +02:00

00_setup_env_i686_centos.sh

ci: enable chattr +i capability inside containers

2023-09-06 10:40:09 -04:00

00_setup_env_i686_multiprocess.sh

depends: Bump to capnproto-c++-1.0.1

2023-11-03 12:48:42 +01:00

00_setup_env_mac_native.sh

ci: remove "--exclude banman" for fuzzing in mac

2023-11-09 10:11:59 -03:00

00_setup_env_mac.sh

build: remove dmg dependencies

2023-09-15 13:47:50 +01:00

00_setup_env_native_asan.sh

ci: Bump asan

2023-10-12 13:07:06 +02:00

00_setup_env_native_fuzz_with_msan.sh

ci: Add missing docker.io prefix to CI_IMAGE_NAME_TAG

2023-08-23 22:33:02 +02:00

00_setup_env_native_fuzz_with_valgrind.sh

ci: Add missing docker.io prefix to CI_IMAGE_NAME_TAG

2023-08-23 22:33:02 +02:00

00_setup_env_native_fuzz.sh

fuzz: explicitly specify llvm-symbolizer path in runner

2023-11-07 16:57:23 +00:00

00_setup_env_native_msan.sh

ci: Add missing docker.io prefix to CI_IMAGE_NAME_TAG

2023-08-23 22:33:02 +02:00

00_setup_env_native_nowallet_libbitcoinkernel.sh

build: Bump minimum supported Clang to clang-13

2023-10-24 18:52:00 +02:00

00_setup_env_native_qt5.sh

Bump g++ minimum supported version to 10

2023-10-30 15:12:26 +01:00

00_setup_env_native_tidy.sh

ci: use LLVM/Clang 17 in tidy job

2023-10-10 11:02:10 +01:00

00_setup_env_native_tsan.sh

ci: clang-17 for fuzz and tsan

2023-09-13 13:35:39 +02:00

00_setup_env_native_valgrind.sh

ci: Add missing docker.io prefix to CI_IMAGE_NAME_TAG

2023-08-23 22:33:02 +02:00

00_setup_env_s390x.sh

ci: Remove unused TEST_RUNNER_ENV="LC_ALL=C" from s390x task

2023-08-27 22:50:42 +02:00

00_setup_env_win64.sh

ci: Add missing amd64 to win64-cross task

2023-08-18 14:23:17 +02:00

00_setup_env.sh

ci: enable chattr +i capability inside containers

2023-09-06 10:40:09 -04:00

01_base_install.sh

ci: Switch IWYU to clang_17 branch

2023-11-09 12:04:17 +00:00

02_run_container.sh

ci: Add missing --external to podman image prune

2023-10-23 14:10:12 +02:00

06_script_b.sh

ci: Add missing CI_RETRY_EXE before git clone

2023-10-13 10:37:34 +01:00

wrap-valgrind.sh

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

wrap-wine.sh

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00