bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-26 07:26:15 +01:00

Files

Ava Chow 228aba2c4d Merge bitcoin/bitcoin#31555 : descriptor: remove unreachable verification for pkh

366ae00b77 descriptor: Assume `ParseScript` is not being called with a P2WPKH context (brunoerg)
e366408590 descriptor: remove unreachable verification for `pkh` (brunoerg)

Pull request description:

  This PR removes an unreachable verification in the `ParseScript` function. It returns an error if `pkh` is not being used at top level, sh, wsh or tr. However, any usage of `pkh` without these contexts will not reach this verification but other ones like "invalid keys" (e.g. `wpkh(pkh(L4gM1FBdyHNpkzsFh9ipnofLhpZRp2mwobpeULy1a6dBTvw8Ywtd))`).

ACKs for top commit:
  davidgumberg:
    crACK 366ae00b77
  achow101:
    ACK 366ae00b77
  tdb3:
    cr ACK 366ae00b77
  sipa:
    crACK 366ae00b77

Tree-SHA512: b954221a77eed623aeed5eb54f14e82c49540a151d3388831924caa7a784e48a2a975e418af1e13d491e4f8cded3b1797aa39e0e4e39e302a991105df09cdec0

2024-12-30 16:40:11 -05:00

descriptor.cpp

descriptor: Assume ParseScript is not being called with a P2WPKH context

2024-12-24 11:01:47 -03:00

descriptor.h

descriptors: Change Parse to return vector of descriptors

2024-08-08 12:47:22 -04:00

interpreter.cpp

Fix unsigned integer overflows in interpreter

2024-10-01 10:45:44 +02:00

interpreter.h

interpreter: Use the same type for SignatureHash in the definition