Ava Chow 4f85b05131 Merge bitcoin/bitcoin#31713: miniscript refactor: Remove unique_ptr-indirection ...

964c44cdcd test(miniscript): Prove avoidance of stack overflow (Hodlinator)
198bbaee49 refactor(miniscript): Destroy nodes one full subs-vector at a time (Hodlinator)
50cab8570e refactor(miniscript): Remove NodeRef & MakeNodeRef() (Hodlinator)
15fb34de41 refactor(miniscript): Remove superfluous unique_ptr-indirection (Hodlinator)
e55b23c170 refactor(miniscript): Remove Node::subs mutability (Hodlinator)
c6f798b222 refactor(miniscript): Make fields non-const & private (Hodlinator)
22e4115312 doc(miniscript): Remove mention of shared pointers (Hodlinator)

Pull request description:

  Removes one level of unnecessary indirection, which was a change that originally [aided in finding one issue](https://github.com/bitcoin/bitcoin/pull/30866#pullrequestreview-2434704657) in #30866. Simplifies the code one step further than 09a1875ad8 belonging to aforementioned PR.

  Also adds test which verifies resistance to stack overflow when it comes to `~Node()` and `Node::Clone()`.

  No observed difference when running benchmarks: ExpandDescriptor/WalletIsMineDescriptors/WalletIsMineMigratedDescriptors/WalletLoadingDescriptors.

  Followup to #30866.

ACKs for top commit:
  achow101:
    ACK 964c44cdcd
  darosior:
    Code review ACK 964c44cdcd
  l0rinc:
    ACK 964c44cdcd

Tree-SHA512: 32927e8f0f916fb70372ffd110f7ec7207d9e7a099c21c0a7482a12e96593b673c339719f4ab166ad7c086dc43767315fc1742c5b236a3facc45c4cfeb5872e9

2026-01-30 15:17:59 -08:00

..

util

…

addition_overflow.cpp

…

addrman.cpp

…

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

…

base_encode_decode.cpp

…

bech32.cpp

…

bip324.cpp

…

bitdeque.cpp

…

bitset.cpp

…

block_header.cpp

…

block_index_tree.cpp

…

block_index.cpp

…

block.cpp

…

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

…

cluster_linearize.cpp

…

CMakeLists.txt

…

coins_view.cpp

…

coinscache_sim.cpp

…

connman.cpp

…

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

…

crypto_chacha20poly1305.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

…

difference_formatter.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

…

feeratediagram.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

…

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

…

headerssync.cpp

…

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

…

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

…

load_external_block_file.cpp

…

locale.cpp

…

merkle.cpp

…

merkleblock.cpp

…

message.cpp

…

mini_miner.cpp

…

miniscript.cpp

…

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

…

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

overflow.cpp

…

p2p_handshake.cpp

…

p2p_headers_presync.cpp

…

p2p_transport_serialization.cpp

…

package_eval.cpp

…

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

partially_downloaded_block.cpp

…

pcp.cpp

…

policy_estimator_io.cpp

…

policy_estimator.cpp

…

poolresource.cpp

…

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

…

process_messages.cpp

…

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

…

rolling_bloom_filter.cpp

…

rpc.cpp

…

script_assets_test_minimizer.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_parsing.cpp

…

script_sigcache.cpp

…

script_sign.cpp

…

script.cpp

…

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

…

span.cpp

…

string.cpp

…

strprintf.cpp

…

system.cpp

…

timeoffsets.cpp

…

torcontrol.cpp

…

transaction.cpp

…

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

…

txdownloadman.cpp

…

txgraph.cpp

…

txorphan.cpp

…

txrequest.cpp

…

util.cpp

…

util.h

…

utxo_snapshot.cpp

…

utxo_total_supply.cpp

…

validation_load_mempool.cpp

…

vecdeque.cpp

…

versionbits.cpp

…