Ryan Ofsky d0b928b29d Merge bitcoin/bitcoin#26312: Remove Sock::Get() and Sock::Sock() ...

7df4508369 test: improve sock_tests/move_assignment (Vasil Dimov)
5086a99b84 net: remove Sock default constructor, it's not necessary (Vasil Dimov)
7829272f78 net: remove now unnecessary Sock::Get() (Vasil Dimov)
944b21b70a net: don't check if the socket is valid in ConnectSocketDirectly() (Vasil Dimov)
aeac68d036 net: don't check if the socket is valid in GetBindAddress() (Vasil Dimov)
5ac1a51ee5 i2p: avoid using Sock::Get() for checking for a valid socket (Vasil Dimov)

Pull request description:

  _This is a piece of #21878, chopped off to ease review._

  Peeking at the underlying socket file descriptor of `Sock` and checkig if it is `INVALID_SOCKET` is bad encapsulation and stands in the way of testing/mocking/fuzzing.

  Instead use an empty `unique_ptr` to denote that there is no valid socket where appropriate or outright remove such checks where they are not necessary.

  The default constructor `Sock::Sock()` is unnecessary now after recent changes, thus remove it.

ACKs for top commit:
  ajtowns:
    ACK 7df4508369
  jonatack:
    ACK 7df4508369

Tree-SHA512: 9742aeeeabe8690530bf74caa6ba296787028c52f4a3342afd193b05dbbb1f6645935c33ba0a5230199a09af01c666bd3c7fb16b48692a0d185356ea59a8ddbf

2023-10-03 09:57:46 -04:00

..

mempool.cpp

mempool_entry: add mempool entry sequence number

2023-08-03 13:42:45 +10:00

mempool.h

refactor: Move txmempool_entry.h --> kernel/mempool_entry.h

2022-11-30 10:37:57 +00:00

net.cpp

Merge bitcoin/bitcoin#26312: Remove Sock::Get() and Sock::Sock()

2023-10-03 09:57:46 -04:00

net.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00