highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-04-07 14:18:18 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
1189702d2f496756bdb5e64777a457068fa1a111
bitcoin/src
History
Ava Chow 1189702d2f Merge bitcoin/bitcoin#34982: kernel: Remove NONNULL annotation from destroy method 
75608547b4 kernel: Remove NONNULL annotation from destroy method (Alexander Wiederin)

Pull request description:

  Follow-up to https://github.com/bitcoin/bitcoin/pull/33796#discussion_r2959817508

  ### Summary
  This PR removes the `BITCOINKERNEL_ARG_NONNULL` annotation from the `btck_block_validation_state_destroy` method in the Kernel API.

  ### Motivation
  No other *_destroy function in the Kernel API carries the NONNULL annotation. Following the convention set by free(), destroy functions should accept null pointers.

  ### Usage:
  Before:
  ```c
  btck_BlockValidationState* state = NULL;
  btck_block_validation_state_destroy(state); // violates nonnull contract
  ```

  After:
  ```c
  btck_BlockValidationState* state = NULL;
  btck_block_validation_state_destroy(state); // well-defined
  ```

ACKs for top commit:
  yuvicc:
    lgtm! ACK 75608547b4
  kevkevinpal:
    ACK [7560854](75608547b4)
  achow101:
    ACK 75608547b4
  janb84:
    ACK 75608547b4
  theStack:
    ACK 75608547b4
  w0xlt:
    ACK 75608547b4
  stickies-v:
    ACK 75608547b4

Tree-SHA512: 9577098940f49b8f7fd1fb20afe750e9eaaf9d90d25ec3c4f423de223a1fbd0bca6d520061f576eb3923f18e1f2744b3f60d0d0715dfa3832fea83cb538170c2
2026-04-01 11:34:13 -07:00
..
bench
Merge bitcoin/bitcoin#34926: test: Replace DEBUG_LOG_OUT with -printtoconsole=1
2026-03-28 14:44:16 +08:00
common
Merge bitcoin/bitcoin#34684: refactor: Enable -Wswitch in exhaustive switch'es, Enable -Wcovered-switch-default
2026-03-19 14:15:38 -07:00
compat
…
consensus
…
crc32c
…
crypto
…
index
Merge bitcoin/bitcoin#32875: index: handle case where pindex_prev equals chain tip in NextSyncBlock()
2026-03-30 20:01:40 +08:00
init
Merge bitcoin/bitcoin#32297: bitcoin-cli: Add -ipcconnect option
2026-03-30 15:12:04 -07:00
interfaces
Merge bitcoin/bitcoin#32297: bitcoin-cli: Add -ipcconnect option
2026-03-30 15:12:04 -07:00
ipc
Merge bitcoin/bitcoin#32297: bitcoin-cli: Add -ipcconnect option
2026-03-30 15:12:04 -07:00
kernel
Merge bitcoin/bitcoin#34982: kernel: Remove NONNULL annotation from destroy method
2026-04-01 11:34:13 -07:00
leveldb
…
logging
…
minisketch
…
node
Merge bitcoin/bitcoin#32297: bitcoin-cli: Add -ipcconnect option
2026-03-30 15:12:04 -07:00
policy
policy: remove incorrect MANDATORY_SCRIPT_VERIFY_FLAGS comment
2026-03-30 15:10:53 +01:00
primitives
serialize: Add missing <span> header
2026-03-19 19:13:40 +00:00
qt
Merge bitcoin/bitcoin#34049: rpc: Disallow captures in RPCMethodImpl
2026-04-01 00:08:28 +08:00
rpc
Merge bitcoin/bitcoin#34049: rpc: Disallow captures in RPCMethodImpl
2026-04-01 00:08:28 +08:00
script
Merge bitcoin/bitcoin#34684: refactor: Enable -Wswitch in exhaustive switch'es, Enable -Wcovered-switch-default
2026-03-19 14:15:38 -07:00
secp256k1
…
support
…
test
Merge bitcoin/bitcoin#33506: test: sock: Enable all socket tests on Windows
2026-04-01 11:22:40 -07:00
univalue
refactor: Return std::optional from ParseDouble
2026-03-30 09:03:06 +02:00
util
util/stdmutex.h: Add STDLOCK() and improve annotation checking for StdMutex
2026-03-23 15:01:57 +10:00
wallet
Merge bitcoin/bitcoin#34640: wallet: rpc: Improve error message for low feerates.
2026-03-31 11:38:44 -07:00
zmq
scripted-diff: rpc: Don't pointlessly capture in RPCMethod lambdas
2026-03-25 19:18:11 +10:00
.clang-format
…
.clang-tidy
…
addrdb.cpp
…
addrdb.h
…
addresstype.cpp
…
addresstype.h
…
addrman_impl.h
…
addrman.cpp
Merge bitcoin/bitcoin#34602: test: addrman: successive failures in the last week for IsTerrible
2026-03-16 22:29:38 +01:00
addrman.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge bitcoin/bitcoin#32297: bitcoin-cli: Add -ipcconnect option
2026-03-30 15:12:04 -07:00
bitcoin-res.rc
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
…
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoin.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
…
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
chain.cpp
…
chain.h
…
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
cluster_linearize.h
…
CMakeLists.txt
…
coins.cpp
…
coins.h
…
compressor.cpp
…
compressor.h
…
core_io.cpp
…
core_io.h
…
core_memusage.h
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
…
flatfile.h
…
hash.cpp
…
hash.h
…
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
…
httpserver.h
…
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#33343: help: enrich help text for -loadblock
2026-04-01 08:15:54 +08:00
init.h
…
key_io.cpp
…
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
refactor: Return std::optional from GetLogCategory
2026-03-30 09:03:03 +02:00
logging.h
refactor: Return std::optional from GetLogCategory
2026-03-30 09:03:03 +02:00
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
musig.cpp
…
musig.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
refactor: Use current_time over redundant call to Now()
2026-03-20 07:12:22 +01:00
net_processing.h
iwyu, doc: Document IWYU pragma: export for <threadsafety.h>
2026-03-20 15:37:51 +00:00
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#34741: refactor: Return std::optional from GetNameProxy/GetProxy
2026-03-26 11:38:14 -07:00
net.h
…
netaddress.cpp
…
netaddress.h
…
netbase.cpp
…
netbase.h
…
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
private_broadcast.cpp
…
private_broadcast.h
iwyu, doc: Document IWYU pragma: export for <threadsafety.h>
2026-03-20 15:37:51 +00:00
protocol.cpp
…
protocol.h
…
psbt.cpp
refactor: Enable -Wswitch in exhaustive switch
2026-03-13 09:02:09 +01:00
psbt.h
…
pubkey.cpp
…
pubkey.h
…
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
scripted-diff: rpc: Rename RPCHelpMan to RPCMethod
2026-03-25 19:18:10 +10:00
rest.h
…
scheduler.cpp
…
scheduler.h
iwyu, doc: Document IWYU pragma: export for <threadsafety.h>
2026-03-20 15:37:51 +00:00
semaphore_grant.h
…
serialize.h
serialize: Add missing <span> header
2026-03-19 19:13:40 +00:00
signet.cpp
…
signet.h
…
span.h
…
streams.cpp
…
streams.h
…
sync.cpp
sync: Use StdMutex for thread safety annotations
2026-03-23 15:13:45 +10:00
sync.h
iwyu, doc: Document IWYU pragma: export for <threadsafety.h>
2026-03-20 15:37:51 +00:00
threadsafety.h
refactor: Move StdMutex to its own header
2026-03-20 15:37:44 +00:00
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
…
txdb.h
…
txgraph.cpp
…
txgraph.h
…
txmempool.cpp
…
txmempool.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#34786: validation: do not add the snapshot to candidates set of the background chainstate
2026-03-24 14:58:05 -07:00
validation.h
log: update progress calculations for background validation
2026-03-24 15:51:23 +01:00
validationinterface.cpp
validation: Move block into BlockDisconnected signal
2026-03-18 13:34:26 +01:00
validationinterface.h
validation: Move block into BlockDisconnected signal
2026-03-18 13:34:26 +01:00
versionbits_impl.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…