Jonas Schnelli 25c56cdbe7 Merge #12878: [refactor] Config handling refactoring in preparation for network-specific sections ...

77a733a99 [tests] Add additional unit tests for -nofoo edge cases (Anthony Towns)
af173c2be [tests] Check GetChainName works with config entries (Anthony Towns)
fa27f1c23 [tests] Add unit tests for ReadConfigStream (Anthony Towns)
087c5d204 ReadConfigStream: assume the stream is good (Anthony Towns)
6d5815aad Separate out ReadConfigStream from ReadConfigFile (Anthony Towns)
834d30341 [tests] Add unit tests for GetChainName (Anthony Towns)
11b6b5b86 Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName (Anthony Towns)

Pull request description:

  This does a bit of refactoring of the configuration handling code in order to add additional tests to make adding support for [test]/[regtest] sections in the config file in #11862 easier. Should not cause any behaviour changes.

Tree-SHA512: 8d2ce1449fc180de03414e7e569d1a21ba1e9f6564e13d3faf3961f710adc725fa0d4ab49b89ebd2baa11ea36ac5018377f693a84037d386a8b8697c9d6db3e9

2018-04-08 16:24:30 +02:00

..

bench

[moveonly] Extract HelpRequested to dry up the help options testing

2018-04-02 15:42:06 -07:00

compat

…

config

…

consensus

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

crypto

Consensus: Fix bug when compiler do not support __builtin_clz*

2018-03-01 17:20:27 +08:00

interfaces

scripted-diff: Avoid interface keyword to fix windows gitian build

2018-04-07 03:42:02 -04:00

leveldb

Bump leveldb subtree

2018-02-16 08:59:28 -05:00

obj

…

obj-test

…

policy

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

primitives

Merge #10498: Use static_cast instead of C-style casts for non-fundamental types

2018-02-07 16:15:28 -05:00

qt

Merge #12878: [refactor] Config handling refactoring in preparation for network-specific sections

2018-04-08 16:24:30 +02:00

rpc

Merge #12860: Add testmempoolaccept to release-notes, Add missing const

2018-04-07 18:43:39 +02:00

script

Merge #12167: Make segwit failure due to CLEANSTACK violation return a SCRIPT_ERR_CLEANSTACK error code

2018-04-04 17:30:24 -07:00

secp256k1

…

support

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

test

[tests] Add additional unit tests for -nofoo edge cases

2018-04-06 04:46:39 +10:00

univalue

univalue: Bump subtree

2018-02-10 09:55:54 -05:00

wallet

Merge #12891: [logging] add lint-logs.sh to check for newline termination.

2018-04-08 11:04:49 +02:00

zmq

…

.clang-format

…

addrdb.cpp

Add native support for serializing char arrays without FLATDATA

2018-03-21 14:14:04 -07:00

addrdb.h

…

addrman.cpp

net: Correct addrman logging

2018-03-06 21:52:53 +01:00

addrman.h

Fix typos

2018-03-21 10:54:17 +01:00

amount.h

…

arith_uint256.cpp

…

arith_uint256.h

[arith_uint256] Avoid unnecessary this-copy using prefix operator

2018-02-28 19:59:19 +09:00

base58.cpp

use base58 map instead of strchr()

2018-03-21 11:57:57 +08:00

base58.h

Split key_io (address/key encodings) off from base58

2018-02-19 18:55:21 -08:00

bech32.cpp

…

bech32.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName

2018-04-06 04:46:02 +10:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName

2018-04-06 04:46:02 +10:00

bitcoind-res.rc

…

bitcoind.cpp

Merge #12878: [refactor] Config handling refactoring in preparation for network-specific sections

2018-04-08 16:24:30 +02:00

blockencodings.cpp

…

blockencodings.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

bloom.cpp

…

bloom.h

…

chain.cpp

…

chain.h

Add static_assert to prevent VARINT(<signed value>)

2018-03-15 18:57:55 -05:00

chainparams.cpp

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

chainparams.h

Disable wallet fallbackfee by default on mainnet

2018-02-25 09:33:46 +08:00

chainparamsbase.cpp

Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName

2018-04-06 04:46:02 +10:00

chainparamsbase.h

Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName

2018-04-06 04:46:02 +10:00

chainparamsseeds.h

Fix a-vs-an typos

2018-02-11 10:48:15 +01:00

checkpoints.cpp

Add LookupBlockIndex function

2018-03-06 19:52:19 +00:00

checkpoints.h

Add LookupBlockIndex function

2018-03-06 19:52:19 +00:00

checkqueue.h

…

clientversion.cpp

Merge #11966: clientversion: Use full commit hash for commit-based version descriptions

2018-02-13 10:58:41 +01:00

clientversion.h

…

coins.cpp

…

coins.h

Support deserializing into temporaries

2018-03-13 17:04:31 -07:00

compat.h

Add new prevector benchmarks.

2018-02-27 11:42:06 -08:00

compressor.cpp

Move compressor utility functions out of class

2018-03-21 14:17:18 -07:00

compressor.h

Move compressor utility functions out of class

2018-03-21 14:17:18 -07:00

core_io.h

…

core_memusage.h

…

core_read.cpp

Merge #10498: Use static_cast instead of C-style casts for non-fundamental types

2018-02-07 16:15:28 -05:00

core_write.cpp

Fix typos

2018-03-21 08:34:44 +02:00

cuckoocache.h

Fix typos

2018-03-21 08:34:44 +02:00

dbwrapper.cpp

[logging] Comment all continuing logs.

2018-04-07 12:29:48 -04:00

dbwrapper.h

Add DynamicMemoryUsage() to LevelDB

2018-03-06 00:25:39 -05:00

fs.cpp

…

fs.h

…

hash.cpp

…

hash.h

Support deserializing into temporaries

2018-03-13 17:04:31 -07:00

httprpc.cpp

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

httprpc.h

…

httpserver.cpp

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

httpserver.h

…

indirectmap.h

…

init.cpp

Merge #12891: [logging] add lint-logs.sh to check for newline termination.

2018-04-08 11:04:49 +02:00

init.h

wallet: Refactor to WalletInitInterface* const g_wallet_init_interface

2018-04-05 21:09:22 +01:00

key_io.cpp

Simplify Base32 and Base64 conversions

2018-03-07 07:04:07 -08:00

key_io.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

key.cpp

Merge #9598: Improve readability by removing redundant casts to same type (on all platforms)

2018-03-07 17:47:46 +01:00

key.h

…

keystore.cpp

Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size

2018-04-04 17:50:32 -04:00

keystore.h

Merge #12762: Make CKeyStore an interface

2018-03-27 20:42:49 +02:00

limitedmap.h

…

Makefile.am

Merge #12906: Avoid interface keyword to fix windows gitian build

2018-04-07 15:19:47 -04:00

Makefile.bench.include

Add new prevector benchmarks.

2018-02-27 11:42:06 -08:00

Makefile.leveldb.include

…

Makefile.qt.include

Remove direct bitcoin calls from qt/splashscreen.cpp

2018-04-04 16:52:40 -04:00

Makefile.qttest.include

Remove direct bitcoin calls from qt/splashscreen.cpp

2018-04-04 16:52:40 -04:00

Makefile.test.include

tests: Avoid test suite name collision in wallet crypto_tests

2018-04-06 16:29:14 +02:00

memusage.h

Bugfix: Include <memory> for std::unique_ptr

2018-04-02 18:31:52 +00:00

merkleblock.cpp

…

merkleblock.h

…

miner.cpp

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

miner.h

Remove unused variable in SortForBlock

2018-03-14 23:10:39 -07:00

net_processing.cpp

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

net_processing.h

Remove direct bitcoin calls from qt/peertablemodel.cpp

2018-04-04 16:52:40 -04:00

net.cpp

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

net.h

Polish interfaces around PeerLogicValidation

2018-03-14 10:11:01 +01:00

netaddress.cpp

Merge #10498: Use static_cast instead of C-style casts for non-fundamental types

2018-02-07 16:15:28 -05:00

netaddress.h

Add native support for serializing char arrays without FLATDATA

2018-03-21 14:14:04 -07:00

netbase.cpp

Remove redundant checks for MSG_* from configure.ac

2018-03-15 20:02:00 +01:00

netbase.h

…

netmessagemaker.h

…

noui.cpp

…

noui.h

…

pow.cpp

…

pow.h

…

prevector.h

Use memset() to optimize prevector::resize()

2018-02-27 13:27:51 -08:00

protocol.cpp

Add setter for g_initial_block_download_completed

2018-02-17 21:28:50 +11:00

protocol.h

Add native support for serializing char arrays without FLATDATA

2018-03-21 14:14:04 -07:00

pubkey.cpp

…

pubkey.h

Assert CPubKey::ValidLength to the pubkey's header-relevent size

2018-02-16 12:30:26 -08:00

random.cpp

…

random.h

Merge #12742: Make FastRandomContext support standard C++11 RNG interface

2018-03-22 12:21:46 -04:00

rest.cpp

Merge #12717: [REST] Handle UTXO retrieval when ignoring the mempool

2018-03-27 21:32:02 +02:00

reverse_iterator.h

…

reverselock.h

…

scheduler.cpp

…

scheduler.h

…

serialize.h

Add native support for serializing char arrays without FLATDATA

2018-03-21 14:14:04 -07:00

streams.h

Support deserializing into temporaries

2018-03-13 17:04:31 -07:00

sync.cpp

[logging] Comment all continuing logs.

2018-04-07 12:29:48 -04:00

sync.h

…

threadinterrupt.cpp

…

threadinterrupt.h

…

threadsafety.h

…

timedata.cpp

…

timedata.h

…

tinyformat.h

Fix typos

2018-03-21 08:34:44 +02:00

torcontrol.cpp

boost: drop boost threads from torcontrol

2018-02-08 14:35:29 -05:00

torcontrol.h

boost: drop boost threads from torcontrol

2018-02-08 14:35:29 -05:00

txdb.cpp

[logging] Comment all continuing logs.

2018-04-07 12:29:48 -04:00

txdb.h

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

txmempool.cpp

Merge #11742: rpc: Add testmempoolaccept

2018-04-02 16:02:33 +02:00

txmempool.h

Merge #11742: rpc: Add testmempoolaccept

2018-04-02 16:02:33 +02:00

ui_interface.cpp

…

ui_interface.h

…

uint256.cpp

…

uint256.h

…

undo.h

Merge #12716: Fix typos and cleanup in various files

2018-03-21 11:17:43 -04:00

util.cpp

Merge #12878: [refactor] Config handling refactoring in preparation for network-specific sections

2018-04-08 16:24:30 +02:00

util.h

Merge #12878: [refactor] Config handling refactoring in preparation for network-specific sections

2018-04-08 16:24:30 +02:00

utilmoneystr.cpp

…

utilmoneystr.h

…

utilstrencodings.cpp

Simplify Base32 and Base64 conversions

2018-03-07 07:04:07 -08:00

utilstrencodings.h

Generalize ConvertBits

2018-03-06 20:28:08 -08:00

utiltime.cpp

Format timestamps using ISO 8601 formatting (e.g. "2018-02-28T12:34:56Z")

2018-03-09 15:02:01 +01:00

utiltime.h

Format timestamps using ISO 8601 formatting (e.g. "2018-02-28T12:34:56Z")

2018-03-09 15:02:01 +01:00

validation.cpp

Merge #12561: Check for block corruption in ConnectBlock()

2018-04-08 11:08:43 +02:00

validation.h

Merge #12859: Bugfix: Include <memory> for std::unique_ptr

2018-04-05 09:31:53 +02:00

validationinterface.cpp

…

validationinterface.h

Polish interfaces around PeerLogicValidation

2018-03-14 10:11:01 +01:00

version.h

…

versionbits.cpp

scripted-diff: Convert 11 enums into scoped enums (C++11)

2018-03-09 15:03:40 +01:00

versionbits.h

Merge #12757: Clarify include guard naming convention

2018-04-01 18:30:21 -04:00

walletinitinterface.h

wallet: Make WalletInitInterface and DummyWalletInit private

2018-04-05 21:09:21 +01:00

warnings.cpp

…

warnings.h

…