mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-27 07:55:39 +01:00

Files

W. J. van der Laan 12eda278ac Merge bitcoin/bitcoin#23288 : tests: remove usage of LegacyScriptPubKeyMan from some wallet tests

2d2edc1248 tests: Use Descriptor wallets for generic wallet tests (Andrew Chow)
99516285b7 tests: Use legacy change type in subtract fee from outputs test (Andrew Chow)
dcd6eeb64a tests: Use descriptors in psbt_wallet_tests (Andrew Chow)
4b1588c6bd tests: Use DescriptorScriptPubKeyMan in coinselector_tests (Andrew Chow)
811319fea4 tests, gui: Use DescriptorScriptPubKeyMan in GUI tests (Andrew Chow)
9bf0243872 bench: Use DescriptorScriptPubKeyMan for wallet things (Andrew Chow)
5e54aa9b90 bench: remove global testWallet from CoinSelection benchmark (Andrew Chow)
a5595b1320 tests: Remove global vCoins and testWallet from coinselector_tests (Andrew Chow)

Pull request description:

  Currently, various tests use `LegacyScriptPubKeyMan` because it was convenient for the refactor that introduced the `ScriptPubKeyMan` interface. However, with the legacy wallet slated to be removed, these tests should not continue to use `LegacyScriptPubKeyMan` as they are not testing any specific legacy wallet behavior. These tests are changed to use `DescriptorScriptPubKeyMan`s.

  Some of the coin selection tests and benchmarks had a global `testWallet`, but this seemed to cause some issues with ensuring that descriptors were set up in that wallet for each test. Those have been restructured to not have any global variables that may be modified between tests.

  The tests which test specific legacy wallet behavior remain unchanged.

ACKs for top commit:
  laanwj:
    Code review ACK 2d2edc1248
  brunoerg:
    tACK 2d2edc1248

Tree-SHA512: 6d60e5978e822d48e46cfc0dae4635fcb1939f21ea9d84eb72e36112e925554b7ee8f932c7ed0c4881b6566c6c19260bec346abdff1956ca9f300b30fb4e2dd1

2021-10-22 15:14:07 +02:00

blockfilter.cpp

…

blockfilter.h

…

chainstate.h

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

logging.cpp

…

logging.h

…

mining.cpp

test/util: Use existing chainman in ::PrepareBlock

2021-06-10 15:04:39 -04:00

mining.h

…

net.cpp

refactor: move GetRandomNodeEvictionCandidates() to test utilities

2021-07-06 17:28:15 +02:00

net.h

p2p: Use mocktime for ping timeout

2021-10-07 13:22:02 +02:00

README.md

…

script.cpp

…

script.h

…

setup_common.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

setup_common.h

Merge bitcoin/bitcoin#22818 : test: Activate all regtest softforks at height 1, unless overridden

2021-09-24 14:04:51 +02:00

str.cpp

…

str.h

…

transaction_utils.cpp

…

transaction_utils.h

…

validation.cpp

…

validation.h

…

wallet.cpp

bench: Use DescriptorScriptPubKeyMan for wallet things

2021-10-15 15:23:07 -04:00

wallet.h

…

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).