mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-04-06 05:37:50 +02:00
81bf3ebff7
faf71d6cb4test: [refactor] Use verbosity=0 named arg (MarcoFalke)99996f6c06test: Fix intermittent issue in feature_assumeutxo.py (MarcoFalke) Pull request description: The test has many issues: * It fails intermittently, due to the use of `-stopatheight` (https://github.com/bitcoin/bitcoin/issues/33635) * Using `-stopatheight` is expensive, because it requires two restarts, making the test slow Fix all issues by using `dumb_sync_blocks` and avoid the two restarts. Fixes https://github.com/bitcoin/bitcoin/issues/33635 Diff to test: ```diff diff --git a/src/util/tokenpipe.cpp b/src/util/tokenpipe.cpp index c982fa6fc4..1dc12ea1d5 100644 --- a/src/util/tokenpipe.cpp +++ b/src/util/tokenpipe.cpp @@ -4,2 +4,3 @@ #include <util/tokenpipe.h> +#include <util/time.h> @@ -60,2 +61,3 @@ int TokenPipeEnd::TokenRead() ssize_t result = read(m_fd, &token, 1); + UninterruptibleSleep(999ms); if (result < 0) { ``` On master: Test fails On this pull: Test passes ACKs for top commit: fjahr: Code review ACKfaf71d6cb4sedited: ACKfaf71d6cb4Tree-SHA512: 8f7705d2b3f17881134d6e696207fe6710d7c4766f1b74edf5a40b4a6eb5e0f4b12be1adfabe56934d27abc46e789437526bcdd26e4f8172f41a11bc6bed8605