mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-21 07:39:08 +01:00
743abbcbderefactor: inline constant return value of `BlockTreeDB::WriteBatchSync` and `BlockManager::WriteBlockIndexDB` and `BlockTreeDB::WriteFlag` (Lőrinc)e030240e90refactor: inline constant return value of `CDBWrapper::Erase` and `BlockTreeDB::WriteReindexing` (Lőrinc)cdab9480e9refactor: inline constant return value of `CDBWrapper::Write` (Lőrinc)d1847cf5b5refactor: inline constant return value of `TxIndex::DB::WriteTxs` (Lőrinc)50b63a5698refactor: inline constant return value of `CDBWrapper::WriteBatch` (Lőrinc) Pull request description: Related to https://github.com/bitcoin/bitcoin/pull/31144#discussion_r2223587480 ### Summary `WriteBatch` always returns `true` - the errors are handled by throwing `dbwrapper_error` instead. ### Context This boolean return value of the `Write` methods is confusing because it's inconsistent with `CDBWrapper::Read`, which catches exceptions and returns a boolean to indicate success/failure. It's bad that `Read` returns and `Write` throws - but it's a lot worse that `Write` advertises a return value when it actually communicates errors through exceptions. ### Solution This PR removes the constant return values from write methods and inlines `true` at their call sites. Many upstream methods had boolean return values only because they were propagating these constants - those have been cleaned up as well. Methods that returned a constant `true` value that now return `void`: - `CDBWrapper::WriteBatch`, `CDBWrapper::Write`, `CDBWrapper::Erase` - `TxIndex::DB::WriteTxs` - `BlockTreeDB::WriteReindexing`, `BlockTreeDB::WriteBatchSync`, `BlockTreeDB::WriteFlag` - `BlockManager::WriteBlockIndexDB` ### Note `CCoinsView::BatchWrite` (and transitively `CCoinsViewCache::Flush` & `CCoinsViewCache::Sync`) were intentionally not changed here. While all implementations return `true`, the base `CCoinsView::BatchWrite` returns `false`. Changing this would cause `coins_view` tests to fail with: > terminating due to uncaught exception of type std::logic_error: Not all unspent flagged entries were cleared We can fix that in a follow-up PR. ACKs for top commit: achow101: ACK743abbcbdejanb84: ACK743abbcbdeTheCharlatan: ACK743abbcbdesipa: ACK743abbcbdeTree-SHA512: b2a550bff066216f1958d2dd9a7ef6a9949de518cc636f8ab9c670e0b7a330c1eb8c838e458a8629acb8ac980cea6616955cd84436a7b8ab9096f6d648073b1e
123 lines
3.6 KiB
C++
123 lines
3.6 KiB
C++
// Copyright (c) 2017-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <index/txindex.h>
|
|
|
|
#include <common/args.h>
|
|
#include <dbwrapper.h>
|
|
#include <flatfile.h>
|
|
#include <index/base.h>
|
|
#include <index/disktxpos.h>
|
|
#include <interfaces/chain.h>
|
|
#include <logging.h>
|
|
#include <node/blockstorage.h>
|
|
#include <primitives/block.h>
|
|
#include <primitives/transaction.h>
|
|
#include <serialize.h>
|
|
#include <streams.h>
|
|
#include <uint256.h>
|
|
#include <util/fs.h>
|
|
#include <validation.h>
|
|
|
|
#include <cassert>
|
|
#include <cstdint>
|
|
#include <cstdio>
|
|
#include <exception>
|
|
#include <iterator>
|
|
#include <span>
|
|
#include <string>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
constexpr uint8_t DB_TXINDEX{'t'};
|
|
|
|
std::unique_ptr<TxIndex> g_txindex;
|
|
|
|
|
|
/** Access to the txindex database (indexes/txindex/) */
|
|
class TxIndex::DB : public BaseIndex::DB
|
|
{
|
|
public:
|
|
explicit DB(size_t n_cache_size, bool f_memory = false, bool f_wipe = false);
|
|
|
|
/// Read the disk location of the transaction data with the given hash. Returns false if the
|
|
/// transaction hash is not indexed.
|
|
bool ReadTxPos(const Txid& txid, CDiskTxPos& pos) const;
|
|
|
|
/// Write a batch of transaction positions to the DB.
|
|
void WriteTxs(const std::vector<std::pair<Txid, CDiskTxPos>>& v_pos);
|
|
};
|
|
|
|
TxIndex::DB::DB(size_t n_cache_size, bool f_memory, bool f_wipe) :
|
|
BaseIndex::DB(gArgs.GetDataDirNet() / "indexes" / "txindex", n_cache_size, f_memory, f_wipe)
|
|
{}
|
|
|
|
bool TxIndex::DB::ReadTxPos(const Txid& txid, CDiskTxPos& pos) const
|
|
{
|
|
return Read(std::make_pair(DB_TXINDEX, txid.ToUint256()), pos);
|
|
}
|
|
|
|
void TxIndex::DB::WriteTxs(const std::vector<std::pair<Txid, CDiskTxPos>>& v_pos)
|
|
{
|
|
CDBBatch batch(*this);
|
|
for (const auto& [txid, pos] : v_pos) {
|
|
batch.Write(std::make_pair(DB_TXINDEX, txid.ToUint256()), pos);
|
|
}
|
|
WriteBatch(batch);
|
|
}
|
|
|
|
TxIndex::TxIndex(std::unique_ptr<interfaces::Chain> chain, size_t n_cache_size, bool f_memory, bool f_wipe)
|
|
: BaseIndex(std::move(chain), "txindex"), m_db(std::make_unique<TxIndex::DB>(n_cache_size, f_memory, f_wipe))
|
|
{}
|
|
|
|
TxIndex::~TxIndex() = default;
|
|
|
|
bool TxIndex::CustomAppend(const interfaces::BlockInfo& block)
|
|
{
|
|
// Exclude genesis block transaction because outputs are not spendable.
|
|
if (block.height == 0) return true;
|
|
|
|
assert(block.data);
|
|
CDiskTxPos pos({block.file_number, block.data_pos}, GetSizeOfCompactSize(block.data->vtx.size()));
|
|
std::vector<std::pair<Txid, CDiskTxPos>> vPos;
|
|
vPos.reserve(block.data->vtx.size());
|
|
for (const auto& tx : block.data->vtx) {
|
|
vPos.emplace_back(tx->GetHash(), pos);
|
|
pos.nTxOffset += ::GetSerializeSize(TX_WITH_WITNESS(*tx));
|
|
}
|
|
m_db->WriteTxs(vPos);
|
|
return true;
|
|
}
|
|
|
|
BaseIndex::DB& TxIndex::GetDB() const { return *m_db; }
|
|
|
|
bool TxIndex::FindTx(const Txid& tx_hash, uint256& block_hash, CTransactionRef& tx) const
|
|
{
|
|
CDiskTxPos postx;
|
|
if (!m_db->ReadTxPos(tx_hash, postx)) {
|
|
return false;
|
|
}
|
|
|
|
AutoFile file{m_chainstate->m_blockman.OpenBlockFile(postx, true)};
|
|
if (file.IsNull()) {
|
|
LogError("OpenBlockFile failed");
|
|
return false;
|
|
}
|
|
CBlockHeader header;
|
|
try {
|
|
file >> header;
|
|
file.seek(postx.nTxOffset, SEEK_CUR);
|
|
file >> TX_WITH_WITNESS(tx);
|
|
} catch (const std::exception& e) {
|
|
LogError("Deserialize or I/O error - %s", e.what());
|
|
return false;
|
|
}
|
|
if (tx->GetHash() != tx_hash) {
|
|
LogError("txid mismatch");
|
|
return false;
|
|
}
|
|
block_hash = header.GetHash();
|
|
return true;
|
|
}
|