fanquake a70911492f Merge bitcoin/bitcoin#26749: refactor: Use move semantics instead of custom swap functions ...

95ad70ab65 test: Default initialize `should_freeze` to `true` (Hennadii Stepanov)
cea50521fe refactor: Drop no longer used `swap` member functions (Hennadii Stepanov)
a87fb6bee5 clang-tidy: Fix modernize-use-default-member-init in `CScriptCheck` (Hennadii Stepanov)
b4bed5c1f9 refactor: Drop no longer used `CScriptCheck()` default constructor (Hennadii Stepanov)
d8427cc28e refactor: Use move semantics in `CCheckQueue::Loop` (Hennadii Stepanov)
9a0b524139 clang-tidy, test: Fix bugprone-use-after-move in `Correct_Queue_range()` (Hennadii Stepanov)
04831fee6d refactor: Make move semantics explicit for callers (Hennadii Stepanov)
6c2d5972f3 refactor: Use move semantics in `CCheckQueue::Add` (Hennadii Stepanov)
0682003214 test, refactor: Avoid `CScriptCheck::swap` in `transaction_tests` (Hennadii Stepanov)
15209d97c6 consensus, refactor: Avoid `CScriptCheck::swap` in `CheckInputScripts` (Hennadii Stepanov)

Pull request description:

  This PR makes code more succinct and readable by using move semantics.

ACKs for top commit:
  martinus:
    re-ACK 95ad70ab65
  achow101:
    ACK 95ad70ab65
  TheCharlatan:
    re-ACK 95ad70ab65
  MarcoFalke:
    re-ACK 95ad70ab65 🚥

Tree-SHA512: adda760891b12d252dc9b823fe7c41eed660364b6fb1a69f17607d7a31eb0bbb82a80d154a7acfaa241b5de37d42a293c2b6e059f26a8e92d88d3a87c99768fb

2023-03-22 11:16:56 +00:00

..

util

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

addition_overflow.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

addrman.cpp

addrman, refactor: combine two size functions

2023-01-26 18:11:13 -05:00

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

banman.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

base_encode_decode.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

bech32.cpp

…

bitdeque.cpp

fuzz: Avoid timeout in bitdeque fuzz target

2022-09-05 15:38:33 +02:00

block_header.cpp

…

block.cpp

Adapt to libsecp256k1 API changes

2022-12-13 15:08:24 -05:00

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

chain.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

checkqueue.cpp

refactor: Use move semantics in CCheckQueue::Loop

2023-03-21 13:04:21 +00:00

coins_view.cpp

Add deterministic mode to CCoinsViewCache

2023-02-02 09:00:15 -05:00

coinscache_sim.cpp

Exercise non-DIRTY spent coins in caches in fuzz test

2023-02-03 10:33:31 -05:00

connman.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20_poly1305_aead.cpp

…

crypto_chacha20.cpp

Only support 32-byte keys in ChaCha20{,Aligned}

2023-01-30 18:12:21 -05:00

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

Inline ChaCha20 32-byte specific constants

2023-01-30 18:12:21 -05:00

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

Adapt to libsecp256k1 API changes

2022-12-13 15:08:24 -05:00

deserialize.cpp

Adapt to libsecp256k1 API changes

2022-12-13 15:08:24 -05:00

eval_script.cpp

Adapt to libsecp256k1 API changes

2022-12-13 15:08:24 -05:00

fee_rate.cpp

…

fees.cpp

…

flatfile.cpp

Refactor: Remove unused FlatFilePos::SetNull

2023-03-21 13:54:11 +01:00

float.cpp

…

fuzz.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

hex.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

http_request.cpp

Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming

2023-02-17 13:34:40 -05:00

i2p.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

integer.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

key_io.cpp

Adapt to libsecp256k1 API changes

2022-12-13 15:08:24 -05:00

key.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

kitchen_sink.cpp

…

load_external_block_file.cpp

refactor: Make mapBlocksUnknownParent local, and rename it

2022-07-18 12:06:14 -06:00

locale.cpp

…

merkleblock.cpp

…

message.cpp

Adapt to libsecp256k1 API changes

2022-12-13 15:08:24 -05:00

miniscript.cpp

Fixed a couple of typos in comments to make linter happy

2023-03-03 19:06:02 -03:00

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

net.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

netaddress.cpp

Merge bitcoin/bitcoin#25619: net: avoid overriding non-virtual ToString() in CService and use better naming

2023-02-17 13:34:40 -05:00

netbase_dns_lookup.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

node_eviction.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

p2p_transport_serialization.cpp

refactor: use braced init for integer constants instead of c style casts

2023-01-03 19:31:29 -06:00

parse_hd_keypath.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

partially_downloaded_block.cpp

[fuzz] Assert that omitting missing transactions always fails block reconstruction

2023-01-23 17:29:41 +01:00

policy_estimator_io.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

policy_estimator.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

pow.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

prevector.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

primitives_transaction.cpp

…

process_message.cpp

Merge bitcoin/bitcoin#26686: fuzz: Enable erlay setting in process_message(s) targets

2023-01-19 15:56:58 +01:00

process_messages.cpp

Merge bitcoin/bitcoin#26686: fuzz: Enable erlay setting in process_message(s) targets

2023-01-19 15:56:58 +01:00

protocol.cpp

…

psbt.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

random.cpp

…

rbf.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

rolling_bloom_filter.cpp

…

rpc.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

script_assets_test_minimizer.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

Adapt to libsecp256k1 API changes

2022-12-13 15:08:24 -05:00

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

script_sign.cpp

Merge bitcoin/bitcoin#24149: Signing support for Miniscript Descriptors

2023-02-16 10:01:33 +00:00

script.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

Adapt to libsecp256k1 API changes

2022-12-13 15:08:24 -05:00

signature_checker.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

signet.cpp

…

socks5.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

span.cpp

…

spanparsing.cpp

…

string.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

strprintf.cpp

…

system.cpp

…

timedata.cpp

…

torcontrol.cpp

…

transaction.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

tx_in.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

tx_out.cpp

Use DataStream where possible

2023-01-26 10:44:05 +01:00

tx_pool.cpp

[fuzz] Actually use mocked mempool in tx_pool target

2023-01-20 12:15:01 +01:00

txorphan.cpp

Merge bitcoin/bitcoin#26551: p2p: Track orphans by who provided them

2023-01-26 10:36:18 +00:00

txrequest.cpp

…

util.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

util.h

Fix clang-tidy readability-const-return-type violations

2023-02-01 11:33:35 +01:00

utxo_snapshot.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

validation_load_mempool.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

versionbits.cpp

refactor: use braced init for integer constants instead of c style casts

2023-01-03 19:31:29 -06:00