bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-14 05:40:41 +02:00

History

Merge bitcoin/bitcoin#31251 : test: report detailed msg during utf8 response decoding error

a2c45ae5480a2ee643665d6ecaee9714a287a70e test: report failure during utf8 response decoding (furszy)

Pull request description:

  Useful for debugging issues such https://github.com/bitcoin/bitcoin/pull/31241#issuecomment-2462816933.

  Prints the entire response content instead of printing only the position of the byte it can't be decoded.

  The diff between the error messages can be seen by running the `wallet_migration.py` functional test with the following patch applied:
  ```
  diff --git a/src/wallet/rpc/wallet.cpp b/src/wallet/rpc/wallet.cpp
  --- a/src/wallet/rpc/wallet.cpp(revision d65918c5da52c7d5035b4151dee9ffb2e94d4761)
  +++ b/src/wallet/rpc/wallet.cpp(date 1731005254673)
  @@ -801,7 +801,7 @@
               }

               UniValue r{UniValue::VOBJ};
  -            r.pushKV("wallet_name", res->wallet_name);
  +            r.pushKV("wallet_name", "\xc3\x28");
               if (res->watchonly_wallet) {
                   r.pushKV("watchonly_name", res->watchonly_wallet->GetName());
               }
  ```

ACKs for top commit:
  achow101:
    ACK a2c45ae5480a2ee643665d6ecaee9714a287a70e
  theStack:
    re-ACK a2c45ae5480a2ee643665d6ecaee9714a287a70e
  rkrux:
    tACK a2c45ae5480a2ee643665d6ecaee9714a287a70e
  ismaelsadeeq:
    utACK a2c45ae5480a2ee643665d6ecaee9714a287a70e

Tree-SHA512: 6abb524b5a215c51ec881eea91ebe8174140a88ff3874c8c88676157edae7818801356586a904dbb21b45053183315a6d71dbf917d753611d8e413776b57c484

2024-12-30 14:12:57 -05:00

crypto

crypto: add NUMS_H const

2024-05-14 10:24:31 +02:00

__init__.py

…

address.py

test: check that keyless P2A 'signing' via signrawtransactionwithkey succeeds

2024-08-02 20:13:07 +02:00

authproxy.py

test: report failure during utf8 response decoding

2024-11-11 10:45:01 -05:00