Wladimir J. van der Laan 17de75b028 Merge #19590: p2p, refactor: add CInv transaction message helpers; use in net processing ...

c251d710a4 p2p, refactoring: use CInv helpers in net_processing.cpp (Jon Atack)
4254cd9f8f p2p: add CInv transaction message helper methods (Jon Atack)

Pull request description:

  Following the merge of wtxid relay in #18044, this is the first of three refactoring PRs (this one, #19610, and #19611) with no change in behavior, tightly scoped to ease review, to simplify the net processing code and improve encapsulation:

  - add `CInv` transaction message helper methods, defined in the class

  - use the new helpers in `net_processing.cpp` to simplify the code and improve encapsulation

  Test coverage is provided by the functional p2p tests, notably (from seeing which tests failed when breaking things to test coverage) `p2p_segwit`, `p2p_tx_download`, `p2p_feefilter`, and `p2p_permissions`.

ACKs for top commit:
  fjahr:
    Code review ACK c251d710a4
  laanwj:
    Code review ACK c251d710a4
  vasild:
    ACK c251d71
  theStack:
    Code-Review ACK c251d710a4
  hebasto:
    ACK c251d710a4, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: ead034b3c9e438909b4c5010c570d7930e69063c114290b051b7cebfd9bd5b19f573218bebe8a521256d32e830797f997adad3d85b4539c64ac5762b698e656d

2020-07-30 16:18:06 +02:00

..

bench

Merge #18011: Replace current benchmarking framework with nanobench

2020-07-30 15:34:17 +02:00

compat

…

config

…

consensus

Merge #18044: Use wtxid for transaction relay

2020-07-22 20:58:55 +02:00

crc32c

…

crypto

…

index

…

interfaces

Merge #15935: Add <datadir>/settings.json persistent settings storage

2020-07-23 18:39:42 +02:00

leveldb

…

logging

…

node

Add support for tx-relay via wtxid

2020-07-19 02:05:29 -04:00

policy

doc: Add non-thread-safe note to FeeFilterRounder::round()

2020-07-05 13:46:38 +03:00

primitives

…

qt

Merge #15935: Add <datadir>/settings.json persistent settings storage

2020-07-23 18:39:42 +02:00

rpc

rpc: Avoid useless mempool query in gettxoutproof

2020-07-26 16:44:07 +02:00

script

span: Add Span::empty() and use it in script/descriptor

2020-07-19 20:51:06 +02:00

secp256k1

…

support

…

test

Merge #19534: net: save the network type explicitly in CNetAddr

2020-07-29 13:31:16 +02:00

univalue

…

util

Merge #15935: Add <datadir>/settings.json persistent settings storage

2020-07-23 18:39:42 +02:00

wallet

walletdb: Remove BerkeleyBatch friend class from BerkeleyDatabase

2020-07-22 23:30:19 -04:00

zmq

…

.clang-format

tools: clang-format 6 compatibility

2020-07-06 03:52:37 +02:00

addrdb.cpp

…

addrdb.h

Clean up separated ban/discourage interface

2020-07-03 20:43:55 -07:00

addrman.cpp

…

addrman.h

…

amount.h

…

arith_uint256.cpp

…

arith_uint256.h

…

attributes.h

…

banman.cpp

banlist: log post-swept banlist size at startup

2020-07-08 21:44:45 +08:00

banman.h

Clean up separated ban/discourage interface

2020-07-03 20:43:55 -07:00

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

cli: reduce DefaultRequestHandler memory allocations

2020-07-05 16:39:17 +02:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

…

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

…

bitcoind-res.rc

…

bitcoind.cpp

Add <datadir>/settings.json persistent settings storage.

2020-07-11 05:41:12 -04:00

blockencodings.cpp

…

blockencodings.h

…

blockfilter.cpp

…

blockfilter.h

…

bloom.cpp

…

bloom.h

…

chain.cpp

…

chain.h

…

chainparams.cpp

…

chainparams.h

…

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

…

checkqueue.h

…

clientversion.cpp

…

clientversion.h

…

coins.cpp

…

coins.h

…

compat.h

…

compressor.cpp

…

compressor.h

…

core_io.h

…

core_memusage.h

…

core_read.cpp

…

core_write.cpp

Merge #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv

2020-07-16 21:38:09 +02:00

cuckoocache.h

…

dbwrapper.cpp

…

dbwrapper.h

Drop unused CDBWrapper methods

2020-07-08 14:26:14 +03:00

dummywallet.cpp

…

flatfile.cpp

…

flatfile.h

…

fs.cpp

…

fs.h

…

hash.cpp

…

hash.h

…

httprpc.cpp

…

httprpc.h

…

httpserver.cpp

…

httpserver.h

…

indirectmap.h

…

init.cpp

Merge #18637: coins: allow cache resize after init

2020-07-29 07:53:19 +02:00

init.h

…

key_io.cpp

…

key_io.h

…

key.cpp

…

key.h

…

limitedmap.h

…

logging.cpp

…

logging.h

…

Makefile.am

…

Makefile.bench.include

…

Makefile.crc32c.include

…

Makefile.leveldb.include

…

Makefile.qt_locale.include

…

Makefile.qt.include

…

Makefile.qttest.include

…

Makefile.test_fuzz.include

…

Makefile.test_util.include

…

Makefile.test.include

Merge #18011: Replace current benchmarking framework with nanobench

2020-07-30 15:34:17 +02:00

memusage.h

…

merkleblock.cpp

…

merkleblock.h

…

miner.cpp

…

miner.h

…

net_permissions.cpp

net: Extract download permission from noban

2020-07-09 12:48:05 +02:00

net_permissions.h

net: Extract download permission from noban

2020-07-09 12:48:05 +02:00

net_processing.cpp

Merge #19590: p2p, refactor: add CInv transaction message helpers; use in net processing

2020-07-30 16:18:06 +02:00

net_processing.h

Merge #19472: [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect()

2020-07-24 17:20:58 +02:00

net_types.h

…

net.cpp

Merge #19473: net: Add -networkactive option

2020-07-23 18:32:59 +02:00

net.h

Merge #19473: net: Add -networkactive option

2020-07-23 18:32:59 +02:00

netaddress.cpp

net: save the network type explicitly in CNetAddr

2020-07-27 15:13:24 +02:00

netaddress.h

net: save the network type explicitly in CNetAddr

2020-07-27 15:13:24 +02:00

netbase.cpp

…

netbase.h

…

netmessagemaker.h

…

noui.cpp

…

noui.h

…

optional.h

…

outputtype.cpp

…

outputtype.h

…

pow.cpp

…

pow.h

…

prevector.h

…

protocol.cpp

Add p2p message "wtxidrelay"

2020-07-19 02:10:41 -04:00

protocol.h

p2p: add CInv transaction message helper methods

2020-07-27 11:06:39 +02:00

psbt.cpp

…

psbt.h

…

pubkey.cpp

…

pubkey.h

…

random.cpp

…

random.h

…

randomenv.cpp

…

randomenv.h

…

rest.cpp

rpc: Avoid useless mempool query in gettxoutproof

2020-07-26 16:44:07 +02:00

reverse_iterator.h

…

scheduler.cpp

…

scheduler.h

…

serialize.h

…

shutdown.cpp

…

shutdown.h

…

span.h

span: Add Span::empty() and use it in script/descriptor

2020-07-19 20:51:06 +02:00

streams.h

refactor: Drop unused CBufferedFile::Seek()

2020-07-26 22:46:28 +03:00

sync.cpp

…

sync.h

…

threadinterrupt.cpp

…

threadinterrupt.h

…

threadsafety.h

…

timedata.cpp

…

timedata.h

…

tinyformat.h

…

torcontrol.cpp

…

torcontrol.h

…

txdb.cpp

Merge #18637: coins: allow cache resize after init

2020-07-29 07:53:19 +02:00

txdb.h

…

txmempool.cpp

Add a wtxid-index to the mempool

2020-07-18 19:00:01 -04:00

txmempool.h

Add wtxid to mempool unbroadcast tracking

2020-07-18 19:00:01 -04:00

uint256.cpp

…

uint256.h

…

undo.h

…

validation.cpp

Merge #18637: coins: allow cache resize after init

2020-07-29 07:53:19 +02:00

validation.h

Merge #18637: coins: allow cache resize after init

2020-07-29 07:53:19 +02:00

validationinterface.cpp

…

validationinterface.h

…

version.h

Add p2p message "wtxidrelay"

2020-07-19 02:10:41 -04:00

versionbits.cpp

…

versionbits.h

…

versionbitsinfo.cpp

…

versionbitsinfo.h

…

walletinitinterface.h

…

warnings.cpp

…

warnings.h

…