mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-07-29 05:33:56 +02:00
80e32e120e
05e82d86b0wallet: override minfee checks (fOverrideFeeRate) for fee_rate (Jon Atack)9a670b4f07wallet: update sendtoaddress, send RPC examples with fee_rate (Jon Atack)be481b72e2wallet: use MIN_RELAY_TX_FEE in bumpfee help (Jon Atack)449b730579wallet: provide valid values if invalid estimate mode passed (Jon Atack)6da3afbaeewallet: update remaining rpcwallet fee rate units to BTC/kvB (Jon Atack)173b5b5fe0wallet: update fee rate units, use sat/vB for fee_rate error messages (Jon Atack)7f9835a05awallet: remove fee rates from conf_target helps (Jon Atack)b7994c01e9wallet: add fee_rate unit warnings to bumpfee (Jon Atack)410e471fa4wallet: remove redundant bumpfee fee_rate checks (Jon Atack)a0d4957473wallet: introduce fee_rate (sat/vB) param/option (Jon Atack)e21212f01bwallet: remove unneeded WALLET_BTC_KB_TO_SAT_B constant (Jon Atack)6112cf20d4wallet: add CFeeRate ctor doxygen documentation (Jon Atack)3f72791613wallet: fix bug in RPC send options (Jon Atack) Pull request description: This PR builds on #11413 and #20220 to address #19543. - replace overloading the conf_target and estimate_mode params with `fee_rate` in sat/vB in the sendtoaddress, sendmany, send, fundrawtransaction, walletcreatefundedpsbt, and bumpfee RPCs - allow non-actionable conf_target value of `0` and estimate_mode value of `""` to be passed to use `fee_rate` as a positional argument, in addition to as a named argument - fix a bug in the experimental send RPC described in https://github.com/bitcoin/bitcoin/pull/20220#discussion_r513789526 where args were not being passed correctly into the options values - update the feerate error message units for these RPCs from BTC/kB to sat/vB - update the test coverage, help docs, doxygen docs, and some of the RPC examples - other changes to address the excellent review feedback See this wallet meeting log for more context: http://www.erisian.com.au/bitcoin-core-dev/log-2020-11-06.html#l-309 ACKs for top commit: achow101: re-ACK05e82d8MarcoFalke: review ACK05e82d86b0did not test and found a few style nits, which can be fixed later 🍯 Xekyo: tACK05e82d86b0Sjors: utACK05e82d86b0Tree-SHA512: a4ee5f184ada53f1840b2923d25873bda88c5a2ae48e67eeea2417a0b35154798cfdb3c147b05dd56bd6608a784e1b91623bb985ee2ab9ef2baaec22206d0a9c