Ava Chow 975b115e1a Merge bitcoin/bitcoin#31198: init: warn, don't error, when '-upnp' is set ...

a1b3ccae4b init: warn, don't error, when '-upnp' is set (Antoine Poinsot)

Pull request description:

  It prevented the GUI from starting when its settings.json had the -upnp option set. This also doesn't prevent the node from running, so this error didn't need to be fatal.

  Thanks to Sjors for bringing attention to what i broke and to Maflcko for suggesting a simple short term fix.

  Fixes https://github.com/bitcoin-core/gui/issues/843.

ACKs for top commit:
  maflcko:
    lgtm ACK a1b3ccae4b
  kevkevinpal:
    Concept ACK [a1b3cca](a1b3ccae4b)
  achow101:
    ACK a1b3ccae4b
  tdb3:
    ACK a1b3ccae4b

Tree-SHA512: ceb1513bf532698e5143d64430a065f39626ef0d2708103ffc8ab7f81e8393f488af2350c5a299bc80f966add82a3951b4d81ae8b0e3070c0d15c94e8db4badd

2024-11-01 17:15:26 -04:00

..

bench

bench: add coverage for wallet migration process

2024-10-21 08:29:22 -03:00

common

Merge bitcoin/bitcoin#31156: test: Don't enforce BIP94 on regtest unless specified by arg

2024-10-30 17:00:14 -04:00

compat

…

config

…

consensus

Move BlockMerkleBranch back to merkle.{h,cpp}

2024-09-26 09:48:31 +02:00

crc32c

…

crypto

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

index

refactor: Split up NodeContext shutdown_signal and shutdown_request

2024-10-01 09:10:54 +02:00

init

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

interfaces

interfaces: remove now unused 'use_upnp' arg from 'mapPort'

2024-10-24 18:23:30 +02:00

ipc

Add submitSolution to BlockTemplate interface

2024-09-26 10:04:45 +02:00

kernel

test: Don't enforce BIP94 on regtest unless specified by arg

2024-10-28 11:38:38 -04:00

leveldb

…

logging

…

minisketch

…

node

Merge bitcoin/bitcoin#31064: init: Correct coins db cache size setting

2024-10-29 15:12:41 -04:00

policy

fees: Log non-fatal errors as [warning], instead of info-level

2024-10-23 18:43:32 +02:00

primitives

…

qt

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

rpc

Merge bitcoin/bitcoin#31043: rpc: getorphantxs follow-up

2024-10-29 14:49:19 -04:00

script

Fix unsigned integer overflows in interpreter

2024-10-01 10:45:44 +02:00

secp256k1

…

support

…

test

Merge bitcoin/bitcoin#30110: refactor: TxDownloadManager + fuzzing

2024-10-29 14:41:12 -04:00

univalue

…

util

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

wallet

fuzz: fix implicit-integer-sign-change in wallet_create_transaction

2024-11-01 10:58:44 -03:00

zmq

cmake: Add FindZeroMQ module

2024-10-25 18:09:36 +01:00

.clang-format

…

.clang-tidy

…

addrdb.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

addrdb.h

…

addresstype.cpp

…

addresstype.h

…

addrman_impl.h

…

addrman.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

addrman.h

…

arith_uint256.cpp

…

arith_uint256.h

…

attributes.h

…

banman.cpp

…

banman.h

…

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bip324.cpp

…

bip324.h

…

bitcoin-chainstate.cpp

…

bitcoin-cli-res.rc

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

bitcoin-cli.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

bitcoin-tx-res.rc

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

bitcoin-tx.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

bitcoin-util-res.rc

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

bitcoin-util.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

bitcoin-wallet-res.rc

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

bitcoin-wallet.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

bitcoind-res.rc

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

bitcoind.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

blockencodings.cpp

…

blockencodings.h

…

blockfilter.cpp

…

blockfilter.h

…

chain.cpp

…

chain.h

…

chainparams.cpp

test: Don't enforce BIP94 on regtest unless specified by arg

2024-10-28 11:38:38 -04:00

chainparams.h

…

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

…

checkqueue.h

…

clientversion.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

clientversion.h

scripted-diff: Clarify "user agent" variable name

2024-10-28 12:35:49 +00:00

cluster_linearize.h

clusterlin: remove Cluster type

2024-10-07 13:49:36 -04:00

CMakeLists.txt

Merge bitcoin/bitcoin#30110: refactor: TxDownloadManager + fuzzing

2024-10-29 14:41:12 -04:00

coins.cpp

…

coins.h

…

compressor.cpp

…

compressor.h

…

core_io.h

…

core_memusage.h

…

core_read.cpp

…

core_write.cpp

…

cuckoocache.h

…

dbwrapper.cpp

…

dbwrapper.h

…

deploymentinfo.cpp

…

deploymentinfo.h

…

deploymentstatus.cpp

…

deploymentstatus.h

…

dummywallet.cpp

…

external_signer.cpp

…

external_signer.h

…

flatfile.cpp

…

flatfile.h

…

hash.cpp

…

hash.h

…

headerssync.cpp

…

headerssync.h

…

httprpc.cpp

…

httprpc.h

…

httpserver.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

httpserver.h

…

i2p.cpp

…

i2p.h

…

indirectmap.h

…

init.cpp

init: warn, don't error, when '-upnp' is set

2024-10-31 14:05:50 -04:00

init.h

…

key_io.cpp

key: clear out secret data in DecodeExtKey

2024-10-27 15:38:54 +01:00

key_io.h

…

key.cpp

…

key.h

…

logging.cpp

log: Enforce trailing newline, Remove redundant m_started_new_line

2024-10-01 11:31:39 +02:00

logging.h

log: Enforce trailing newline, Remove redundant m_started_new_line

2024-10-01 11:31:39 +02:00

mapport.cpp

mapport: remove dead code in DispatchMapPort

2024-10-25 15:02:07 -04:00

mapport.h

interfaces: remove now unused 'use_upnp' arg from 'mapPort'

2024-10-24 18:23:30 +02:00

memusage.h

…

merkleblock.cpp

…

merkleblock.h

…

net_permissions.cpp

…

net_permissions.h

…

net_processing.cpp

[p2p] add TxDownloadOptions bool to make TxRequestTracker deterministic

2024-10-24 21:23:56 -04:00

net_processing.h

net: add GetOrphanTransactions() to PeerManager

2024-10-01 21:55:18 -04:00

net_types.cpp

…

net_types.h

…

net.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

net.h

daemon: remove UPnP support

2024-10-24 18:23:30 +02:00

netaddress.cpp

…

netaddress.h

…

netbase.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

netbase.h

…

netgroup.cpp

…

netgroup.h

…

netmessagemaker.h

…

noui.cpp

…

noui.h

…

outputtype.cpp

…

outputtype.h

…

pow.cpp

Introduce g_fuzzing global for fuzzing checks

2024-10-25 13:12:55 +01:00

pow.h

…

prevector.h

…

protocol.cpp

…

protocol.h

…

psbt.cpp

…

psbt.h

…

pubkey.cpp

…

pubkey.h

…

random.cpp

Merge bitcoin/bitcoin#31124: util: Remove RandAddSeedPerfmon

2024-10-24 18:08:12 -04:00

random.h

util: Remove RandAddSeedPerfmon

2024-10-21 23:24:17 +02:00

randomenv.cpp

util: Remove RandAddSeedPerfmon

2024-10-21 23:24:17 +02:00

randomenv.h

…

rest.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

rest.h

…

scheduler.cpp

…

scheduler.h

…

serialize.h

…

signet.cpp

…

signet.h

…

span.h

…

streams.cpp

…

streams.h

…

sync.cpp

…

sync.h

…

threadsafety.h

…

tinyformat.h

…

torcontrol.cpp

…

torcontrol.h

…

txdb.cpp

…

txdb.h

…

txmempool.cpp

…

txmempool.h

…

txorphanage.cpp

net: add GetOrphanTransactions() to PeerManager

2024-10-01 21:55:18 -04:00

txorphanage.h

[fuzz] txdownloadman and txdownload_impl

2024-10-24 21:23:56 -04:00

txrequest.cpp

…

txrequest.h

…

uint256.cpp

…

uint256.h

…

undo.h

…

validation.cpp

Merge bitcoin/bitcoin#31064: init: Correct coins db cache size setting

2024-10-29 15:12:41 -04:00

validation.h

…

validationinterface.cpp

refactor: include the proper header rather than forward-declaring RemovalReasonToString

2024-10-08 15:25:47 +00:00

validationinterface.h

…

versionbits.cpp

…

versionbits.h

…

walletinitinterface.h

…