mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-11 21:20:39 +02:00
406c2348dd
The previous bound (~year 2262) was too permissive: paths that add an offset to the mocked time (e.g. the future-time check in ContextualCheckBlockHeader) can overflow int64_t (caught by UBSan), and paths that assign it to a uint32_t field (e.g. pblock->nTime in miner.cpp) silently truncate it (caught by the integer sanitizer). UINT32_MAX is the natural ceiling since block header nTime is uint32_t, and mocking beyond it is meaningless for anything consensus-related. Add setmocktime bound checks to the existing _test_y2106 case in rpc_blockchain.py, and remove the negative bound check from rpc_uptime.py.
37 lines
1.1 KiB
Python
Executable File
37 lines
1.1 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017-present The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the RPC call related to the uptime command.
|
|
|
|
Test corresponds to code in rpc/server.cpp.
|
|
"""
|
|
|
|
import time
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
|
|
|
|
class UptimeTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
self.setup_clean_chain = True
|
|
|
|
def run_test(self):
|
|
self._test_uptime()
|
|
|
|
def _test_uptime(self):
|
|
time.sleep(1) # Do some work before checking uptime
|
|
uptime_before = self.nodes[0].uptime()
|
|
assert uptime_before > 0, "uptime should begin at app start"
|
|
|
|
wait_time = 20_000
|
|
self.nodes[0].setmocktime(int(time.time()) + wait_time)
|
|
uptime_after = self.nodes[0].uptime()
|
|
self.nodes[0].setmocktime(0)
|
|
assert uptime_after - uptime_before < wait_time, "uptime should not jump with wall clock"
|
|
|
|
|
|
if __name__ == '__main__':
|
|
UptimeTest(__file__).main()
|